blender/blender-addons-contrib
Archived
3
11
Fork 17
Code Pull Requests 3 Activity

New addon: Import Autodesk .max #17

Closed
Sebastian Sille wants to merge 2 commits from nrgsille-patch-1 into main
pull from: nrgsille-patch-1
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 8 Commits 2 Files Changed 1 +23 -47
Sebastian Sille commented 2023-11-16 00:53:28 +01:00
Member
Copy Link

A new addon for importing meshes and materials from Autodesk .max files

A new addon for importing meshes and materials from Autodesk .max files
io_import_max.py
49 KiB
Sebastian Sille self-assigned this 2023-11-16 00:53:28 +01:00
Sebastian Sille added 1 commit 2023-11-16 00:53:30 +01:00 
A new addon for importing meshes and materials from Autodesk .max files
Sebastian Sille requested review from Aaron Carlisle 2023-11-16 01:17:09 +01:00
Sebastian Sille requested review from Thomas Barlow 2023-11-16 01:17:09 +01:00
Thomas Barlow commented 2023-11-16 15:13:24 +01:00
Member
Copy Link

Umm, I'm not actually a Blender developer, just a contributor, so I don't think I have much say over new addons.

Umm, I'm not actually a Blender developer, just a contributor, so I don't think I have much say over new addons.
Sebastian Sille commented 2023-11-16 18:41:16 +01:00
Author
Member
Copy Link

Umm, I'm not actually a Blender developer, just a contributor, so I don't think I have much say over new addons.

@Mysteryem Okay, I try to get someone for review in blender chat ;)

> Umm, I'm not actually a Blender developer, just a contributor, so I don't think I have much say over new addons. @Mysteryem Okay, I try to get someone for review in blender chat ;)
Sebastian Sille requested review from Jacques Lucke 2023-11-16 20:46:51 +01:00
Sebastian Sille added 1 commit 2023-11-16 23:56:19 +01:00 
Removed unused definitions
Jacques Lucke commented 2023-11-17 23:19:46 +01:00
Member
Copy Link

I'm not really the right person to review this either, but the patch is a bit confusing. It says that it is adding a new addon, but it just changes some existing code.

Also check this: https://wiki.blender.org/wiki/Process/Addons#Submitting_an_Add-on

Did people test the addon already? Is there some documentation?

I'm not really the right person to review this either, but the patch is a bit confusing. It says that it is adding a new addon, but it just changes some existing code. Also check this: https://wiki.blender.org/wiki/Process/Addons#Submitting_an_Add-on Did people test the addon already? Is there some documentation?
Sebastian Sille commented 2023-11-17 23:30:47 +01:00
Author
Member
Copy Link

I'm not really the right person to review this either, but the patch is a bit confusing. It says that it is adding a new addon, but it just changes some existing code.

Also check this: https://wiki.blender.org/wiki/Process/Addons#Submitting_an_Add-on

Did people test the addon already? Is there some documentation?

@JacquesLucke , yea I already commited the code when I was instructed to get a review for it, thats why it is now a PR for a already existing addon, I tested the addon and it works with all .max files I have.
I requested you for a review because you are mentioned as module maintainer for Python API and addons here:
https://projects.blender.org/blender/blender/wiki/Module%3A-Community-Maintained-Add-ons -> https://projects.blender.org/blender/blender/wiki/Module:-Python-API-&-Text-Editor

> I'm not really the right person to review this either, but the patch is a bit confusing. It says that it is adding a new addon, but it just changes some existing code. > > Also check this: https://wiki.blender.org/wiki/Process/Addons#Submitting_an_Add-on > > Did people test the addon already? Is there some documentation? @JacquesLucke , yea I already commited the code when I was instructed to get a review for it, thats why it is now a PR for a already existing addon, I tested the addon and it works with all .max files I have. I requested you for a review because you are mentioned as module maintainer for Python API and addons here: https://projects.blender.org/blender/blender/wiki/Module%3A-Community-Maintained-Add-ons -> https://projects.blender.org/blender/blender/wiki/Module:-Python-API-&-Text-Editor
Jacques Lucke commented 2023-11-17 23:32:53 +01:00
Member
Copy Link

Better remove the addon again and create a proper pull request that actually adds the addon. Also, you might want to provide a better description with some motivation for the inclusion here, and maybe you could also provide some files to test the addon.

Better remove the addon again and create a proper pull request that actually adds the addon. Also, you might want to provide a better description with some motivation for the inclusion here, and maybe you could also provide some files to test the addon.
Sebastian Sille closed this pull request 2023-11-17 23:35:59 +01:00
Sebastian Sille commented 2023-11-17 23:37:58 +01:00
Author
Member
Copy Link

Better remove the addon again and create a proper pull request that actually adds the addon. Also, you might want to provide a better description with some motivation for the inclusion here, and maybe you could also provide some files to test the addon.

@JacquesLucke Okay, will do that

> Better remove the addon again and create a proper pull request that actually adds the addon. Also, you might want to provide a better description with some motivation for the inclusion here, and maybe you could also provide some files to test the addon. @JacquesLucke Okay, will do that
Sebastian Sille changed title from New addon: Import Autodesk .max to New addon: Import Autodesk .max 2023-11-19 17:21:59 +01:00
Paul Kotelevets commented 2024-01-14 20:59:44 +01:00
First-time contributor
Copy Link

Interesting!
Can you provide a link to a new PR here?

Interesting! Can you provide a link to a new PR here?
Sebastian Sille commented 2024-01-14 22:12:31 +01:00
Author
Member
Copy Link

Interesting!
Can you provide a link to a new PR here?

@1D_Inc This addon has already been released with PR #22 under a new name: io_scene_max
Can be found here: https://projects.blender.org/blender/blender-addons-contrib/src/branch/main/io_scene_max

> Interesting! > Can you provide a link to a new PR here? @1D_Inc This addon has already been released with PR #22 under a new name: io_scene_max Can be found here: https://projects.blender.org/blender/blender-addons-contrib/src/branch/main/io_scene_max
👍 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Aaron Carlisle
Thomas Barlow
Jacques Lucke
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Sebastian Sille
4 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons-contrib#17
No description provided.
Delete Branch "nrgsille-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?