blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Revert "Node Wrangler: remove obsolete Geometry Nodes preview" #104419

Closed
Wannes Malfait wants to merge 2 commits from wannes.malfait/blender-addons:revert_node_wrangler into blender-v3.5-release
pull from: wannes.malfait/blender-addons:revert_node_wrangler
merge into: blender:blender-v3.5-release

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 2 Files Changed 1 +95 -3
Wannes Malfait commented 2023-02-18 15:56:10 +01:00
Member
Copy Link

The supposed "obsolete" functionality turned out to still be used by a lot of people. I think this commit should therefore be reverted.

This reverts commit 48320b2d9f.

The supposed "obsolete" functionality turned out to still be used by a lot of people. I think this commit should therefore be reverted. This reverts commit 48320b2d9f3d829c46ae4a6a6aab0bd94e80c830.
👍 2
Gurra commented 2023-02-19 14:11:09 +01:00
First-time contributor
Copy Link

Yes this was a weird removal. Using the new viewer node has it's uses, but when using this everything that's connected to the output will still be calculated, so with heavier node trees this can get veeery slow.
You can still use O (and change it to shift-alt-click) which is the shortcut for "connect to output" which is ALMOST the same, but not exactly the same since when inside a node group it will only connect to that groups output and not the whole trees output as it did before.

Yes this was a weird removal. Using the new viewer node has it's uses, but when using this everything that's connected to the output will still be calculated, so with heavier node trees this can get veeery slow. You can still use O (and change it to shift-alt-click) which is the shortcut for "connect to output" which is ALMOST the same, but not exactly the same since when inside a node group it will only connect to that groups output and not the whole trees output as it did before.
Damien Picard reviewed 2023-02-19 16:21:38 +01:00
node_wrangler/__init__.py
@ -1289,1 +1289,4 @@
# If false, the operator is not executed if the current node group happens to be a geometry nodes group.
# This is needed because geometry nodes has its own viewer node that uses the same shortcut as in the compositor.
# Geometry Nodes support can be removed here once the viewer node is supported in the viewport.
Damien Picard commented 2023-02-19 16:18:59 +01:00
Member
Copy Link

This third line should be removed so that GN support is not removed again.

This third line should be removed so that GN support is not removed again.
Wannes Malfait commented 2023-02-20 10:38:47 +01:00
Author
Member
Copy Link

You're right

You're right
wannes.malfait marked this conversation as resolved
Damien Picard commented 2023-02-19 16:22:58 +01:00
Member
Copy Link

You should base this PR on the 3.5 branch instead of main, if this change is to be included there.

You should base this PR on the 3.5 branch instead of main, if this change is to be included there.
👍 1
Wannes Malfait force-pushed revert_node_wrangler from eb1f7e174d to c927f34240 2023-02-20 10:36:54 +01:00 Compare
Wannes Malfait changed target branch from main to blender-v3.5-release 2023-02-20 10:37:55 +01:00
Wannes Malfait commented 2023-02-20 10:43:09 +01:00
Author
Member
Copy Link

This fixes #104413

This fixes #104413
Jacques Lucke commented 2023-02-20 11:06:51 +01:00
Member
Copy Link

Committed this separately: 19e187753a, 16f4da4996.

Committed this separately: 19e187753a35d59abe02617d1c121bdc96bdae5d, 16f4da4996867b68b1bc4c29bb34392d493436d2.
Jacques Lucke closed this pull request 2023-02-20 11:06:52 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104419
No description provided.
Delete Branch "wannes.malfait/blender-addons:revert_node_wrangler"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?