blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Node Wrangler: refactor by splitting the script into several files #104463

Merged
Damien Picard merged 2 commits from pioverfour/blender-addons:dp_node_wrangler_refactor into main 2023-03-05 12:24:26 +01:00
Conversation 2 Commits 2 Files Changed 10 +4668 -4492
Damien Picard commented 2023-03-02 18:55:13 +01:00
Member
Copy Link

After discussion in !104444 and !104457 it became apparent that Node
Wrangler needs a bit of work to make its maintenance more comfortable.
So, split the code into interface, operators and preferences, and a
few specific utility files.

The bulk of the add-on now resides in operators.py.

After discussion in !104444 and !104457 it became apparent that Node Wrangler needs a bit of work to make its maintenance more comfortable. So, split the code into interface, operators and preferences, and a few specific utility files. The bulk of the add-on now resides in operators.py.
Damien Picard requested review from Wannes Malfait 2023-03-02 18:55:31 +01:00
Damien Picard force-pushed dp_node_wrangler_refactor from d286104fa6 to 15785d9cdb 2023-03-02 18:59:34 +01:00 Compare
Wannes Malfait commented 2023-03-04 14:36:46 +01:00
Member
Copy Link

This looks good to me. I think the separation and naming of the files makes sense. We should make sure that the changes in !104457 get applied when we merge this though.

This looks good to me. I think the separation and naming of the files makes sense. We should make sure that the changes in !104457 get applied when we merge this though.
Wannes Malfait approved these changes 2023-03-04 14:38:56 +01:00
Damien Picard force-pushed dp_node_wrangler_refactor from 15785d9cdb to c1382e3899 2023-03-05 12:21:22 +01:00 Compare
Damien Picard merged commit 1ee8da0246 into main 2023-03-05 12:24:26 +01:00
Damien Picard deleted branch dp_node_wrangler_refactor 2023-03-05 12:24:26 +01:00
Damien Picard commented 2023-03-05 12:27:32 +01:00
Author
Member
Copy Link

This looks good to me. I think the separation and naming of the files makes sense. We should make sure that the changes in !104457 get applied when we merge this though.

Thanks, I applied it beforehand to the 3.5 branch, rebased and pushed this PR.

> This looks good to me. I think the separation and naming of the files makes sense. We should make sure that the changes in !104457 get applied when we merge this though. Thanks, I applied it beforehand to the 3.5 branch, rebased and pushed this PR.
Sign in to join this conversation.
Reviewers
No reviewers
Wannes Malfait
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104463
No description provided.
Delete Branch "pioverfour/blender-addons:dp_node_wrangler_refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?