Fix #104438 : Lazy mix connects wrong sockets #104457

Wannes Malfait · 2023-02-28T15:45:41+01:00

Wannes Malfait commented

2023-02-28 15:45:41 +01:00

Because the new mix nodes have different modes, the correct output
socket to connect is not just the first one, but the first enabled one.
There were already some checks in place for this, but apparently not yet
in all the needed places.

The current state of the code for the "Merge Nodes" operator is
terrible, and should probably be refactored in a future update. It is
becoming very hard to maintain.

Because the new mix nodes have different modes, the correct output socket to connect is not just the first one, but the first enabled one. There were already some checks in place for this, but apparently not yet in all the needed places. The current state of the code for the "Merge Nodes" operator is terrible, and should probably be refactored in a future update. It is becoming very hard to maintain.

Wannes Malfait added 1 commit 2023-02-28 15:45:43 +01:00

Fix #104438 : Lazy mix connects wrong sockets a0bd936d6b

Because the new mix nodes have different modes, the correct output
socket to connect is not just the first one, but the first enabled one.
There were already some checks in place for this, but apparently not yet
in all the needed places.

The current state of the code for the "Merge Nodes" operator is
terrible, and should probably be refactored in a future update. It is
becoming very hard to maintain.

Wannes Malfait commented

2023-02-28 15:49:06 +01:00

@pioverfour I tested this as much as I could, but I'm not aware of all of node wrangler's functionality. Could you test this as well to make sure that there is not some other thing that I forgot to fix, or broke by accident?

Wannes Malfait requested review from Jacques Lucke 2023-02-28 15:49:38 +01:00

Wannes Malfait requested review from Damien Picard 2023-02-28 15:49:38 +01:00

Damien Picard commented

2023-02-28 20:06:19 +01:00

I'm not aware of all of node wrangler's functionality. Could you test this as well to make sure that there is not some other thing that I forgot to fix, or broke by accident?

Me neither, I probably use one tenth of it! I didn’t even know about the lazy mix reconnect.
I’ll test the PR tomorrow. :)

> I'm not aware of all of node wrangler's functionality. Could you test this as well to make sure that there is not some other thing that I forgot to fix, or broke by accident? Me neither, I probably use one tenth of it! I didn’t even know about the lazy mix reconnect. I’ll test the PR tomorrow. :)

👍 1

Damien Picard approved these changes 2023-03-01 14:18:01 +01:00

Damien Picard left a comment

LGTM.

Out of scope for this PR, but it would be nice to detect the socket types for shading nodes, and use that as the type for the mix node since it can now be float, color, or vector.

LGTM. Out of scope for this PR, but it would be nice to detect the socket types for shading nodes, and use that as the type for the mix node since it can now be float, color, or vector.

Wannes Malfait commented

2023-03-01 15:40:57 +01:00

Out of scope for this PR, but it would be nice to detect the socket types for shading nodes, and use that as the type for the mix node since it can now be float, color, or vector.

I was thinking the same thing, but that is indeed a new feature, and should be for 3.6. It would probably be best to refactor the current code before that change though (and maybe add some tests).

> Out of scope for this PR, but it would be nice to detect the socket types for shading nodes, and use that as the type for the mix node since it can now be float, color, or vector. I was thinking the same thing, but that is indeed a new feature, and should be for 3.6. It would probably be best to refactor the current code before that change though (and maybe add some tests).

Damien Picard referenced this pull request

2023-03-02 19:00:32 +01:00

Node Wrangler: refactor by splitting the script into several files #104463

Wannes Malfait referenced this pull request

2023-03-04 14:36:46 +01:00

Node Wrangler: refactor by splitting the script into several files #104463

Damien Picard merged commit f592ca1059 into blender-v3.5-release

2023-03-05 11:48:01 +01:00

Damien Picard referenced this issue from a commit

2023-03-05 11:48:01 +01:00

Fix #104438 : Lazy mix connects wrong sockets

Damien Picard referenced this issue from a commit