blender/blender-addons
19
43
Fork 96
Code Issues 630 Pull Requests 27 Projects 1 Releases Wiki Activity

Mesh: Update addons for auto smooth removal #104609

Merged
Hans Goudey merged 10 commits from HooglyBoogly/blender-addons:refactor-mesh-corner-normals-lazy into main 2023-10-20 16:53:48 +02:00
Conversation 7 Commits 10 Files Changed 20 +24 -119
Hans Goudey commented 2023-05-18 22:13:57 +02:00
Member
Copy Link

See blender/blender#108014

See https://projects.blender.org/blender/blender/pulls/108014
Hans Goudey added 1 commit 2023-05-18 22:14:00 +02:00
Sebastian Sille commented 2023-05-20 14:31:28 +02:00
Member
Copy Link

@HooglyBoogly
I just added an animation update for io_scene_3ds
It also contains the morph smooth chunk wich uses auto smooth
#104613

@HooglyBoogly I just added an animation update for [io_scene_3ds](https://projects.blender.org/blender/blender-addons/src/branch/main/io_scene_3ds) It also contains the morph smooth chunk wich uses auto smooth #104613
Sebastian Sille added 1 commit 2023-05-20 14:32:49 +02:00
Hans Goudey added 1 commit 2023-08-30 05:57:42 +02:00
Hans Goudey added 1 commit 2023-09-28 23:35:56 +02:00
Hans Goudey added 1 commit 2023-09-29 03:07:44 +02:00
Hans Goudey added 1 commit 2023-09-29 18:27:22 +02:00
Hans Goudey added 1 commit 2023-09-29 18:32:17 +02:00
Hans Goudey added 2 commits 2023-10-19 17:45:54 +02:00
Hans Goudey added 1 commit 2023-10-20 15:59:44 +02:00
Hans Goudey merged commit b1fbf73a08 into main 2023-10-20 16:53:48 +02:00
Hans Goudey deleted branch refactor-mesh-corner-normals-lazy 2023-10-20 16:53:48 +02:00
Julien Duroure commented 2023-10-21 12:04:58 +02:00
Member
Copy Link

@HooglyBoogly This commit broke tests on glTF I/O. Investigation in progress to know if test cases must be updated or if we need to fix glTF I/O addon

@HooglyBoogly This commit broke tests on glTF I/O. Investigation in progress to know if test cases must be updated or if we need to fix glTF I/O addon
Hans Goudey commented 2023-10-21 12:12:26 +02:00
Author
Member
Copy Link

Ah, sorry about that. Please let me know here or in chat how I can help.

Ah, sorry about that. Please let me know here or in chat how I can help.
Julien Duroure commented 2023-10-21 13:31:18 +02:00
Member
Copy Link

@HooglyBoogly

First thing, seems setting use_smooth attribute is broken now.

On default cube, set it to smooth by hand (right click => smooth shading).

Then run this:

import bpy
import numpy as np

mesh = bpy.context.object.data

num_polys = len(mesh.polygons)
test = np.empty(num_polys, dtype=bool)

test = [False] * num_polys
mesh.polygons.foreach_set('use_smooth', test)
mesh.update()

On 4.0, cube is back to flat
On 4.1, cube stays smooth

@HooglyBoogly First thing, seems setting use_smooth attribute is broken now. On default cube, set it to smooth by hand (right click => smooth shading). Then run this: ``` import bpy import numpy as np mesh = bpy.context.object.data num_polys = len(mesh.polygons) test = np.empty(num_polys, dtype=bool) test = [False] * num_polys mesh.polygons.foreach_set('use_smooth', test) mesh.update() ``` On 4.0, cube is back to flat On 4.1, cube stays smooth
Hans Goudey commented 2023-10-21 14:56:37 +02:00
Author
Member
Copy Link

Thanks, I fixed that here: b4e6ef4279

Thanks, I fixed that here: https://projects.blender.org/blender/blender/commit/b4e6ef42798e45775bdd39671b65e79283d24f0d
Julien Duroure commented 2023-10-21 16:48:35 +02:00
Member
Copy Link

@HooglyBoogly This seems to be fixed, thanks!
Waiting tomorrow's build to run CI tests online, but seems this is ok with my local build from main branch.

@HooglyBoogly This seems to be fixed, thanks! Waiting tomorrow's build to run CI tests online, but seems this is ok with my local build from main branch.
Sebastian Sille commented 2023-10-21 20:02:38 +02:00
Member
Copy Link

@HooglyBoogly The 3ds importer also raised a TypeError, I attached a Traceback Screenshot
I guess it has to be child.data.set_sharp_from_angle(angle=smooth_angle) and not child.data.set_sharp_from_angle(smooth_angle)

@HooglyBoogly The 3ds importer also raised a TypeError, I attached a Traceback Screenshot I guess it has to be `child.data.set_sharp_from_angle(angle=smooth_angle)` and not `child.data.set_sharp_from_angle(smooth_angle)`
blender-addons-3dsbug.png
84 KiB
blender-addons-3dsbug.png
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104609
No description provided.
Delete Branch "HooglyBoogly/blender-addons:refactor-mesh-corner-normals-lazy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?