blender
/
blender
48
203
Fork 261
Code Issues 5.5k Pull Requests 349 Projects 19 Releases Wiki Activity

WIP: Mesh: Replace auto smooth with node group #108014

Draft
Hans Goudey wants to merge 65 commits from HooglyBoogly/blender:refactor-mesh-corner-normals-lazy into main
pull from: HooglyBoogly/blender:refactor-mesh-corner-normals-lazy
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 65 Files Changed 88
Hans Goudey commented 2023-05-17 16:41:42 +02:00
Collaborator

Design task: #93551

This PR replaces the auto smooth option with a geometry nodes modifier
that sets the sharp edge attribute. This simplifies the process of
normal computation, and allows Blender to choose between face, vertex,
and face corner normals based on the sharp edge and face attributes.

Addons are updated here: blender/blender-addons#104609

TODO

  • More description of the improvements and tradeoffs in the PR

Breaking Changes

  • use_auto_smooth is removed. Face corner normals are now used automatically if there are mixed smooth vs. not smooth tags
  • auto_smooth_angle is removed. Replaced by a modifier (or operator) controlling the sharp edge attribute.
  • create_normals_split, calc_normals_split, and free_normals_split are removed. Replaced by lazy calculation of face corner normals.

Tests

  • bmesh_split_faces needs updates to test file because of Python API removals
  • geo_node_curves_test_deform_curves_on_surface has slightly different results because face corner normals are used instead of interpolated vertex normals
Design task: #93551 This PR replaces the auto smooth option with a geometry nodes modifier that sets the sharp edge attribute. This simplifies the process of normal computation, and allows Blender to choose between face, vertex, and face corner normals based on the sharp edge and face attributes. Addons are updated here: https://projects.blender.org/blender/blender-addons/pulls/104609 ### TODO - More description of the improvements and tradeoffs in the PR ### Breaking Changes - `use_auto_smooth` is removed. Face corner normals are now used automatically if there are mixed smooth vs. not smooth tags - `auto_smooth_angle` is removed. Replaced by a modifier (or operator) controlling the sharp edge attribute. - `create_normals_split`, `calc_normals_split`, and `free_normals_split` are removed. Replaced by lazy calculation of face corner normals. ### Tests - `bmesh_split_faces` needs updates to test file because of Python API removals - `geo_node_curves_test_deform_curves_on_surface` has slightly different results because face corner normals are used instead of interpolated vertex normals
❤️ 3 🎉 5 🚀 2
Hans Goudey added 42 commits 2023-05-17 16:41:55 +02:00
f44e13579a Progress removing auto smooth 
This needs to wait until 4.0
55dd8b2db5 Progress 
Need the normals shared cache changes to move forward here
Hans Goudey added this to the Nodes & Physics project 2023-05-17 21:13:46 +02:00
Hans Goudey added this to the 4.0 milestone 2023-05-17 21:13:55 +02:00
Hans Goudey added 2 commits 2023-05-17 22:39:57 +02:00
Hans Goudey added 3 commits 2023-05-17 23:11:43 +02:00
Hans Goudey added 1 commit 2023-05-18 00:53:59 +02:00
Jesse Yurkovich commented 2023-05-18 02:32:18 +02:00
Collaborator

A good number of our shipped addons make use of all the APIs removed. They'll have to be updated too.

A good number of our shipped addons make use of all the APIs removed. They'll have to be updated too.
Hans Goudey added 2 commits 2023-05-18 15:45:01 +02:00
Hans Goudey commented 2023-05-18 22:14:38 +02:00
Poster
Collaborator

Right, I uploaded my changes to addons here: blender/blender-addons#104609

Right, I uploaded my changes to addons here: https://projects.blender.org/blender/blender-addons/pulls/104609
Hans Goudey added 1 commit 2023-05-18 22:15:50 +02:00
Hans Goudey added 1 commit 2023-05-19 20:18:52 +02:00
Paul Kotelevets commented 2023-05-20 00:03:53 +02:00

Is it planned to use autosmooth as a modifier?

Is it planned to use autosmooth as a modifier?
Hans Goudey added 4 commits 2023-05-24 01:25:49 +02:00
Hans Goudey added 1 commit 2023-05-24 01:29:05 +02:00
Hans Goudey added 2 commits 2023-05-24 15:45:52 +02:00
Hans Goudey added 2 commits 2023-06-03 03:43:01 +02:00
Hans Goudey added 3 commits 2023-06-07 17:20:29 +02:00
Hans Goudey added 1 commit 2023-06-07 20:30:48 +02:00
This pull request is marked as a work in progress.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
Interest
Alembic
   
Interest
Animation & Rigging
   
Interest
Asset Browser
   
Interest
Asset Browser Project Overview
   
Interest
Audio
   
Interest
Automated Testing
   
Interest
Blender Asset Bundle
   
Interest
BlendFile
   
Interest
Collada
   
Interest
Compositing
   
Interest
Core
   
Interest
Cycles
   
Interest
Dependency Graph
   
Interest
Development Management
   
Interest
Eevee & Viewport
   
Interest
Freestyle
   
Interest
Geometry Nodes
   
Interest
Grease Pencil
   
Interest
ID Management
   
Interest
Images & Movies
  
Interest/Import
Export
  
Interest
Line Art
   
Interest
Masking
   
Interest
Metal
   
Interest
Modeling
   
Interest
Modifiers
   
Interest
Motion Tracking
   
Interest
Nodes & Physics
   
Interest
OpenGL
   
Interest
Overrides
   
Interest
Performance
   
Interest
Physics
   
Interest
Pipeline, Assets & IO
   
Interest
Platforms, Builds & Tests
   
Interest
Python API
   
Interest
Render & Cycles
   
Interest
Render Pipeline
   
Interest
Sculpt, Paint & Texture
   
Interest
Text Editor
   
Interest
Translations
   
Interest
Triaging
   
Interest
Undo
   
Interest
USD
   
Interest
User Interface
   
Interest
UV Editing
   
Interest
VFX & Video
   
Interest
Video Sequencer
   
Interest
Virtual Reality
   
Interest
Vulkan
  
Interest: Wayland
  
Legacy
Blender 2.8 Project
   
Legacy
Milestone 1: Basic, Local Asset Browser
   
Legacy
OpenGL Error
  
Meta
Good First Issue
   
Meta
Papercut
   
Meta
Retrospective
   
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
  
Module
Animation & Rigging
   
Module
Core
   
Module
Development Management
   
Module
Eevee & Viewport
   
Module
Grease Pencil
   
Module
Modeling
   
Module
Nodes & Physics
   
Module
Pipeline, Assets & IO
   
Module
Platforms, Builds & Tests
   
Module
Python API
   
Module
Render & Cycles
   
Module
Sculpt, Paint & Texture
   
Module
Triaging
   
Module
User Interface
   
Module
VFX & Video
  
Platform
FreeBSD
   
Platform
Linux
   
Platform
macOS
   
Platform
Windows
  
Priority
High
   
Priority
Low
   
Priority
Normal
   
Priority
Unbreak Now!
  
Status
Archived
   
Status
Confirmed
   
Status
Duplicate
   
Status
Needs Info from Developers
   
Status
Needs Information from User
   
Status
Needs Triage
   
Status
Resolved
  
Type
Bug
   
Type
Design
   
Type
Known Issue
   
Type
Patch
   
Type
Report
   
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
Eevee & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest/Import
Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
4.0
Projects
Set Project
Clear projects
No project
Nodes & Physics
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108014
There is no content yet.
Delete Branch "HooglyBoogly/blender:refactor-mesh-corner-normals-lazy"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?