blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Cleanup: import-brush-set-replace-hardcoded-file-extensions #104802

Merged
Campbell Barton merged 6 commits from DanielGrauer/blender-addons:import-brush-set-replace-hardcoded-file-extensions into main 2023-08-22 03:17:51 +02:00
Conversation 3 Commits 6 Files Changed 1 +8 -46
1 changed files with 8 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit df344a5d78 - Show all commits

54
io_import_BrushSet.py
View File

@ -2,81 +2,43 @@
#
# SPDX-License-Identifier: GPL-2.0-or-later
#---------------------------------------------#
# todo
#---------------------------------------------#
'''
- add file selection for single and multiple files
- option to enable/disable fake users
'''
#---------------------------------------------#
import bpy
import os
from bpy.props import *
from bpy.props import StringProperty
# addon description
bl_info = {
"name": "Import BrushSet",
"author": "Daniel Grauer (kromar), CansecoGPC",
"version": (1, 2, 2),
"version": (1, 3, 0),
"blender": (2, 80, 0),
"location": "File > Import > BrushSet",
"description": "Imports all image files from a folder.",
"warning": '', # used for warning icon and text in addons panel
"doc_url": "http://wiki.blender.org/index.php/Extensions:2.5/Py/Scripts/Import-Export/BrushSet",
"tracker_url": "https://developer.blender.org/maniphest/task/edit/form/2/",
"tracker_url": "https://projects.blender.org/blender/blender-addons/src/branch/main/io_import_BrushSet.py",
Campbell Barton commented 2023-08-21 02:23:29 +02:00
Outdated
Review
Copy Link

This is the URL to the file in GIT, this is not the tracker URL.

Please don't make unrelated changes, it complicates and slows down patch review.

This is the URL to the file in GIT, this is not the tracker URL. Please don't make unrelated changes, it complicates and slows down patch review.
Daniel Grauer commented 2023-08-21 08:30:45 +02:00
Outdated
Review
Copy Link

What would then be the link to use?

What would then be the link to use?
Daniel Grauer commented 2023-08-21 19:42:18 +02:00
Outdated
Review
Copy Link

I reverted the tracker url change.

I reverted the tracker url change.
Campbell Barton commented 2023-08-22 03:10:27 +02:00
Outdated
Review
Copy Link

Thanks, we should really go over & correct every tracker_url for add-ons in one pass.
Typically this is to report bugs, so linking to the add-on report field makes most sense, we might be able to include arguments to set the add-on name so any reports include the proper add-on.

It's outside the scope of this patch though.

Thanks, we should really go over & correct every tracker_url for add-ons in one pass. Typically this is to report bugs, so linking to the add-on report field makes most sense, we might be able to include arguments to set the add-on name so any reports include the proper add-on. It's outside the scope of this patch though.
"category": "Import-Export",
}
#---------------------------------------------#
# extension filter (alternative use mimetypes)
# TODO: rewrite so it tries to load image and if it fails we know its not a format blender can load
ext_list = ['.bmp',
'.png',
'.jpg',
'.jp2',
'.rgb',
'.dds',
'.hdr',
'.exr',
'.dpx',
'.cin',
'.tga',
'.tif'];
#---------------------------------------------#
fakeUser = False
def LoadBrushSet(filepath, filename):
for file in os.listdir(filepath):
path = (filepath + file)
# get folder name
(f1, f2) = os.path.split(filepath)
(f3, foldername) = os.path.split(f1)
# filter files by extensions (filter images)
if any(file.lower().endswith(ext) for ext in ext_list):
print("file: ", file)
if any(file.lower().endswith(ext) for ext in bpy.path.extensions_image):
# create new texture
texture = bpy.data.textures.new(file, 'IMAGE')
texture.use_fake_user = fakeUser
print("texture: ", texture)
# now we need to load the image into data
# load the image into data
image = bpy.data.images.load(path)
image.use_fake_user = fakeUser
# image.source = 'FILE' #default is FILE so can remove this
# image.filepath = path
print("image: ", image, " ", path)
print("texturename: ", texture.name)
# and assign the image to the texture
# assign the image to the texture
bpy.data.textures[texture.name].image = image
print("imported: ", file)
print("Brush Set imported!")