blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Cleanup: import-brush-set-replace-hardcoded-file-extensions #104802

Merged
Campbell Barton merged 6 commits from DanielGrauer/blender-addons:import-brush-set-replace-hardcoded-file-extensions into main 2023-08-22 03:17:51 +02:00
Conversation 3 Commits 6 Files Changed 1 +7 -45
Daniel Grauer commented 2023-07-30 21:03:36 +02:00
Member
Copy Link
No description provided.
Daniel Grauer force-pushed import-brush-set-replace-hardcoded-file-extensions from 722261993e to ce37aea4d6 2023-07-30 21:15:42 +02:00 Compare
Campbell Barton commented 2023-07-31 02:43:54 +02:00
Owner
Copy Link

This commit makes other changes than removing hard coded extensions list, without any explanation for why.

I'd prefer to see this split into two PR's.

This commit makes other changes than removing hard coded extensions list, without any explanation for why. I'd prefer to see this split into two PR's.
👍 1
Daniel Grauer changed title from WIP: import-brush-set-replace-hardcoded-file-extensions to Cleanup: import-brush-set-replace-hardcoded-file-extensions 2023-08-01 16:27:27 +02:00
Daniel Grauer commented 2023-08-01 16:28:25 +02:00
Author
Member
Copy Link

This commit makes other changes than removing hard coded extensions list, without any explanation for why.

I'd prefer to see this split into two PR's.

I reverted the additional changes and will open dedicated PR's for them.

> This commit makes other changes than removing hard coded extensions list, without any explanation for why. > > I'd prefer to see this split into two PR's. I reverted the additional changes and will open dedicated PR's for them.
Daniel Grauer added a new dependency 2023-08-01 16:30:19 +02:00
#104812 Fix: ensure loaded path is folder and not file
Daniel Grauer added the
Interest
Import and Export
 label 2023-08-19 18:46:08 +02:00
Daniel Grauer force-pushed import-brush-set-replace-hardcoded-file-extensions from 5bdc8e2167 to 7234bb5786 2023-08-20 15:21:05 +02:00 Compare
Campbell Barton reviewed 2023-08-21 02:23:29 +02:00
io_import_BrushSet.py Outdated
@ -26,3 +17,3 @@
"warning": '', # used for warning icon and text in addons panel
"doc_url": "http://wiki.blender.org/index.php/Extensions:2.5/Py/Scripts/Import-Export/BrushSet",
"tracker_url": "https://developer.blender.org/maniphest/task/edit/form/2/",
"tracker_url": "https://projects.blender.org/blender/blender-addons/src/branch/main/io_import_BrushSet.py",
Campbell Barton commented 2023-08-21 02:23:29 +02:00
Owner
Copy Link

This is the URL to the file in GIT, this is not the tracker URL.

Please don't make unrelated changes, it complicates and slows down patch review.

This is the URL to the file in GIT, this is not the tracker URL. Please don't make unrelated changes, it complicates and slows down patch review.
Daniel Grauer commented 2023-08-21 08:30:45 +02:00
Author
Member
Copy Link

What would then be the link to use?

What would then be the link to use?
Daniel Grauer commented 2023-08-21 19:42:18 +02:00
Author
Member
Copy Link

I reverted the tracker url change.

I reverted the tracker url change.
Campbell Barton commented 2023-08-22 03:10:27 +02:00
Owner
Copy Link

Thanks, we should really go over & correct every tracker_url for add-ons in one pass.
Typically this is to report bugs, so linking to the add-on report field makes most sense, we might be able to include arguments to set the add-on name so any reports include the proper add-on.

It's outside the scope of this patch though.

Thanks, we should really go over & correct every tracker_url for add-ons in one pass. Typically this is to report bugs, so linking to the add-on report field makes most sense, we might be able to include arguments to set the add-on name so any reports include the proper add-on. It's outside the scope of this patch though.
Daniel Grauer added 1 commit 2023-08-21 19:40:52 +02:00
Campbell Barton merged commit 17f85721d9 into main 2023-08-22 03:17:51 +02:00
Campbell Barton deleted branch import-brush-set-replace-hardcoded-file-extensions 2023-08-22 03:17:51 +02:00
Campbell Barton commented 2023-08-22 03:57:10 +02:00
Owner
Copy Link

Committed, noticed various other issues while testing, see:

Committed, noticed various other issues while testing, see: - 6a94b5537c87312687fd73676f9dec8cf14816b0 - da3a7ce1c4e489eca3bf15cef30ee40d27301275 - 4c1d6136156aa24403c5a27800d220f981c3e70d
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#104812 Fix: ensure loaded path is folder and not file
blender/blender-addons
Reference: blender/blender-addons#104802
No description provided.
Delete Branch "DanielGrauer/blender-addons:import-brush-set-replace-hardcoded-file-extensions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?