Fix: ensure loaded path is folder and not file #104812

Closed

Daniel Grauer wants to merge 4 commits from DanielGrauer:fix-error-when-file-is-selected into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Daniel Grauer commented

2023-08-01 16:29:57 +02:00

Member

The input path to load brush sets only works with a folder as path. If a file is selected in the filemanger to load the path the import fails and throws a error. To avoid the import failing, the filename is now stripped from the path to load the folder.

The input path to load brush sets only works with a folder as path. If a file is selected in the filemanger to load the path the import fails and throws a error. To avoid the import failing, the filename is now stripped from the path to load the folder.

Daniel Grauer added a new dependency 2023-08-01 16:30:19 +02:00

#104802 Cleanup: import-brush-set-replace-hardcoded-file-extensions

Daniel Grauer added the

Import and Export

label 2023-08-01 16:31:20 +02:00

Germano Cavalcante commented

2023-08-02 15:17:20 +02:00

Member

This solution seems to be a workaround, is it possible to solve it without this path manipulation?

Note that this code may not be completely problem-free as it depends on the specific file system (e.g. the backslash is used as a path separator on Windows, but on Unix-based systems the separator would be a forward slash "/ ").

Rather than using such a workaround, it might be better to check how the LoadBrushSet function is called and ensure that filepath is always given as a valid directory rather than relying on this path manipulation.

This solution seems to be a workaround, is it possible to solve it without this path manipulation? Note that this code may not be completely problem-free as it depends on the specific file system (e.g. the backslash is used as a path separator on Windows, but on Unix-based systems the separator would be a forward slash "/ "). Rather than using such a workaround, it might be better to check how the `LoadBrushSet` function is called and ensure that `filepath` is always given as a valid directory rather than relying on this path manipulation.

Daniel Grauer commented

2023-08-19 23:30:14 +02:00

Author

Member

This solution seems to be a workaround, is it possible to solve it without this path manipulation?

Note that this code may not be completely problem-free as it depends on the specific file system (e.g. the backslash is used as a path separator on Windows, but on Unix-based systems the separator would be a forward slash "/ ").

Rather than using such a workaround, it might be better to check how the LoadBrushSet function is called and ensure that filepath is always given as a valid directory rather than relying on this path manipulation.

Thanks a lot for the feedback, i changed it in the LoadBrushSet so only directories can be loaded and removed the "workaround". I also added a filter to show only folders and images as this is what is relevant when using this importer.

> This solution seems to be a workaround, is it possible to solve it without this path manipulation? > > Note that this code may not be completely problem-free as it depends on the specific file system (e.g. the backslash is used as a path separator on Windows, but on Unix-based systems the separator would be a forward slash "/ "). > > Rather than using such a workaround, it might be better to check how the `LoadBrushSet` function is called and ensure that `filepath` is always given as a valid directory rather than relying on this path manipulation. Thanks a lot for the feedback, i changed it in the LoadBrushSet so only directories can be loaded and removed the "workaround". I also added a filter to show only folders and images as this is what is relevant when using this importer.

Daniel Grauer force-pushed fix-error-when-file-is-selected from c71ff2b3ee to 1b985c5ed7

2023-08-20 15:20:36 +02:00

Compare

Daniel Grauer closed this pull request

2023-08-22 18:50:21 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Eevee & Viewport

Import and Export

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds, Tests & Devices

Rendering & Cycles

Sculpt, Paint & Texture

Good First Issue

Add-ons (BF-Blender)

Add-ons (Community)

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on

#104802 Cleanup: import-brush-set-replace-hardcoded-file-extensions

blender/blender-addons

Reference: blender/blender-addons#104812

No description provided.