Fix #104714: Missing shape keys in FBX export when original mesh data cannot be used #104890

Thomas Barlow · 2023-09-16T00:27:56+02:00

Thomas Barlow commented

2023-09-16 00:27:56 +02:00

Enabling the Triangulate Faces option of the exporter or exporting mesh
Objects with Object-linked materials would remove the shape keys of the
exported Meshes, even without there being modifiers to apply.

This patch fixes the shape keys being removed, by using Mesh.copy()
instead of BlendDataMeshes.new_from_object() which currently always
removes shape keys and is unlikely to be changed to keep the shape keys
of non-evaluated meshes any time soon.

For the other cases of converting non-mesh Objects to meshes or
converting evaluated Objects to meshes when applying modifiers,
BlendDataMeshes.new_from_object() is still used.

The code has been reorganised to make the separate cases of using
Mesh.copy() and BlendDataMeshes.new_from_object() clearer than if
they were added directly into the existing code.

Aside from the lack of shape keys, it's possible there could be some
other differences between meshes copied with Mesh.copy() and
BlendDataMeshes.new_from_object(), but I have not noticed any.

Enabling the Triangulate Faces option of the exporter or exporting mesh Objects with Object-linked materials would remove the shape keys of the exported Meshes, even without there being modifiers to apply. This patch fixes the shape keys being removed, by using `Mesh.copy()` instead of `BlendDataMeshes.new_from_object()` which currently always removes shape keys and is unlikely to be changed to keep the shape keys of non-evaluated meshes any time soon. For the other cases of converting non-mesh Objects to meshes or converting evaluated Objects to meshes when applying modifiers, `BlendDataMeshes.new_from_object()` is still used. The code has been reorganised to make the separate cases of using `Mesh.copy()` and `BlendDataMeshes.new_from_object()` clearer than if they were added directly into the existing code. Aside from the lack of shape keys, it's possible there could be some other differences between meshes copied with `Mesh.copy()` and `BlendDataMeshes.new_from_object()`, but I have not noticed any.

Thomas Barlow added 5 commits 2023-09-16 00:27:59 +02:00

f70bb98a61 Fix triangulation removing shape keys

733598d5c1 Use Mesh.copy() instead and fix export of non-mesh Objects that are converted to meshes on export

531e7be110 Fix "Apply Modifiers" removing shape keys when original data cannot be used for other reasons

Having "Triangulate Faces" enabled or having meshes with Object-linked materials would still not export shape keys if "Apply Modifiers" was enabled and the mesh did not have any modifiers to apply.

8b02121ae9 Restructure code to make it clearer what needs to be done to an Object's data and in what cases

49e6617861 Tidy up

Thomas Barlow requested review from Bastien Montagne 2023-09-16 00:30:05 +02:00

Bastien Montagne approved these changes 2023-09-18 14:03:02 +02:00

Bastien Montagne left a comment

The general reorganization of the code, and changes described in the comments and commit message, make total sense to me. I will trust you for the code details. ;)

Thomas Barlow added 2 commits 2023-09-19 02:12:04 +02:00

8542770457 Merge branch 'main' into fbx_fix_triangulate_removing_shapes

e6814688e2 Increase FBX IO version

Thomas Barlow merged commit bc801d7b1d into main

2023-09-19 02:26:19 +02:00

Thomas Barlow referenced this issue from a commit

2023-09-19 02:26:19 +02:00

Fix #104714: Missing shape keys in FBX export when original mesh data cannot be used

Thomas Barlow deleted branch fbx_fix_triangulate_removing_shapes

2023-09-19 02:26:21 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #104714: Missing shape keys in FBX export when original mesh data cannot be used #104890