FBX IO: Speed up animation simplification using NumPy #104904

Thomas Barlow · 2023-09-21T05:33:13+02:00

Thomas Barlow commented

2023-09-21 05:33:13 +02:00

This patch re-writes animation curve simplification on export to use
NumPy where possible for performance.

An export of a 1523 frame animation of a 65 bone armature animating 47
of the bones (almost entirely rotation animation) goes from a 2.9s
export to a 2.2s export for me with this patch (using the default
Simplify value of 1.0).

There are no expected changes to the contents of exported files with
this patch.

This patch re-writes animation curve simplification on export to use NumPy where possible for performance. An export of a 1523 frame animation of a 65 bone armature animating 47 of the bones (almost entirely rotation animation) goes from a 2.9s export to a 2.2s export for me with this patch (using the default Simplify value of 1.0). There are no expected changes to the contents of exported files with this patch.

❤️ 1 🚀 1

Thomas Barlow added 12 commits 2023-09-21 05:33:16 +02:00

51ba7d6227 Initial working version

3f9b11c9cb Revert to using `bool(self)` in force_keep check

4232afbc6a Comment updates and rename variables for better consistency

7c7ab21973 Simplify iterables and p_rots in frame_values_gen

892a192b6b Make curves unpacked iteration variable names consistent

b3d4aa8d64 fbx_animations_do comments and non-functional refactoring

5af95962e0 Restore original `simplify` code

This will be slower, but means the patch can be split into two parts.

67b97a59a4 Remove unused real_currframes iteration from frame_values_gen

46062a745f Convert from Blender to FBX time once per fbx_animations_do instead of for every exported curve

d3febb7602 Refactor: Deduplicate animation simplifying and final data creation

e796771454 FBX IO: Speed up animation simplification using NumPy

4d72eeb804 Merge branch 'main' into fbx_anim_export_numpy_simplify

# Conflicts:
#	io_scene_fbx/fbx_utils.py

Thomas Barlow requested review from Bastien Montagne 2023-09-21 05:33:47 +02:00

Thomas Barlow added 1 commit 2023-10-01 17:15:37 +02:00

a6ee17c3d9 Merge branch 'blender-v4.0-release' into fbx_anim_export_numpy_simplify

Thomas Barlow changed title from ~~FBX IO: Speed up animation simplification using NumPy~~ to FBX IO: Speed up animation simplification using NumPy

2023-10-01 17:15:46 +02:00

Mysteryem changed target branch from main to blender-v4.0-release

2023-10-01 17:15:48 +02:00

Bastien Montagne approved these changes 2023-10-04 17:44:30 +02:00

Bastien Montagne left a comment

Numpy code is somewhat harder to follow, but change LGTM, and gives another nice speedup!

Thomas Barlow added 1 commit 2023-10-05 18:55:52 +02:00

0fb53e49f0 Big comments and variable renaming update

Thomas Barlow commented

2023-10-05 19:01:46 +02:00

Numpy code is somewhat harder to follow

I've added a bunch of extra comments and renamed many variables. The main change to renaming is that there is no longer any mixing of "write mask" vs "keyed" (they were the same thing). The variables and comments now only refer to the values being "enabled" or "disabled" for writing.

> Numpy code is somewhat harder to follow I've added a bunch of extra comments and renamed many variables. The main change to renaming is that there is no longer any mixing of "write mask" vs "keyed" (they were the same thing). The variables and comments now only refer to the values being "enabled" or "disabled" for writing.

👍 1

Bastien Montagne approved these changes 2023-10-06 10:58:32 +02:00

Thomas Barlow added 3 commits 2023-10-06 17:42:13 +02:00

f5e36f7729 Missed a variable rename in comments in last commit

ea6897cf0d Merge branch 'blender-v4.0-release' into fbx_anim_export_numpy_simplify

e553a919af Increase FBX IO Version

Thomas Barlow merged commit 461e0c3e1e into blender-v4.0-release

2023-10-06 17:53:02 +02:00

Thomas Barlow deleted branch fbx_anim_export_numpy_simplify

2023-10-06 17:53:03 +02:00

Thomas Barlow referenced this issue from a commit

2023-10-06 17:53:04 +02:00