blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Update Minimal Dark theme for Blender 4.1 #104986

Closed
Jonathan Lampel wants to merge 4 commits from jlampel/blender-addons:jonathanlampel-4-patch-1 into blender-v4.1-release
pull from: jlampel/blender-addons:jonathanlampel-4-patch-1
merge into: blender:blender-v4.1-release

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 7 Commits 4 Files Changed 1 +429 -417
Jonathan Lampel commented 2023-11-02 21:59:11 +01:00
First-time contributor
Copy Link

The new colors are updated for the new regions and theme settings in Blender 4.0. The changes also improve text readability in several areas (now passes WCAG AA rating) and improve consistency across editors.

The new colors are updated for the new regions and theme settings in Blender 4.0. The changes also improve text readability in several areas (now passes WCAG AA rating) and improve consistency across editors.
Jonathan Lampel added 1 commit 2023-11-02 21:59:13 +01:00 
The new colors are updated for the added regions and settings in Blender 4.0, improve text readability in several areas, and improve consistency across editors.
Jonathan Lampel requested review from Pablo Vazquez 2023-11-02 22:04:49 +01:00
Jonathan Lampel commented 2023-11-10 20:02:10 +01:00
Author
First-time contributor
Copy Link

Lots of small tweaks, but the most important difference is just the increased contrast in regular, selected, and highlighted text. I've also kept the 'green for active, blue for selected' paradigm consistent in more places like the modifier stack.

Before and after comparisons:

image
image

image
image

image
image

image
image

image
image

image
image

image
image

Lots of small tweaks, but the most important difference is just the increased contrast in regular, selected, and highlighted text. I've also kept the 'green for active, blue for selected' paradigm consistent in more places like the modifier stack. Before and after comparisons: ![image](/attachments/29ccc946-6d77-4238-9e9d-2932cdc8450f) ![image](/attachments/e1198278-bed1-4200-93aa-40b3ee97ed8b) ![image](/attachments/591b3645-4570-4245-a2c9-058dd1b07e05) ![image](/attachments/9de6b895-2ac5-4b91-bac3-f6ddd6b878f8) ![image](/attachments/1a8538b0-5de2-4657-a9c8-3874f7d54adb) ![image](/attachments/3e8a5cff-bb04-426e-bc31-83fea45d1826) ![image](/attachments/7fb1d1b8-a2a4-4431-9db6-0501d589c9c2) ![image](/attachments/d01b6450-cc56-425d-9123-795c6149976c) ![image](/attachments/c624069b-f30a-479b-ac5a-03f399066a67) ![image](/attachments/c92dc3e9-7f1a-4463-adb6-79937d54491a) ![image](/attachments/b94e80d0-6c74-42d2-b079-eba247976d76) ![image](/attachments/e68307ae-8e2e-4f5e-9518-216530ff0caf) ![image](/attachments/1fb69f1c-c28a-49ad-a3bc-6dc4fcc49df7) ![image](/attachments/79d125d2-f941-45d4-a9c7-264af4327ee4)
image.png
20 KiB
image.png
14 KiB
image.png
14 KiB
image.png
759 KiB
image.png
120 KiB
image.png
1.2 MiB
image.png
104 KiB
image.png
1.2 MiB
image.png
1.2 MiB
image.png
20 KiB
image.png
132 KiB
image.png
22 KiB
image.png
22 KiB
image.png
98 KiB
image.png
785 KiB
image.png
948 KiB
image.png
949 KiB
image.png
14 KiB
image.png image.png image.png image.png
Pablo Vazquez commented 2024-02-05 15:36:14 +01:00
Member
Copy Link

Hi Jonathan! Sorry I missed this for 4.0, but we can still add this to 4.1.

Could you please update the patch to work in the latest main?

Probably a good idea to also save it with the latest 4.1, so whatever new/removed theme settings apply as well.

Hi Jonathan! Sorry I missed this for 4.0, but we can still add this to 4.1. Could you please update the patch to work in the latest main? Probably a good idea to also save it with the latest 4.1, so whatever new/removed theme settings apply as well.
Jonathan Lampel added 1 commit 2024-02-12 23:34:59 +01:00 
This version has been saved in 4.1 and includes changes to the selected component colors to fit the new 4.1 theme options.
Jonathan Lampel added 1 commit 2024-02-13 01:56:49 +01:00 
The passepartout had matched the 3D View background, which worked when there was a gradient, but without that it was too confusing so I lowered the value to match the background of the darker editors.
Jonathan Lampel commented 2024-02-13 02:02:37 +01:00
Author
First-time contributor
Copy Link

Oh no problem! 4.1 has a few new theme options that made it necessary to update this again anyway. I just committed those changes.

This is my first time contributing via git directly, and while I can edit files via the website just fine, I'm still trying to get my local setup working so I can rebase this branch... but I'll get that figured out soon. In any case, the file itself is now made for 4.1.

Oh no problem! 4.1 has a few new theme options that made it necessary to update this again anyway. I just committed those changes. This is my first time contributing via git directly, and while I can edit files via the website just fine, I'm still trying to get my local setup working so I can rebase this branch... but I'll get that figured out soon. In any case, the file itself is now made for 4.1.
Jonathan Lampel changed title from Update Minimal Dark theme for Blender 4.0 to Update Minimal Dark theme for Blender 4.1 2024-02-13 02:02:56 +01:00
Damien Picard commented 2024-02-13 19:18:53 +01:00
Member
Copy Link

@JonathanLampel-4 Hi, sorry if this is obvious but there are a couple of conflicts where the theme has changed in both your branch and the main branch. You need to merge blender-v4.1-release back into your branch, resolve the conflicts (keep the changes in your version) and push again.

If you want the theme to be updated for 4.1 you also need to choose blender-v4.1-release as the target branch, by clicking Edit to the right of the PR title.

EDIT: I misread your last reply, ignore this.

@JonathanLampel-4 Hi, sorry if this is obvious but there are a couple of conflicts where the theme has changed in both your branch and the main branch. You need to merge `blender-v4.1-release` back into your branch, resolve the conflicts (keep the changes in your version) and push again. If you want the theme to be updated for 4.1 you also need to choose `blender-v4.1-release` as the target branch, by clicking Edit to the right of the PR title. EDIT: I misread your last reply, ignore this.
Jonathan Lampel changed target branch from main to blender-v4.1-release 2024-03-19 17:55:53 +01:00
Jonathan Lampel added 1 commit 2024-03-19 18:27:38 +01:00
Jonathan Lampel commented 2024-03-19 18:29:56 +01:00
Author
First-time contributor
Copy Link

Ok, sorry this took forever to figure out. First time using Gitea and I got stuck on authenticating with the site. I think I got it now. If it's too late for 4.1, I'll update it for 4.2. Thank you for the help!

Ok, sorry this took forever to figure out. First time using Gitea and I got stuck on authenticating with the site. I think I got it now. If it's too late for 4.1, I'll update it for 4.2. Thank you for the help!
Pablo Vazquez commented 2024-05-14 19:35:01 +02:00
Member
Copy Link

Hi!

Once you update it or 4.2, pack it as an extension and share it in extensions.blender.org. All themes (except Blender Dark/Light) will be extensions that can be updated online much more easily.

Review (on a techical level) can happen in the Extensions platform.

Hi! Once you update it or 4.2, [pack it](https://docs.blender.org/manual/en/dev/extensions/getting_started.html#command-line) as an extension and share it in [extensions.blender.org](https://extensions.blender.org/). All themes (except Blender Dark/Light) will be extensions that can be updated online much more easily. Review (on a techical level) can happen in the Extensions platform.
Pablo Vazquez refused to review 2024-05-14 19:35:39 +02:00
Jonathan Lampel commented 2024-05-28 20:06:54 +02:00
Author
First-time contributor
Copy Link

Sure thing, I'm now maintaining it on the extensions platform and will close this out then.

Sure thing, I'm now maintaining it on the extensions platform and will close this out then.
Jonathan Lampel closed this pull request 2024-05-28 20:06:54 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104986
No description provided.
Delete Branch "jlampel/blender-addons:jonathanlampel-4-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?