blender/blender-addons
19
43
Fork 96
Code Issues 630 Pull Requests 27 Projects 1 Releases Wiki Activity

FBX IO: Use the new ShapeKey.points with faster foreach_get/set #105133

Merged
Thomas Barlow merged 2 commits from Mysteryem/blender-addons:shape_key_points_fbx into main 2024-01-24 05:06:50 +01:00
Conversation 0 Commits 2 Files Changed 3 +3 -3
Thomas Barlow commented 2024-01-17 14:47:54 +01:00
Member
Copy Link

Added to Blender 4.1.0 in blender/blender@7d77caab9b, ShapeKey.points
gives optimized access to shape key points data (meshes/lattices) when
accessed with #foreach_get and #foreach_set.

FBX 'shape keys' (Shape Geometry) are sparse data, but Blender shape
keys have one coordinate for every vertex in the mesh, which means that
importing a large mesh with many small shape keys can result in writing
a very large amount of Shape Key data compared to what was stored in the
.fbx file.

This patch updates FBX IO to use ShapeKey.points, noticeably speeding up
imports and exports of larger meshes with many shape keys.

Added to Blender 4.1.0 in blender/blender@7d77caab9b, ShapeKey.points gives optimized access to shape key points data (meshes/lattices) when accessed with #foreach_get and #foreach_set. FBX 'shape keys' (Shape Geometry) are sparse data, but Blender shape keys have one coordinate for every vertex in the mesh, which means that importing a large mesh with many small shape keys can result in writing a very large amount of Shape Key data compared to what was stored in the .fbx file. This patch updates FBX IO to use ShapeKey.points, noticeably speeding up imports and exports of larger meshes with many shape keys.
Thomas Barlow added 1 commit 2024-01-17 14:47:57 +01:00 
Added to Blender 4.1.0 in ??????????, ShapeKey.points gives optimized
access to shape key points data (meshes/lattices) when accessed with
#foreach_get and #foreach_set.
Thomas Barlow changed title from WIP: FBX IO: Use the new ShapeKey.points with faster foreach_get/set to FBX IO: Use the new ShapeKey.points with faster foreach_get/set 2024-01-21 18:56:09 +01:00
Thomas Barlow requested review from Bastien Montagne 2024-01-22 03:54:59 +01:00
Bastien Montagne approved these changes 2024-01-22 18:06:10 +01:00
Bastien Montagne left a comment
Owner
Copy Link

LGTM. 👍

LGTM. 👍
Thomas Barlow added 1 commit 2024-01-24 05:05:31 +01:00
Thomas Barlow merged commit a99528adb0 into main 2024-01-24 05:06:50 +01:00
Thomas Barlow deleted branch shape_key_points_fbx 2024-01-24 05:06:51 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Bastien Montagne
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#105133
No description provided.
Delete Branch "Mysteryem/blender-addons:shape_key_points_fbx"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?