blender/blender-addons
19
43
Fork 96
Code Issues 631 Pull Requests 27 Projects 1 Releases Wiki Activity

FBX: Use layout panels instead of PanelTypes #105238

Merged
Jesse Yurkovich merged 3 commits from deadpin/blender-addons:panels-fbx into main 2024-04-04 20:52:53 +02:00
Conversation 2 Commits 3 Files Changed 1 +143 -329
Jesse Yurkovich commented 2024-03-18 04:48:06 +01:00
Member
Copy Link

Convert FBX to use layout panels instead of PanelTypes for import and
export property drawing. This should match the existing layout used by
the file browser.

This allows viewport/outliner drag-n-drop support to work fully [1] and
it enables the soon to be committed use of Collection exporters [2].

[1] After a drag-n-drop, this Import dialog will be presented (note that the
background color of panel headers will be fixed shortly: blender/blender!119803)
fbx-panels-0.png

[2] For Collection Exporters, this UI will be used (will require a small followup PR to fully enable once Collection Exporters are committed):
fbx-panels-1.png

Reference: blender/blender#119488

Convert FBX to use layout panels instead of PanelTypes for import and export property drawing. This should match the existing layout used by the file browser. This allows viewport/outliner drag-n-drop support to work fully [1] and it enables the soon to be committed use of Collection exporters [2]. [1] After a drag-n-drop, this Import dialog will be presented (note that the background color of panel headers will be fixed shortly: blender/blender!119803) ![fbx-panels-0.png](/attachments/fcc1541a-ac50-464a-ad0f-454374063fe3) [2] For Collection Exporters, this UI will be used (will require a small followup PR to fully enable once Collection Exporters are committed): ![fbx-panels-1.png](/attachments/a162239c-f3e8-46e7-a22f-9872435194f9) Reference: blender/blender#119488
fbx-panels-1.png
35 KiB
fbx-panels-0.png
40 KiB
Jesse Yurkovich added 1 commit 2024-03-18 04:48:08 +01:00
Jesse Yurkovich force-pushed panels-fbx from 601857ba82 to f7c61b936a 2024-03-30 23:17:48 +01:00 Compare
Jesse Yurkovich changed title from WIP: FBX: Use layout panels instead of PanelTypes to FBX: Use layout panels instead of PanelTypes 2024-03-30 23:35:21 +01:00
Jesse Yurkovich requested review from Thomas Barlow 2024-04-03 08:56:06 +02:00
Thomas Barlow requested changes 2024-04-04 03:07:48 +02:00
Dismissed
io_scene_fbx/__init__.py
@ -194,3 +195,3 @@
def draw(self, context):
pass
operator = self
Thomas Barlow commented 2024-04-03 14:54:59 +02:00
Member
Copy Link

Now that self is an Operator rather than a Panel, the operator variable can be replaced with using self.

Same case in ExportFBX.draw()

Now that `self` is an `Operator` rather than a `Panel`, the `operator` variable can be replaced with using `self`. Same case in `ExportFBX.draw()`
Mysteryem marked this conversation as resolved
Thomas Barlow commented 2024-04-04 03:09:22 +02:00
Member
Copy Link

Oops, didn't realise the review was still pending and not actually sent.

Oops, didn't realise the review was still pending and not actually sent.
Jesse Yurkovich added 1 commit 2024-04-04 03:40:26 +02:00
Jesse Yurkovich commented 2024-04-04 03:41:25 +02:00
Author
Member
Copy Link

Thanks for the review. I also bumped the addon/blender version now as well.

Thanks for the review. I also bumped the addon/blender version now as well.
Thomas Barlow approved these changes 2024-04-04 03:48:46 +02:00
Jesse Yurkovich merged commit 1a7c9197b7 into main 2024-04-04 20:52:53 +02:00
Jesse Yurkovich deleted branch panels-fbx 2024-04-04 20:52:53 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Thomas Barlow
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#105238
No description provided.
Delete Branch "deadpin/blender-addons:panels-fbx"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?