UI: Add popup layout panels sub brackground color #119803

Guillermo Venegas · 2024-03-22T19:54:19+01:00

Guillermo Venegas commented

2024-03-22 19:54:19 +01:00

Adds a user preference for setting popups layout panels sub background color

Redo region / Redo popup / WM_operator_props_dialog

import bpy
from bpy.props import StringProperty, BoolProperty, EnumProperty


class SimpleOperator(bpy.types.Operator):
    """Tooltip"""
    bl_idname = "object.simple_operator"
    bl_label = "Simple Object Operator"
    bl_options = {'REGISTER', 'UNDO'}
    
    
    mesh: BoolProperty(name="Mesh")
    light: BoolProperty(name="Light")
    panel_open_state: BoolProperty(name="panel_open_state")
    
    @classmethod
    def poll(cls, context):
        return True

    def execute(self, context):
        return {'FINISHED'}

    def draw(self, context):
        layout = self.layout
        for x in range(5):
            header, layout = layout.panel(str(x), default_closed=False)
            text="Sub "*x+"Layout panel"
            header.label(text=text)
            if layout:
                layout.prop(self,"mesh")
                layout.prop(self,"light")
            else:
                return
            
            
    def invoke(self, context ,event):
        wm = context.window_manager
        return wm.invoke_props_dialog(self)



def menu_func(self, context):
    self.layout.operator(SimpleOperator.bl_idname, text=SimpleOperator.bl_label)

def register():
    bpy.utils.register_class(SimpleOperator)
    bpy.types.TOPBAR_MT_file.append(menu_func)

def unregister():
    bpy.utils.unregister_class(SimpleOperator)
    bpy.types.TOPBAR_MT_file.remove(menu_func)
    
register()

Adds a user preference for setting popups layout panels sub background color <hr> `Redo region` / `Redo popup` / `WM_operator_props_dialog` ![Untitled](/attachments/d6d65d27-b597-4a79-88bf-a622e5f89b38) <video src="/attachments/15872702-182e-407b-a71d-2b04d5025abb" title="2024-03-22 12-48-24.mp4" controls></video> ```python import bpy from bpy.props import StringProperty, BoolProperty, EnumProperty class SimpleOperator(bpy.types.Operator): """Tooltip""" bl_idname = "object.simple_operator" bl_label = "Simple Object Operator" bl_options = {'REGISTER', 'UNDO'} mesh: BoolProperty(name="Mesh") light: BoolProperty(name="Light") panel_open_state: BoolProperty(name="panel_open_state") @classmethod def poll(cls, context): return True def execute(self, context): return {'FINISHED'} def draw(self, context): layout = self.layout for x in range(5): header, layout = layout.panel(str(x), default_closed=False) text="Sub "*x+"Layout panel" header.label(text=text) if layout: layout.prop(self,"mesh") layout.prop(self,"light") else: return def invoke(self, context ,event): wm = context.window_manager return wm.invoke_props_dialog(self) def menu_func(self, context): self.layout.operator(SimpleOperator.bl_idname, text=SimpleOperator.bl_label) def register(): bpy.utils.register_class(SimpleOperator) bpy.types.TOPBAR_MT_file.append(menu_func) def unregister(): bpy.utils.unregister_class(SimpleOperator) bpy.types.TOPBAR_MT_file.remove(menu_func) register() ```

Untitled.png

108 KiB

2024-03-22 12-48-24.mp4

1.6 MiB

👍 4

Guillermo Venegas added 1 commit 2024-03-22 19:54:26 +01:00

8a4e617c36 Add layout panel backdrop color

Guillermo Venegas requested review from Pablo Vazquez 2024-03-22 19:57:08 +01:00

Guillermo Venegas requested review from Harley Acheson 2024-03-22 19:57:09 +01:00

Guillermo Venegas added 1 commit 2024-03-22 20:06:32 +01:00

2445a01161 fix versioning

Jesse Yurkovich commented

2024-03-24 02:26:25 +01:00

As far as the default colors go, we should try to align with the current panel colors. That means 2 things if possible:

The popup dialogs that get panel support should be drawn with Blender's "typical" panel header color first. Not the extremely dark black that happens today. This might be a large visual change though.
The "sub background" color, by default, should darken (instead of lighten) as you expand each sub panel.
Darkening by default:

It would be best if this wasn't yet another color to control and instead it should just use the existing "sub background" color... but our theme system is a mess so I'm not sure where best to add this. The existing panel entries are defined 19 separate times for each major region e.g. Outliner->Theme Space->Panel colors then again for File/Asset Browser->Theme Space->Panel colors and so on :(

As far as the default colors go, we should try to align with the current panel colors. That means 2 things if possible: - The popup dialogs that get panel support should be drawn with Blender's "typical" panel header color first. Not the extremely dark black that happens today. This might be a large visual change though. - The "sub background" color, by default, should darken (instead of lighten) as you expand each sub panel. Darkening by default: ![darken-by-default.png](/attachments/b23d2e19-1831-4759-bfc8-be1521b03af8) It would be best if this wasn't yet another color to control and instead it should just use the existing "sub background" color... but our theme system is a mess so I'm not sure where best to add this. The existing panel entries are defined 19 separate times for each major region e.g. `Outliner->Theme Space->Panel colors` then again for `File/Asset Browser->Theme Space->Panel colors` and so on :( ![existing-theme-entries.png](/attachments/68dea403-3429-4782-9003-ec9f623bf730)

existing-theme-entries.png

6.4 KiB

darken-by-default.png

6.1 KiB

Jesse Yurkovich added this to the User Interface project 2024-03-26 20:19:23 +01:00

Jesse Yurkovich referenced this pull request

2024-03-29 01:26:21 +01:00

Complete File Handler support #119488

Jesse Yurkovich referenced this pull request from blender/blender-addons

2024-03-30 23:32:10 +01:00

FBX: Use layout panels instead of PanelTypes #105238

This pull request has changes conflicting with the target branch.