blender/blender-addons
19
43
Fork 96
Code Issues 631 Pull Requests 27 Projects 1 Releases Wiki Activity

FBX: Use layout panels instead of PanelTypes #105238

Merged
Jesse Yurkovich merged 3 commits from deadpin/blender-addons:panels-fbx into main 2024-04-04 20:52:53 +02:00
Conversation 2 Commits 3 Files Changed 1 +12 -14
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ec85682cfe - Show all commits

26
io_scene_fbx/__init__.py
View File

@ -5,8 +5,8 @@
bl_info = { bl_info = {
"name": "FBX format", "name": "FBX format",
"author": "Campbell Barton, Bastien Montagne, Jens Restemeier, @Mysteryem", "author": "Campbell Barton, Bastien Montagne, Jens Restemeier, @Mysteryem",
"version": (5, 12, 2), "version": (5, 12, 3),
"blender": (4, 1, 0), "blender": (4, 2, 0),
"location": "File > Import-Export", "location": "File > Import-Export",
"description": "FBX IO meshes, UVs, vertex colors, materials, textures, cameras, lamps and actions", "description": "FBX IO meshes, UVs, vertex colors, materials, textures, cameras, lamps and actions",
"warning": "", "warning": "",
@ -194,15 +194,14 @@ class ImportFBX(bpy.types.Operator, ImportHelper):
) )
def draw(self, context): def draw(self, context):
operator = self
layout = self.layout layout = self.layout
Mysteryem marked this conversation as resolved
Thomas Barlow commented 2024-04-03 14:54:59 +02:00
Review
Copy Link

Now that self is an Operator rather than a Panel, the operator variable can be replaced with using self.

Same case in ExportFBX.draw()

Now that `self` is an `Operator` rather than a `Panel`, the `operator` variable can be replaced with using `self`. Same case in `ExportFBX.draw()`
layout.use_property_split = True layout.use_property_split = True
layout.use_property_decorate = False # No animation. layout.use_property_decorate = False # No animation.
import_panel_include(layout, operator) import_panel_include(layout, self)
import_panel_transform(layout, operator) import_panel_transform(layout, self)
import_panel_animation(layout, operator) import_panel_animation(layout, self)
import_panel_armature(layout, operator) import_panel_armature(layout, self)
def execute(self, context): def execute(self, context):
keywords = self.as_keywords(ignore=("filter_glob", "directory", "ui_tab", "filepath", "files")) keywords = self.as_keywords(ignore=("filter_glob", "directory", "ui_tab", "filepath", "files"))
@ -554,17 +553,16 @@ class ExportFBX(bpy.types.Operator, ExportHelper):
) )
def draw(self, context): def draw(self, context):
operator = self
layout = self.layout layout = self.layout
layout.use_property_split = True layout.use_property_split = True
layout.use_property_decorate = False # No animation. layout.use_property_decorate = False # No animation.
export_main(layout, operator) export_main(layout, self)
export_panel_include(layout, operator) export_panel_include(layout, self)
export_panel_transform(layout, operator) export_panel_transform(layout, self)
export_panel_geometry(layout, operator) export_panel_geometry(layout, self)
export_panel_armature(layout, operator) export_panel_armature(layout, self)
export_panel_animation(layout, operator) export_panel_animation(layout, self)
@property @property
def check_extension(self): def check_extension(self):