Fix IES lights blocks2assets #92886
No reviewers
Labels
No Label
legacy module
Platforms, Builds, Tests & Devices
legacy project
Blender Asset Tracer
legacy project
Platform: Windows
Priority::Normal
Status::Archived
Status::Confirmed
Status::Needs Triage
Status::Resolved
Type::Design
Type::Report
Type::To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender-asset-tracer#92886
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "oliverpool/blender-asset-tracer:fix_ies_blocks2assets"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
If the IES file is outside the project folder, BAT currently fails with
This is likely because
result.BlockUsage
expects thestorage
block and not theLamp
block.Could you add a unit test for this as well? This will likely need to have some example file in
tests/blendfiles
to accompany it.Sure, how can I run the tests ? (I couldn't find any doc regarding them)
68483c5edd
to54fd4d6aea
Found out that running
poetry run pytest -k test_pack_ies_external --no-cov
was what I wanted.I rebased on top of main and reordered the commits to show that running the test above on
0ad1e0f
fails, while it succeeds on54fd4d6
This PR contains two (identical) IES files. Where did they come from, and what is their license?
I can confirm that this PR fixes the issue, and that the unit test is indeed sufficient.
This question is still open:
This is important info to know, as the file will become part of the Flamenco sources. This PR cannot move forward without knowing the license of the attached file.
The IES file comes from ies library
Previews are under Creative Commons Licence, is it suitable ?
But I noticed the scene is not correctly set, I corrected it (2 lights addressing the IES relative to the project vs outside project),
you will find the new scene in attachment, but if you prefer, I can create a new PR.
That's the license of the preview images, and not the IES file itself. That page also tells us:
I don't know if "not licensed" is enough here; AFAIK depending on local laws it might actually imply "fully restricted under default copyright law" because there is no explicit license that says otherwise. The fact that we can download the files for free, does not mean the freedom to redistribute those files. Also the text seems to imply that the files originate from a third party ("the manufacturer").
For me this is all too vague to be confident we can include the file in the Flamenco sources.
There is no need to create a new PR, but please do update its contents. @oliverpool can just push another commit to the same branch.
Unfortunately, @oliverpool is working on other projects right now, so I will try to complete this PR for him.
But I don't have rights to update his fork, so I opened a new PR : sorry about that,...
I found a GPL IES package here : I hope it solves this.
That's unfortunate, as it makes it hard to collaborate on things like this.
At least link to the new PR? If it is #92888, please take the time to write a description so that it is clear what it is about. This isn't just a quick one-on-one between the two of us, but a historical record of how and why changes were made to Flamenco. Proper descriptions, and tracability of decision making, are quite important.
That's a lot better, thanks.
54fd4d6aea
to176af17445
Hi, I was away for vacations. I will try to help get this PR through.
I reworked my PR:
531e2784a1
176af17445
Running
poetry run pytest -k test_pack_ies_external --no-cov
shows that the added test initially fails and gets fixed by the latest commit.532856a550
to118353ed0b
Thanks for the extra effort!