blender/blender-assets
0
1
Fork 4
Code Pull Requests 1 Activity

Add ops.sculpt.lasso_hide #1

Merged
Pablo Vazquez merged 1 commits from Sean-Kim/blender-assets:icon-update into main 2024-03-06 15:30:21 +01:00
Conversation 5 Commits 1 Files Changed 1 +2 -2
Sean Kim commented 2024-02-29 20:44:14 +01:00
Member
Copy Link

This PR adds a new element into the toolbar.blend file: ops.sculpt.lasso_hide for the new Lasso Hide operator / tool

Before After
icon_before.png icon_after.png

Required for part of blender/blender#80390

Notes

  • I didn't see any particular notes on the developer documentation for which version of blender to use when editing this file, so I used 4.0.2
  • I'm unsure if this needs a corresponding PR in the main repo for the submodule hash change or if that's something that will be handled by whoever commits this.
This PR adds a new element into the toolbar.blend file: `ops.sculpt.lasso_hide` for the new Lasso Hide operator / tool | Before | After | | --- | --- | | ![icon_before.png](/attachments/ce8c071f-bc23-46bb-9e06-3c50523cecc4) | ![icon_after.png](/attachments/f3e3473b-a911-479c-b758-74e268137522) | Required for part of blender/blender#80390 ## Notes * I didn't see any particular notes on the developer documentation for which version of blender to use when editing this file, so I used `4.0.2` * I'm unsure if this needs a corresponding PR in the main repo for the submodule hash change or if that's something that will be handled by whoever commits this.
icon_after.png
240 KiB
icon_before.png
161 KiB
❤️ 1
Sean Kim added 1 commit 2024-02-29 20:44:15 +01:00
Sean Kim requested review from Sergey Sharybin 2024-02-29 20:45:35 +01:00
Pablo Vazquez commented 2024-03-04 17:33:38 +01:00
Member
Copy Link

Looks great to me!

@JulienKaspar do you have any notes or +1?

Looks great to me! @JulienKaspar do you have any notes or +1?
Sean Kim commented 2024-03-04 18:41:55 +01:00
Author
Member
Copy Link

@pablovazquez I'm not sure if Julien is actively looking at any issues since he's on sabbatical; In this case I guess sign-off from the sculpt module on the artist side would come from @DanielBystedt ?

@pablovazquez I'm not sure if Julien is actively looking at any issues since he's on sabbatical; In this case I guess sign-off from the sculpt module on the artist side would come from @DanielBystedt ?
Julien Kaspar commented 2024-03-05 12:02:44 +01:00
Member
Copy Link

@blender-bot package

EDIT: Oh I see this is only the icons file. I'll download it manually then.

@blender-bot package EDIT: Oh I see this is only the icons file. I'll download it manually then.
Julien Kaspar commented 2024-03-05 12:05:43 +01:00
Member
Copy Link

The Icon looks all good to me 👍

I'll try to still available for some feedback and testing. But yes, it's best to include @DanielBystedt as well if you need an artist to look at the changes.

The Icon looks all good to me 👍 --- I'll try to still available for some feedback and testing. But yes, it's best to include @DanielBystedt as well if you need an artist to look at the changes.
👍 1
Pablo Vazquez approved these changes 2024-03-06 11:51:14 +01:00
Pablo Vazquez merged commit 1d44611dd3 into main 2024-03-06 15:30:21 +01:00
Pablo Vazquez deleted branch icon-update 2024-03-06 15:30:21 +01:00
Daniel Bystedt commented 2024-03-09 16:38:28 +01:00
Member
Copy Link

Sorry I was a bit late on the ball on this commit. Life and time gets in the way

Sorry I was a bit late on the ball on this commit. Life and time gets in the way
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
Sergey Sharybin
Pablo Vazquez
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-assets#1
No description provided.
Delete Branch "Sean-Kim/blender-assets:icon-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?