blender
/
blender-assets
0
0
Fork 2
Code Pull Requests 1 Activity

Icons: Add multiple sculpt gesture tools icons #4

Merged
Hans Goudey merged 3 commits from nickberckley/blender-assets:gesture-icons into main 2024-04-16 01:49:49 +02:00
Conversation 6 Commits 3 Files Changed 1 +2 -2
Nika Kutsniashvili commented 2024-04-14 15:31:20 +02:00
Contributor
Copy Link

This PR adds icons in toolbar.blend file for multiple gesture tools for mesh sculpt mode. Tools don't exist yet but were requested in blender/blender#80390

Icons added are:

  • Line Face Set
  • Polyline Face Set
    image
    (last two)
  • Line Trim
  • Polyline Trim
    trim
    (last two)
  • Polyline Mask
    mask
    (last one)

All gesture tool icons together, with new ones highlighted
gesture_tools

This PR adds icons in toolbar.blend file for multiple gesture tools for mesh sculpt mode. Tools don't exist yet but were requested in https://projects.blender.org/blender/blender/issues/80390 Icons added are: - Line Face Set - Polyline Face Set ![image](/attachments/f0702a23-ed97-41eb-bf79-e34d4c7ff4f3) (last two) --- - Line Trim - Polyline Trim ![trim](/attachments/0fb17178-59a1-45f1-805e-ccc4b98032ad) (last two) --- - Polyline Mask ![mask](/attachments/89003505-b661-4cb7-85aa-2393dfdb859b) (last one) --- All gesture tool icons together, with new ones highlighted ![gesture_tools](/attachments/c5d67e57-5200-40f7-9556-8c0fb75a14a7)
trim.png
23 KiB
mask.png
21 KiB
image.png
25 KiB
gesture_tools.png
53 KiB
❤️ 10
Nika Kutsniashvili added 1 commit 2024-04-14 15:31:21 +02:00
Nika Kutsniashvili added 1 commit 2024-04-14 15:40:20 +02:00
Pablo Vazquez commented 2024-04-15 16:29:56 +02:00
Member
Copy Link

Awesome! The new icons look great.

For a separate task, it'd be a good time to update the Box Mask icon to have the slightly rounded corners that Box Trim has, and that dark outline other icons have:
box mask

Thanks for working on this!

Awesome! The new icons look great. For a separate task, it'd be a good time to update the Box Mask icon to have the slightly rounded corners that Box Trim has, and that dark outline other icons have: ![box mask](/attachments/1d62c28c-8c67-4d81-a2df-643d45e9aab8) Thanks for working on this!
image.png
3.9 KiB
👍 1
Pablo Vazquez changed title from Add icons for multiple sculpt gesture tools to Icons: Add multiple sculpt gesture tools icons 2024-04-15 16:31:01 +02:00
Pablo Vazquez approved these changes 2024-04-15 16:40:16 +02:00
Sean Kim requested changes 2024-04-15 22:04:07 +02:00
Dismissed
Sean Kim left a comment
Member
Copy Link

Icons look great! Thanks a bunch for your help with this. I noticed a few things with the file that need changing so that stuff exports correctly:

  • All of the new objects and their children need to be added to the Export collection.
  • There doesn't appear to be a single ops.sculpt.polyline_mask icon - the main circle geometry appears to be part of the same mesh as ops.sculpt.polyline_face_set, but the gesture geometry is in an object named ops.sculpt_polyline_mask.001
Icons look great! Thanks a bunch for your help with this. I noticed a few things with the file that need changing so that stuff exports correctly: * All of the new objects and their children need to be added to the *Export* collection. * There doesn't appear to be a single `ops.sculpt.polyline_mask` icon - the main circle geometry appears to be part of the same mesh as `ops.sculpt.polyline_face_set`, but the gesture geometry is in an object named `ops.sculpt_polyline_mask.001`
👍 2
Pablo Vazquez commented 2024-04-15 22:34:02 +02:00
Member
Copy Link
  • All of the new objects and their children need to be added to the Export collection.
  • There doesn't appear to be a single ops.sculpt.polyline_mask icon - the main circle geometry appears to be part of the same mesh as ops.sculpt.polyline_face_set, but the gesture geometry is in an object named ops.sculpt_polyline_mask.001

Forgot to mention my approval is only design-wise. Thanks Sean for checking on the technical side!

@Sean-Kim perhaps would be a good idea to write down the guidelines/how-to in the docs https://developer.blender.org/docs/features/interface/icons/#toolbarblend

> * All of the new objects and their children need to be added to the *Export* collection. > * There doesn't appear to be a single `ops.sculpt.polyline_mask` icon - the main circle geometry appears to be part of the same mesh as `ops.sculpt.polyline_face_set`, but the gesture geometry is in an object named `ops.sculpt_polyline_mask.001` Forgot to mention my approval is only design-wise. Thanks Sean for checking on the technical side! @Sean-Kim perhaps would be a good idea to write down the guidelines/how-to in the docs https://developer.blender.org/docs/features/interface/icons/#toolbarblend
Nika Kutsniashvili added 1 commit 2024-04-15 23:05:19 +02:00
Nika Kutsniashvili commented 2024-04-15 23:05:59 +02:00
Author
Contributor
Copy Link

@Sean-Kim Think I fixed them. Children objects seem to be inconsistent, sometimes they're in export, sometimes they're not. In this case I added all of them in collection.

@Sean-Kim Think I fixed them. Children objects seem to be inconsistent, sometimes they're in export, sometimes they're not. In this case I added all of them in collection.
Sean Kim approved these changes 2024-04-16 01:36:51 +02:00
Sean Kim commented 2024-04-16 01:40:35 +02:00
Member
Copy Link

Forgot to mention my approval is only design-wise. Thanks Sean for checking on the technical side!

@Sean-Kim perhaps would be a good idea to write down the guidelines/how-to in the docs https://developer.blender.org/docs/features/interface/icons/#toolbarblend

@pablovazquez The requirements are listed in the default workspace in README.txt that pops up when you open the toolbar.blend file, but I'm not sure if I think that's the best place for it. I can look into mirroring the info on the developer docs.

> Forgot to mention my approval is only design-wise. Thanks Sean for checking on the technical side! > > @Sean-Kim perhaps would be a good idea to write down the guidelines/how-to in the docs https://developer.blender.org/docs/features/interface/icons/#toolbarblend @pablovazquez The requirements are listed in the default workspace in `README.txt` that pops up when you open the `toolbar.blend` file, but I'm not sure if I think that's the best place for it. I can look into mirroring the info on the developer docs.
Sean Kim commented 2024-04-16 01:44:27 +02:00
Member
Copy Link

@HooglyBoogly / @DanielBystedt - Just pinging you here for visibility as potentially interested module reviewers.

@HooglyBoogly / @DanielBystedt - Just pinging you here for visibility as potentially interested module reviewers.
Hans Goudey approved these changes 2024-04-16 01:48:55 +02:00
Hans Goudey merged commit 7181d6dccb into main 2024-04-16 01:49:49 +02:00
Nika Kutsniashvili deleted branch gesture-icons 2024-04-16 11:36:45 +02:00
Pablo Vazquez commented 2024-04-16 12:00:43 +02:00
Member
Copy Link

@pablovazquez The requirements are listed in the default workspace in README.txt that pops up when you open the toolbar.blend file, but I'm not sure if I think that's the best place for it. I can look into mirroring the info on the developer docs.

Yes, not sure it's the best place either. Having such info explained in the developer docs is more accessible (searchable, translatable), and easier to update than the .blend file. Perhaps the README.txt could have a short explanation and:
Please read the documentation for further details https://developer.blender.org/docs/features/interface/icons/ or similar.

> @pablovazquez The requirements are listed in the default workspace in `README.txt` that pops up when you open the `toolbar.blend` file, but I'm not sure if I think that's the best place for it. I can look into mirroring the info on the developer docs. Yes, not sure it's the best place either. Having such info explained in the developer docs is more accessible (searchable, translatable), and easier to update than the .blend file. Perhaps the README.txt could have a short explanation and: `Please read the documentation for further details https://developer.blender.org/docs/features/interface/icons/` or similar.
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Sean Kim
Hans Goudey
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-assets#4
No description provided.
Delete Branch "nickberckley/blender-assets:gesture-icons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?