blender/blender-manual
24
24
Fork 104
Code Issues 75 Pull Requests 6 Projects 1 Releases Wiki Activity

EEVEE: Document attribute and property limitations #104696

Closed
Jesse Yurkovich wants to merge 1 commits from deadpin-patch-1 into blender-v4.1-release
pull from: deadpin-patch-1
merge into: blender:blender-v4.1-release

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 1 +7
Jesse Yurkovich commented 2024-02-08 08:19:27 +01:00
Member
Copy Link

Related to blender/blender#108534

Folks keep running into this it seems so I put the PR together to get things moving.

There looks to be 2 limits but one of them seems a bit broken.

/* Hardware limit is 16. Position attribute is always needed so we reduce to 15.
 * This makes sure the GPUVertexFormat name buffer does not overflow. */
#define GPU_MAX_ATTR 15

/* Determined by the maximum uniform buffer size divided by chunk size. */
#define GPU_MAX_UNIFORM_ATTR 8

The first, from an empirical test seems to indicate 14 useful Geometry Node attributes before the shader "breaks". Are we off by one somewhere?

The second, from blender/blender#117967, is correctly handled when Custom Object Properties are set.

Related to https://projects.blender.org/blender/blender/issues/108534 ---- Folks keep running into this it seems so I put the PR together to get things moving. There looks to be 2 limits but one of them seems a bit broken. ``` /* Hardware limit is 16. Position attribute is always needed so we reduce to 15. * This makes sure the GPUVertexFormat name buffer does not overflow. */ #define GPU_MAX_ATTR 15 /* Determined by the maximum uniform buffer size divided by chunk size. */ #define GPU_MAX_UNIFORM_ATTR 8 ``` The first, from an empirical test seems to indicate 14 useful Geometry Node attributes before the shader "breaks". Are we off by one somewhere? The second, from https://projects.blender.org/blender/blender/issues/117967, is correctly handled when Custom Object Properties are set.
Jesse Yurkovich added 1 commit 2024-02-08 08:19:29 +01:00 
Related to blender/blender#108534

----
Folks keep running into this it seems so I put the PR together to get things moving.

There looks to be 2 limits but one of them seems a bit broken.

```
/* Hardware limit is 16. Position attribute is always needed so we reduce to 15.
 * This makes sure the GPUVertexFormat name buffer does not overflow. */
#define GPU_MAX_ATTR 15

/* Determined by the maximum uniform buffer size divided by chunk size. */
#define GPU_MAX_UNIFORM_ATTR 8
```

The first, from an empirical test seems to indicate 14 useful Geometry Node attributes before the shader "breaks".  Are we off by one somewhere?

The second, from blender/blender#117967, seems to be used when Custom Object Properties are set.
Jesse Yurkovich requested review from Philipp Oeser 2024-02-08 08:19:51 +01:00
Jesse Yurkovich requested review from Jeroen Bakker 2024-02-08 08:19:51 +01:00
Jesse Yurkovich commented 2024-02-08 08:36:03 +01:00
Author
Member
Copy Link

Will re-create using a branch from my own fork - oops.

Will re-create using a branch from my own fork - oops.
Jesse Yurkovich closed this pull request 2024-02-08 08:36:03 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Philipp Oeser
Jeroen Bakker
Labels
Clear labels   
Meta
Good First Issue

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Eevee & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds, Tests & Devices

  
Module
Python API

  
Module
Rendering & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
User Interface

  
Module
VFX & Video

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Information from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Meta
Good First Issue
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds, Tests & Devices
Module
Python API
Module
Rendering & Cycles
Module
Sculpt, Paint & Texture
Module
User Interface
Module
VFX & Video
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Information from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-manual#104696
No description provided.
Delete Branch "deadpin-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?