WIP: Add Texture coordinate render tests #11
No reviewers
Labels
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender-test-data#11
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "Alaska/blender-test-data:texture-coordinate"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
WIP: Wanted to go through a review process first before deciding to make all the relevant files.
I feel like the render tests need more tests specifically for the texture coordinate node. So I've started this PR to get that going.
At the moment there is only one file (The
Window
output), and this is for two reasons:Window
output is the most important to get a test made for it. Because it was requested by Clément (on the old Blender chat), it's currently broken in OptiX OSL, and was broken oneAPI in the past, and there is currently only one test for it, and it's "frequently" disable as it's part of a denoising test.General things I wanted to note and get feedback on.
Window
output to see what happens for non-camera rays.From Instancer
option on the Texture Coordinate node.Object
option on the Texture Coordinate node.How important do you think it is to try and include tests for these missing configurations? Should I try and merge them into a single file or create separate test files?
One other question I had was should I just display the output of the Texture Coordinate node directly to the camera, making it easier to see when something's wrong, or do something like what I've done now (connect the output to a texture node)?
I have attached a example image generated with
texture_coordinate_window.blend
@Alaska Generally i think the
texture_coordinate_window.blend
is good. The only thing I am not sure is the mirror ball: it adds noise to the scene, which might make it harder to ensure test passes on all platforms. Is it essential for testing the texture mapping?Having single file for tests simplifies some things, but makes it harder to notice actual regressions (if the "failed" feature is too small, and falls under the failed pixels threshold).
So, perhaps, best would be to have separate files for the configurations you've mentioned (
From Instancer
,Object
) as separate files that are based on the current one you're proposing.The light better be a separate file, as it is quite different from objects.
For the importance: is good to expand our testing, but i wouldn't consider lack of those tests a stopper for a smaller steps forward.
It's not essential to testing texture mapping, but for something like the
Reflection
andWindow
modes, it does test a extra aspect (They produce different/interesting results when viewed through a reflection)I can swap it out for something like a reflective plane, or a subtley curved surface rather than a ball, or just remove it entirely if you want.
Checkout
From your project repository, check out a new branch and test the changes.