Outliner: any action triggers expansion of all ViewLayers #102317

New Issue

Pablo Vazquez · 2022-11-07T01:21:38+01:00

Pablo Vazquez commented

2022-11-07 01:21:38 +01:00

System Information
Operating system: Linux-6.0.5-200.fc36.x86_64-x86_64-with-glibc2.35 64 Bits
Graphics card: Quadro RTX 4000 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 520.56.06

Blender Version
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-03 18:41, hash: 9dfc134c9d
Worked: I don't think it ever worked

Short description of error
As seen on the attached video, when the All View Layers filter is enabled, performing any action (such as clicking on a ViewLayer name) triggers the expansion of all the View Layers.

I think the behavior should follow that of other items, such as Collections, so clicking on the View Layer name only selects it, doesn't expand it.

The video also shows a different bug I noticed (around 0:10), but I made a separate report for that: #102357.

Exact steps for others to reproduce the error

Create multiple View Layers
In the Outliner, enable the filter All View Layers
Collapse all view layers
Select one view layer
#102317.blend
{F13862779, size=full}

**System Information** Operating system: Linux-6.0.5-200.fc36.x86_64-x86_64-with-glibc2.35 64 Bits Graphics card: Quadro RTX 4000 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 520.56.06 **Blender Version** Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-03 18:41, hash: `9dfc134c9d` Worked: I don't think it ever worked **Short description of error** As seen on the attached video, when the `All View Layers` filter is enabled, performing any action (such as clicking on a ViewLayer name) triggers the expansion of all the View Layers. I think the behavior should follow that of other items, such as Collections, so clicking on the View Layer name only selects it, doesn't expand it. The video also shows a different bug I noticed (around 0:10), but I made a separate report for that: #102357. **Exact steps for others to reproduce the error** * Create multiple View Layers * In the Outliner, enable the filter `All View Layers` * Collapse all view layers * Select one view layer [#102317.blend](https://archive.blender.org/developer/F13863214/T102317.blend) {[F13862779](https://archive.blender.org/developer/F13862779/sr-2022-11-07_01.07.31.mp4), size=full}

Pablo Vazquez commented

2022-11-07 01:21:38 +01:00

Added subscriber: @pablovazquez

blender-admin commented

2022-11-07 01:21:38 +01:00

#103340 was marked as duplicate of this issue

Pratik Borhade commented

2022-11-07 04:47:32 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-11-07 04:47:32 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-11-07 04:47:32 +01:00

Another bug I noticed is shown in the video (around 0:10)

@pablovazquez hi, I'm unable to reproduce this. Did you try it with factory settings?

> Another bug I noticed is shown in the video (around 0:10) @pablovazquez hi, I'm unable to reproduce this. Did you try it with factory settings?

Pablo Vazquez commented

2022-11-08 15:42:50 +01:00

In #102317#1441619, @PratikPB2123 wrote:

Another bug I noticed is shown in the video (around 0:10)

@pablovazquez hi, I'm unable to reproduce this. Did you try it with factory settings?

Yes, it also happens in factory settings. I made a new report, since it's a separate issue than this one: #102357

> In #102317#1441619, @PratikPB2123 wrote: >> Another bug I noticed is shown in the video (around 0:10) > @pablovazquez hi, I'm unable to reproduce this. Did you try it with factory settings? Yes, it also happens in factory settings. I made a new report, since it's a separate issue than this one: #102357

Pratik Borhade commented

2022-11-09 08:32:37 +01:00

@pablovazquez hi, yes, can redo the other bug sometimes.
Regarding this report: its not necessary to select view layer. Any operation that will call outliner update will expand view layer
For example, invoke box select in outliner, delete/hide cube in attached file, change outliner filter, etc.

@pablovazquez hi, yes, can redo the other bug sometimes. Regarding this report: its not necessary to select view layer. Any operation that will call `outliner update` will expand view layer For example, invoke box select in outliner, delete/hide cube in attached file, change outliner filter, etc.

Pablo Vazquez commented

2022-11-10 14:47:20 +01:00

@PratikPB2123 good catch! Indeed any action in the outliner triggers the expansion of all ViewLayers. I'll adjust the task title.

Pablo Vazquez changed title from ~~Outliner: Clicking on a ViewLayer expands all of them~~ to Outliner: any action triggers expansion of all ViewLayers

2022-11-10 14:49:16 +01:00

Dalai Felinto was assigned by Pablo Vazquez

2022-11-10 17:15:55 +01:00

Pablo Vazquez commented

2022-11-10 17:15:55 +01:00

Talked with Dalai and he will look into it since he worked in this area before.

Pratik Borhade commented

2022-11-28 13:07:20 +01:00

I'll give a try to fix this.
AFAICS we're expanding viewlayers without any condition.
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc$83

    &space_outliner_, &tree, scene, nullptr, TSE_R_LAYER, 0);
TREESTORE(&te_view_layer)->flag &= ~TSE_CLOSED;
te_view_layer.name = view_layer->name;
te_view_layer.directdata = view_layer;

Approach could be wrong.

I'll give a try to fix this. AFAICS we're expanding viewlayers without any condition. https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc$83 ``` TreeElement &te_view_layer = *outliner_add_element( ``` &space_outliner_, &tree, scene, nullptr, TSE_R_LAYER, 0); TREESTORE(&te_view_layer)->flag &= ~TSE_CLOSED; te_view_layer.name = view_layer->name; te_view_layer.directdata = view_layer; ``` ``` - - - Approach could be wrong.

Pratik Borhade commented

2022-11-28 13:43:24 +01:00

Something like this should do it. Will check again. @dfelinto , can I claim the task or you've a fix already?

diff --git a/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc b/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc
index 66c1fa34914..824371ea11d 100644
--- a/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc
+++ b/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc
@@ -80,7 +80,9 @@ ListBase TreeDisplayViewLayer::buildTree(const TreeSourceData &source_data)
     else {
       TreeElement &te_view_layer = *outliner_add_element(
           &space_outliner_, &tree, scene, nullptr, TSE_R_LAYER, 0);
-      TREESTORE(&te_view_layer)->flag &= ~TSE_CLOSED;
+      if (!TREESTORE(&te_view_layer)->used) {
+        TREESTORE(&te_view_layer)->flag &= ~TSE_CLOSED;
+      }
       te_view_layer.name = view_layer->name;
       te_view_layer.directdata = view_layer;

@@ -113,8 +115,10 @@ void TreeDisplayViewLayer::add_view_layer(Scene &scene, ListBase &tree, TreeElem
     TreeElement &ten = *outliner_add_element(
         &space_outliner_, &tree, &scene, parent, TSE_VIEW_COLLECTION_BASE, 0);
     ten.name = IFACE_("Scene Collection");
-    TREESTORE(&ten)->flag &= ~TSE_CLOSED;
-
+    if (!TREESTORE(&ten)->used) {
+      TREESTORE(&ten)->flag &= ~TSE_CLOSED;
+    }
+
     /* First layer collection is for master collection, don't show it. */
     LayerCollection *lc = static_cast<LayerCollection *>(view_layer_->layer_collections.first);
     if (lc == nullptr) {
(END)```

Something like this should do it. Will check again. @dfelinto , can I claim the task or you've a fix already? ```lines=10 diff --git a/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc b/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc index 66c1fa34914..824371ea11d 100644 --- a/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc +++ b/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc @@ -80,7 +80,9 @@ ListBase TreeDisplayViewLayer::buildTree(const TreeSourceData &source_data) else { TreeElement &te_view_layer = *outliner_add_element( &space_outliner_, &tree, scene, nullptr, TSE_R_LAYER, 0); - TREESTORE(&te_view_layer)->flag &= ~TSE_CLOSED; + if (!TREESTORE(&te_view_layer)->used) { + TREESTORE(&te_view_layer)->flag &= ~TSE_CLOSED; + } te_view_layer.name = view_layer->name; te_view_layer.directdata = view_layer; @@ -113,8 +115,10 @@ void TreeDisplayViewLayer::add_view_layer(Scene &scene, ListBase &tree, TreeElem TreeElement &ten = *outliner_add_element( &space_outliner_, &tree, &scene, parent, TSE_VIEW_COLLECTION_BASE, 0); ten.name = IFACE_("Scene Collection"); - TREESTORE(&ten)->flag &= ~TSE_CLOSED; - + if (!TREESTORE(&ten)->used) { + TREESTORE(&ten)->flag &= ~TSE_CLOSED; + } + /* First layer collection is for master collection, don't show it. */ LayerCollection *lc = static_cast<LayerCollection *>(view_layer_->layer_collections.first); if (lc == nullptr) { (END)```

Dalai Felinto commented

2022-11-28 13:53:09 +01:00

@PratikPB2123 please go ahead

Dalai Felinto removed their assignment 2022-11-28 13:54:32 +01:00

Pratik Borhade was assigned by Dalai Felinto

2022-11-28 13:54:32 +01:00

Dalai Felinto commented

2022-11-28 13:54:32 +01:00

Added subscriber: @dfelinto

Pratik Borhade commented

2022-12-21 05:31:08 +01:00

Added subscriber: @SteffenD

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Outliner: any action triggers expansion of all ViewLayers #102317