NLA is editable even when the animation data is linked #105260

New Issue

Sybren A. Stüvel · 2023-02-27T18:10:25+01:00

Sybren A. Stüvel commented

2023-02-27 18:10:25 +01:00

Blender Version
Broken: 2.80 to current main branch (96abaae9ac57e3833f862bc0b562d2fe7a95f702)
Worked: probably never

Short description of error
The NLA is editable, even when the animation data is linked and thus should be read-only.

Exact steps for others to reproduce the error

Extract the attached ZIP
Open nla-link-test.blend
Move the strip in the NLA
Save and reload the file
See that the strip edit has not been saved to disk.

Observed behaviour: the NLA strip can be moved.

Expected behaviour: the NLA data of the linked object should be read-only. Just like the cube itself (you cannot move it).

**Blender Version** Broken: 2.80 to current main branch (`96abaae9ac57e3833f862bc0b562d2fe7a95f702`) Worked: probably never **Short description of error** The NLA is editable, even when the animation data is linked and thus should be read-only. **Exact steps for others to reproduce the error** - Extract the attached ZIP - Open `nla-link-test.blend` - Move the strip in the NLA - Save and reload the file - See that the strip edit has not been saved to disk. Observed behaviour: the NLA strip can be moved. Expected behaviour: the NLA data of the linked object should be read-only. Just like the cube itself (you cannot move it).

nla-link-test.zip

211 KiB

Sybren A. Stüvel added the

labels 2023-02-27 18:10:50 +01:00

Nate Rupsis commented

2023-02-27 18:13:02 +01:00

Subscribing.

Jay-Mckee commented

2023-03-01 03:49:27 +01:00

looks like the way to disable editing for linked NLA is in nla_select.c and nla_edit.c
wherever you see:

/* get editor data */
if (ANIM_animdata_get_context(C, &ac) == 0) {
return OPERATOR_CANCELLED;
}

replace it with:

/* get editor data and make sure active object is not linked */
Object *ob = CTX_data_active_object(C);
if ((ANIM_animdata_get_context(C, &ac) == 0) || (ob && ob->id.lib)) {
return OPERATOR_CANCELLED;
}

This cancels all attempts at editing when the active object is a linked one.

I tested it and can't edit anything in the NLA editor for the linked cube, but I'm brand new to the blender code base, don't want to presume anything.

*looks like* the way to disable editing for linked NLA is in nla_select.c and nla_edit.c wherever you see: /* get editor data */ if (ANIM_animdata_get_context(C, &ac) == 0) { return OPERATOR_CANCELLED; } replace it with: /* get editor data and make sure active object is not linked */ Object *ob = CTX_data_active_object(C); if ((ANIM_animdata_get_context(C, &ac) == 0) || (ob && ob->id.lib)) { return OPERATOR_CANCELLED; } This cancels all attempts at editing when the active object is a linked one. I tested it and can't edit anything in the NLA editor for the linked cube, but I'm brand new to the blender code base, don't want to presume anything.

Sybren A. Stüvel referenced this issue

2023-03-02 10:45:47 +01:00

Fix/Refactor NLA Track library override #105272

Sybren A. Stüvel commented

2023-03-02 10:54:11 +01:00

Thanks @Jay-Mckee for helping out :)

Unfortunately this is not enough. The animation data may be owned by other objects (when the "Selected Only" filter is turned off), so the check will have to be done somewhere else.

As for the check itself, that shouldn't access ob->id.lib directly, but rather use ID_IS_LINKED(ob->id). There are a bunch of macros in DNA_ID.h that can help with these kind of tests.

Thanks @Jay-Mckee for helping out :) Unfortunately this is not enough. The animation data may be owned by other objects (when the "Selected Only" filter is turned off), so the check will have to be done somewhere else. As for the check itself, that shouldn't access `ob->id.lib` directly, but rather use `ID_IS_LINKED(ob->id)`. There are a bunch of macros in `DNA_ID.h` that can help with these kind of tests.

Denys Hsu commented

2023-04-28 16:14:01 +02:00

Probably related: The NLA track edibility can be toggled by pressing tab.

channel_lock_editable.mov

79 KiB

Brad Clark commented

2023-04-28 17:06:15 +02:00

Testing this in 3.5.1

the last step in this "See that the strip edit has not been saved to disk." is working for me, meaning I can open and edit the animation strip data and save it and it opens correctly.

@cgtinker you are correct the UI click for unlock and mute for an object that is linked in and not overridden is not possible.

Hitting TAB does seem to get around the flag that says it you can't edit a linked datablock.
So in this case the main "fix" is that the TAB shortcut key for some reason is able to lock/unlock the track while it says it shouldn't be able to

Testing this in 3.5.1 the last step in this "See that the strip edit has not been saved to disk." is working for me, meaning I can open and edit the animation strip data and save it and it opens correctly. @cgtinker you are correct the UI click for unlock and mute for an object that is linked in and not overridden is not possible. Hitting TAB does seem to get around the flag that says it you can't edit a linked datablock. So in this case the main "fix" is that the TAB shortcut key for some reason is able to lock/unlock the track while it says it shouldn't be able to ![image](/attachments/2be6200e-4045-4453-a711-ceabe6bb826e)

image.png

13 KiB

Denys Hsu commented

2023-04-28 19:25:24 +02:00

Seem like all nla edit methods filter before starting to work on nla strips – how about adding a new filter flag? B.e. ANIMFILTER_DATA_NOT_LINKED and filter using the strips id prop ID_IS_LINKED(strip->act).

This would just add a flag in various places in the end.

Seem like all nla edit methods filter before starting to work on nla strips – how about adding a new filter flag? B.e. `ANIMFILTER_DATA_NOT_LINKED` and filter using the strips id prop `ID_IS_LINKED(strip->act)`. This would just add a flag in various places in the end.

Sybren A. Stüvel commented

2023-05-01 17:20:42 +02:00

Seem like all nla edit methods filter before starting to work on nla strips – how about adding a new filter flag? B.e. ANIMFILTER_DATA_NOT_LINKED and filter using the strips id prop ID_IS_LINKED(strip->act).

I think ANIMFILTER_DATA_LOCAL would be a better name (I prefer avoiding negations). Then again, maybe adding the ID_IS_LINKED(strip->act) to the ANIMFILTER_FOREDIT filtering could be enough?

> Seem like all nla edit methods filter before starting to work on nla strips – how about adding a new filter flag? B.e. `ANIMFILTER_DATA_NOT_LINKED` and filter using the strips id prop `ID_IS_LINKED(strip->act)`. I think `ANIMFILTER_DATA_LOCAL` would be a better name (I prefer avoiding negations). Then again, maybe adding the `ID_IS_LINKED(strip->act)` to the `ANIMFILTER_FOREDIT` filtering could be enough?

~~Denys Hsu referenced this issue 2023-05-08 21:29:12 +02:00~~

WIP: Fix #105260: Skip nla tracks with library linked strips #107758

Iliya Katushenock referenced a pull request that will close this issue

2023-05-15 17:07:51 +02:00

WIP: Fix #105260: Skip nla tracks with library linked strips #107758

Pratik Borhade commented

2023-07-06 13:17:52 +02:00

@dr.sybren , this looks like a part of #98712

Sign in to join this conversation.