Lots of animation-related operators do not check if the data is editable or not #98712

New Issue

Bastien Montagne · 2022-06-09T09:14:53+02:00

Bastien Montagne commented

2022-06-09 09:14:53 +02:00

Many animation-related operators do not do any check whether the data-block they operate on is linked, liboverride or fully local data. This seems to affect in particular operations from the 3DView (like key insertions), and in the NLA (like adding new tracks, duplicating strips, etc.).

E.g. one can insert keyframes on a linked object (ie create animdata for that linked object, a new local action, and assign that local action to the linked object!).

Related to issue reported in #98686 (Cant rename local NLA tracks within a local library override data-block.).

Many animation-related operators do not do any check whether the data-block they operate on is linked, liboverride or fully local data. This seems to affect in particular operations from the 3DView (like key insertions), and in the NLA (like adding new tracks, duplicating strips, etc.). E.g. one can insert keyframes on a linked object (ie create animdata for that linked object, a new local action, and assign that local action to the linked object!). Related to issue reported in #98686 (Cant rename local NLA tracks within a local library override data-block.).

Bastien Montagne commented

2022-06-09 09:14:53 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Bastien Montagne commented

2022-06-09 09:14:53 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2022-06-09 09:16:27 +02:00

NOTE: Setting to Bug type for now since this is a fairly serious issue (people can easily lose a lot of work with that kind of loophole), but could also be considered a TODO, since an full careful check of all possible operation will take a lot of time...

NOTE: Setting to `Bug` type for now since this is a fairly serious issue (people can easily lose a lot of work with that kind of loophole), but could also be considered a TODO, since an full careful check of all possible operation will take a lot of time...

Sybren A. Stüvel commented

2022-06-14 16:47:59 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2022-06-14 16:47:59 +02:00

@mont29 what would you suggest as the proper solution? I don't think copying the changes from a91c8d8efa into many other places would be a particularly attractive design. Is there a function that combines (id != NULL && (ID_IS_LINKED(id) || ID_IS_OVERRIDE_LIBRARY(id)))? I'm guessing that for much of the code it's only relevant whether a datablock can be edited, and not so much why (not).

@mont29 what would you suggest as the proper solution? I don't think copying the changes from a91c8d8efa into many other places would be a particularly attractive design. Is there a function that combines `(id != NULL && (ID_IS_LINKED(id) || ID_IS_OVERRIDE_LIBRARY(id)))`? I'm guessing that for much of the code it's only relevant whether a datablock can be edited, and not so much why (not).

Bastien Montagne commented

2022-07-06 16:24:53 +02:00

@dr.sybren that NLA change is more complex for several reasons, mainly thanks to the fact that NLA supports inserting strips/tracks into an override data... a bit similar to the modifiers/constraints case.

We have e.g BKE_id_is_editable, which should be enough in almost all cases here. It just does not check that the id is non-null, ;)

@dr.sybren that NLA change is more complex for several reasons, mainly thanks to the fact that NLA supports inserting strips/tracks into an override data... a bit similar to the modifiers/constraints case. We have e.g `BKE_id_is_editable`, which should be enough in almost all cases here. It just does not check that the id is non-null, ;)

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Lots of animation-related operators do not check if the data is editable or not #98712