WIP: Fix #105260: Skip nla tracks with library linked strips #107758

Denys Hsu · 2023-05-08T21:29:11+02:00

Denys Hsu commented

2023-05-08 21:29:11 +02:00

NLA tracks should not be editable when they contain library linked strips. When filtering for ANIMFILTER_FOREDIT now the strips get checked - if any of them is linked from a library, the track gets filtered out.

Visually it probably would be nice to add a "NLATRACK_PROTETED" flag, however currently it seems, that this would require to always filter (even if no editable flag has been requested). If there is filtering step preformed once on startup, it may be nice to add a flag to NLA tracks which indicates that the track contains library linked strips - these could just get skipped always (but that's prolly out of scope).

ED: Checking just the first strips should be enough. However, This patch doesn't cover all cases. B.e. strip can be pushed down and then be pulled in a nla track containing a linked strip. Also the "lock" can be en- and disabled using "tab". There are most likely more edge cases, but those I came across so far.

NLA tracks should not be editable when they contain library linked strips. When filtering for ANIMFILTER_FOREDIT now the strips get checked - if any of them is linked from a library, the track gets filtered out. Visually it probably would be nice to add a "NLATRACK_PROTETED" flag, however currently it seems, that this would require to always filter (even if no editable flag has been requested). If there is filtering step preformed once on startup, it may be nice to add a flag to NLA tracks which indicates that the track contains library linked strips - these could just get skipped always (but that's prolly out of scope). ED: Checking just the first strips should be enough. However, This patch doesn't cover all cases. B.e. strip can be pushed down and then be pulled in a nla track containing a linked strip. Also the "lock" can be en- and disabled using "tab". There are most likely more edge cases, but those I came across so far.

Denys Hsu added 1 commit 2023-05-08 21:29:21 +02:00

1bd0378df5 skip library linked strips

Denys Hsu added 1 commit 2023-05-15 14:45:17 +02:00

4eb65435d5 check first only first strip

Iliya Katushenock changed title from ~~WIP #105260 skip nla tracks with library linked strips~~ to WIP :Fix #105260: Skip nla tracks with library linked strips

2023-05-15 17:07:33 +02:00

Iliya Katushenock changed title from ~~WIP :Fix #105260: Skip nla tracks with library linked strips~~ to WIP: Fix #105260: Skip nla tracks with library linked strips

2023-05-15 17:07:51 +02:00

Denys Hsu requested review from Sybren A. Stüvel 2023-06-15 23:11:46 +02:00

Sybren A. Stüvel added the

Module

Animation & Rigging

label 2023-07-13 16:02:14 +02:00

Sybren A. Stüvel commented

2023-07-17 11:36:20 +02:00

NLA tracks should not be editable when they contain library linked tracks.

I think that should be "... contain linked strips"?

Checking just the first track should be enough.

Maybe this should also be strips? And why would it be enough to only look at the first strip?

This patch doesn't cover all cases. B.e. tracks can be pushed down and then be pulled in the linked nla track.

Not sure what "be pulled in the linked nla track" means. Tracks themselves cannot be linked; they are on a linked data-block, or they are local. In the latter case, they can be on a library override, or on a true local data-block.

> NLA tracks should not be editable when they contain library linked tracks. I think that should be "... contain linked **strips**"? > Checking just the first track should be enough. Maybe this should also be **strips**? And why would it be enough to only look at the first strip? > This patch doesn't cover all cases. B.e. tracks can be pushed down and then be pulled in the linked nla track. Not sure what "be pulled in the linked nla track" means. Tracks themselves cannot be linked; they are on a linked data-block, or they are local. In the latter case, they can be on a library override, or on a true local data-block.

Denys Hsu commented

2023-07-19 10:09:56 +02:00

NLA tracks should not be editable when they contain library linked tracks.

I think that should be "... contain linked strips"?

yes, it should be, fixing that

Checking just the first track should be enough.

Maybe this should also be strips? And why would it be enough to only look at the first strip?

When we push down a lib linked strip to the nla and the nla track with a linked strip should not editable, we should not be able to add more strips to it. Therefore a nla track with a lib linked strip should always have a length of 1.

This patch doesn't cover all cases. B.e. tracks can be pushed down and then be pulled in the linked nla track.

Not sure what "be pulled in the linked nla track" means. Tracks themselves cannot be linked; they are on a linked data-block, or they are local. In the latter case, they can be on a library override, or on a true local data-block.

A non linked animation strip currently can be pulled (per drag and drop in the nla editor) in a nla track with a linked strip. This should not be allowed imo.

> > NLA tracks should not be editable when they contain library linked tracks. > > I think that should be "... contain linked **strips**"? yes, it should be, fixing that > > Checking just the first track should be enough. > > Maybe this should also be **strips**? And why would it be enough to only look at the first strip? When we push down a lib linked strip to the nla and the nla track with a linked strip **should** not editable, we should not be able to add more strips to it. Therefore a nla track with a lib linked strip **should** always have a length of 1. > > This patch doesn't cover all cases. B.e. tracks can be pushed down and then be pulled in the linked nla track. > > Not sure what "be pulled in the linked nla track" means. Tracks themselves cannot be linked; they are on a linked data-block, or they are local. In the latter case, they can be on a library override, or on a true local data-block. A non linked animation strip currently can be pulled (per drag and drop in the nla editor) in a nla track with a linked strip. This **should** not be allowed imo.

This pull request has changes conflicting with the target branch.

source/blender/editors/animation/anim_filter.c

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u nla_linked_lib:cgtinker-nla_linked_lib

git checkout cgtinker-nla_linked_lib

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Fix #105260: Skip nla tracks with library linked strips #107758

Checkout