UI: fix and improve a few messages #111145

Merged
Hans Goudey merged 2 commits from pioverfour/blender:dp_fix_messages into main 2023-08-29 14:49:10 +02:00
Member
  • Multiple issues in the Data Transfer modifier error messages:
    • "None" -> "none", this word in the middle of a sentence, no need
      for upper case.
    • "amount of " -> "number", more appropriate for discrete
      counts.
    • "doesn't" -> "does not", to respect Blender's style guide.
  • "The grease pencil object need an Armature modifier" -> "needs",
    grammar.
  • "Armature modifier is not valid or wrong defined" -> "is invalid".
    Unclear what "wrong defined" means.
  • The "Recent Reports" text block has not been used since 2.81.
  • "Not valid subdivisions found to rebuild lower levels" -> "No
    valid...", typo.
  • "extensions repository" -> "extension repository": typo.
  • "... , but loose correct blending..." -> "lose": typo.
  • "True when multiple enums ": trailing whitespace.
  • "Number of ray per pixel" -> "rays": typo.
  • "Curve Parameter node" -> "Spline ...": this is the actual name of
    the node after its rename in 1cd9fcd98d.
- Multiple issues in the Data Transfer modifier error messages: - "None" -> "none", this word in the middle of a sentence, no need for upper case. - "amount of <element>" -> "number", more appropriate for discrete counts. - "doesn't" -> "does not", to respect Blender's style guide. - "The grease pencil object need an Armature modifier" -> "needs", grammar. - "Armature modifier is not valid or wrong defined" -> "is invalid". Unclear what "wrong defined" means. - The "Recent Reports" text block has not been used since 2.81. - "Not valid subdivisions found to rebuild lower levels" -> "No valid...", typo. - "extensions repository" -> "extension repository": typo. - "... , but loose correct blending..." -> "lose": typo. - "True when multiple enums ": trailing whitespace. - "Number of ray per pixel" -> "rays": typo. - "Curve Parameter node" -> "Spline ...": this is the actual name of the node after its rename in 1cd9fcd98d.
Damien Picard added the
Module
User Interface
label 2023-08-15 18:38:57 +02:00
Damien Picard force-pushed dp_fix_messages from b267c81d28 to 0cd9cbb9cd 2023-08-15 18:43:09 +02:00 Compare
Damien Picard reviewed 2023-08-15 18:45:43 +02:00
Damien Picard left a comment
Author
Member

Trying to start this review from scratch.

~~Trying to start this review from scratch.~~
Damien Picard reviewed 2023-08-15 18:52:06 +02:00
@ -1448,3 +1448,3 @@
BKE_report(reports,
RPT_ERROR,
"Source and destination meshes do not have the same amount of vertices, "
"Source and destination meshes do not have the same number of vertices, "
Author
Member
  • "amount of " -> "number", more appropriate for discrete counts.
- "amount of <element>" -> "number", more appropriate for discrete counts.
@ -1457,2 +1457,2 @@
"Source mesh doesn't have any edges, "
"None of the 'Edge' mappings can be used in this case");
"Source mesh does not have any edges, "
"none of the 'Edge' mappings can be used in this case");
Author
Member
  • "doesn't" -> "does not", to respect Blender's style guide
  • "None" -> "none", this word in the middle of a sentence, no need for upper case
- "doesn't" -> "does not", to respect Blender's style guide - "None" -> "none", this word in the middle of a sentence, no need for upper case
@ -592,3 +592,3 @@
eGpencilModifierType_Armature);
if (md == nullptr) {
BKE_report(op->reports, RPT_ERROR, "The grease pencil object need an Armature modifier");
BKE_report(op->reports, RPT_ERROR, "The grease pencil object needs an Armature modifier");
Author
Member

Typo

Typo
@ -598,3 +598,3 @@
ArmatureGpencilModifierData *mmd = (ArmatureGpencilModifierData *)md;
if (mmd->object == nullptr) {
BKE_report(op->reports, RPT_ERROR, "Armature modifier is not valid or wrong defined");
BKE_report(op->reports, RPT_ERROR, "The Armature modifier is invalid");
Author
Member

Rephrase, unclear what "wrong defined" means

Rephrase, unclear what "wrong defined" means
@ -6470,3 +6470,3 @@
UI_UNIT_X,
UI_UNIT_Y,
TIP_("Click to see the remaining reports in text block: 'Recent Reports'"));
TIP_("Click to open the Info editor"));
Author
Member

The "Recent Reports" text block has not been used since 2.81.

The "Recent Reports" text block has not been used since 2.81.
Member

"Info" doesn't need to be capitalized.

"Info" doesn't need to be capitalized.
@ -2656,3 +2656,3 @@
int new_levels = multiresModifier_rebuild_subdiv(depsgraph, object, mmd, INT_MAX, false);
if (new_levels == 0) {
BKE_report(op->reports, RPT_ERROR, "Not valid subdivisions found to rebuild lower levels");
BKE_report(op->reports, RPT_ERROR, "No valid subdivisions found to rebuild lower levels");
Author
Member

Typo

Typo
@ -283,3 +283,3 @@
ot->name = "Add Extension Repository";
ot->idname = "PREFERENCES_OT_extension_repo_add";
ot->description = "Add a directory to be used as a local extensions repository";
ot->description = "Add a directory to be used as a local extension repository";
Author
Member

Typo

Typo
@ -344,3 +344,3 @@
ot->name = "Remove Extension Repository";
ot->idname = "PREFERENCES_OT_extension_repo_remove";
ot->description = "Remove an extensions repository";
ot->description = "Remove an extension repository";
Author
Member

Typo

Typo
@ -248,3 +248,3 @@
"Capture World",
"Bake incoming light from the world, instead of just the visibility, "
"for more accurate lighting, but loose correct blending to surrounding irradiance volumes");
"for more accurate lighting, but lose correct blending to surrounding irradiance volumes");
Author
Member

Typo

Typo
@ -3162,3 +3162,3 @@
RNA_def_property_clear_flag(prop, PROP_EDITABLE);
RNA_def_property_boolean_funcs(prop, "rna_Property_is_enum_flag_get", nullptr);
RNA_def_property_ui_text(prop, "Enum Flag", "True when multiple enums ");
RNA_def_property_ui_text(prop, "Enum Flag", "True when multiple enums");
Author
Member

Trailing whitespace

Trailing whitespace
@ -7400,3 +7400,3 @@
prop = RNA_def_property(srna, "resolution_scale", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_items(prop, pixel_rate_items);
RNA_def_property_ui_text(prop, "Resolution", "Number of ray per pixel");
RNA_def_property_ui_text(prop, "Resolution", "Number of rays per pixel");
Author
Member

Typo

Typo
@ -6490,3 +6490,3 @@
prop = RNA_def_property(srna, "remote_path", PROP_STRING, PROP_NONE);
RNA_def_property_string_sdna(prop, nullptr, "remote_path");
RNA_def_property_ui_text(prop, "Remote Path", "Remote URL or path for extensions repository");
RNA_def_property_ui_text(prop, "Remote Path", "Remote URL or path for extension repository");
Author
Member

Typo

Typo
@ -173,2 +173,3 @@
public:
CurveParameterFieldInput() : bke::CurvesFieldInput(CPPType::get<float>(), "Curve Parameter node")
CurveParameterFieldInput()
: bke::CurvesFieldInput(CPPType::get<float>(), "Spline Parameter node")
Author
Member

"Curve Parameter node" -> "Spline ...": this is the actual name of the node after its rename in 1cd9fcd98d.

"Curve Parameter node" -> "Spline ...": this is the actual name of the node after its rename in 1cd9fcd98d.
Damien Picard requested review from Hans Goudey 2023-08-15 18:53:17 +02:00
Hans Goudey approved these changes 2023-08-20 00:04:38 +02:00
Hans Goudey left a comment
Member

Just left one response. Thanks again!

Just left one response. Thanks again!
Damien Picard added 1 commit 2023-08-21 00:16:16 +02:00
Hans Goudey merged commit ea974b6681 into main 2023-08-29 14:49:10 +02:00
Damien Picard deleted branch dp_fix_messages 2023-08-29 23:24:55 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111145
No description provided.