Unable to show/hide bone collection on library override armature #111711

New Issue

Closed

opened 2023-08-30 19:37:54 +02:00 by RedMser · 11 comments

RedMser commented

2023-08-30 19:37:54 +02:00

Contributor

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.68

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-08-30 10:37, hash: e071288ab290
Worked: before !109976 was merged

Short description of error
Visibility of bone collections can not be modified for library override armatures.

Exact steps for others to reproduce the error
Create an armature in one blend file.
Link the armature into another blend file.
Add library override and try editing the bone collection visibility.

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.68 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-08-30 10:37, hash: `e071288ab290` Worked: before !109976 was merged **Short description of error** Visibility of bone collections can not be modified for library override armatures. ![image](/attachments/5c8df141-8c87-46c4-9fed-42fd9098fd3f) **Exact steps for others to reproduce the error** Create an armature in one blend file. Link the armature into another blend file. Add library override and try editing the bone collection visibility.

45 KiB

RedMser added the

labels 2023-08-30 19:37:55 +02:00

Pratik Borhade commented

2023-08-31 06:12:48 +02:00

Member

I can confirm.
@dr.sybren @nathanvegdahl , can you check?

"Worked:" before !109976 was merged

But bone groups did not have the visibility property?

I can confirm. @dr.sybren @nathanvegdahl , can you check? > "Worked:" before !109976 was merged But bone groups did not have the visibility property?

Pratik Borhade added

Animation & Rigging

and removed

labels 2023-08-31 06:13:05 +02:00

Nathan Vegdahl commented

2023-08-31 10:24:22 +02:00

Member

Thanks for the report! Yeah, we just discovered this yesterday. Will use this to track it.

But bone groups did not have the visibility property?

But armature layers did, which bone collections also replace.

Thanks for the report! Yeah, we just discovered this yesterday. Will use this to track it. > But bone groups did not have the visibility property? But armature layers did, which bone collections also replace.

Philipp Oeser commented

2023-08-31 10:33:08 +02:00

Member

But bone groups did not have the visibility property?

Assume this is about armature layers, they could be overridden in 3.6.

> But bone groups did not have the visibility property? Assume this is about armature layers, they could be overridden in 3.6.

Philipp Oeser commented

2023-08-31 10:33:53 +02:00

Member

Ah, @nathanvegdahl was quicker...

Will raise prio here, since this is a regression

Ah, @nathanvegdahl was quicker... Will raise prio here, since this is a regression

Philipp Oeser added

and removed

labels 2023-08-31 10:34:05 +02:00

Philipp Oeser commented

2023-08-31 10:35:13 +02:00

Member

Btw. seems like Bone Groups dont actually come over from 3.6 files (only layers do)?
Will check on this.

Btw. seems like Bone Groups dont actually come over from 3.6 files (only layers do)? Will check on this.

Philipp Oeser commented

2023-08-31 10:40:13 +02:00

Member

Btw. seems like Bone Groups dont actually come over from 3.6 files (only layers do)?
Will check on this.

Ah, only comes over if some bone was actually assigned to that group (is this intended?)

> Btw. seems like Bone Groups dont actually come over from 3.6 files (only layers do)? > Will check on this. Ah, only comes over if some bone was actually assigned to that group (is this intended?)

Philipp Oeser referenced a pull request that will close this issue

2023-09-01 09:38:35 +02:00

Fix #111711: bone collection visibility cannot be overridden #111775

Philipp Oeser commented

2023-09-01 09:41:14 +02:00

Member

Proposed fix in !111775

Proposed fix in !111775

Nathan Vegdahl commented

2023-09-01 12:26:57 +02:00

Member

Ah, only comes over if some bone was actually assigned to that group (is this intended?)

Only bring over layers with bones on them was intentional and makes sense. Simply carrying over that same behavior for converting bone groups was also intentional, I think. But we should probably double check with some production people about what's desirable here. @Mets? @Hjalti?

> Ah, only comes over if some bone was actually assigned to that group (is this intended?) Only bring over *layers* with bones on them was intentional and makes sense. Simply carrying over that same behavior for converting bone groups was also intentional, I think. But we should probably double check with some production people about what's desirable here. @Mets? @Hjalti?

Philipp Oeser referenced this issue from a commit

2023-09-02 10:38:32 +02:00

Fix #111711: bone collection visibility cannot be overridden

Philipp Oeser closed this issue

2023-09-02 10:38:33 +02:00

Blender Bot added

and removed

labels 2023-09-02 10:38:35 +02:00

Demeter Dzadik commented

2023-09-04 18:12:39 +02:00

Member

While bone groups with 0 bones assigned are usually unintended, versioning should still preserve them I feel like, just to be on the safe side. If there was an update to the vertex group system, I would also expect empty vertex groups to survive, even though they are strictly speaking pretty much pointless.

While bone groups with 0 bones assigned are usually unintended, versioning should still preserve them I feel like, just to be on the safe side. If there was an update to the vertex group system, I would also expect empty vertex groups to survive, even though they are strictly speaking pretty much pointless.

Sybren A. Stüvel commented

2023-09-05 15:11:14 +02:00

Member

While bone groups with 0 bones assigned are usually unintended, versioning should still preserve them I feel like, just to be on the safe side. If there was an update to the vertex group system, I would also expect empty vertex groups to survive, even though they are strictly speaking pretty much pointless.

I agree.

> While bone groups with 0 bones assigned are usually unintended, versioning should still preserve them I feel like, just to be on the safe side. If there was an update to the vertex group system, I would also expect empty vertex groups to survive, even though they are strictly speaking pretty much pointless. I agree.

Sybren A. Stüvel commented

2023-09-05 15:16:58 +02:00

Member

I just committed @Mets suggestion in bcd0198a46.

I just committed @Mets suggestion in bcd0198a46d8.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

6 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111711

No description provided.