Fix #111711: bone collection visibility cannot be overridden #111775

Merged

Philipp Oeser merged 1 commits from lichtwerk/blender:111711 into main

2023-09-02 10:38:30 +02:00

Philipp Oeser commented

2023-09-01 09:38:35 +02:00

Member

Since the switch from bone layers to bone collections in
998136f7a7, visibility could not be
overridden anymore. Moreso, layers could also be tweaked even in linked
state in 3.6 [those changes get lost on file reload, but it was still
useful and expected behavior].

Both are now restored.

Since the switch from bone layers to bone collections in 998136f7a7b520ef10c998c5af744eb0d464fdd3, visibility could not be overridden anymore. Moreso, layers could also be tweaked even in linked state in 3.6 [those changes get lost on file reload, but it was still useful and expected behavior]. Both are now restored.

Philipp Oeser added 1 commit 2023-09-01 09:38:47 +02:00

13be48861f Fix #111711 : bone collection visibility cannot be overridden

Since the switch from bone layers to bone collections in
998136f7a7, visibility could not be
overridden anymore. Moreso, layers could also be tweaked even in linked
state in 3.6 [those changes get lost on file reload, but it was still
useful and expected behavior].

Both are now restored.

Philipp Oeser added this to the Animation & Rigging project 2023-09-01 09:38:55 +02:00

Philipp Oeser added the

label 2023-09-01 09:39:04 +02:00

Philipp Oeser requested review from Bastien Montagne 2023-09-01 09:39:13 +02:00

Philipp Oeser requested review from Nathan Vegdahl 2023-09-01 09:39:24 +02:00

Philipp Oeser requested review from Sybren A. Stüvel 2023-09-01 09:39:30 +02:00

Philipp Oeser referenced this pull request

2023-09-01 09:41:14 +02:00

Unable to show/hide bone collection on library override armature #111711

Philipp Oeser commented

2023-09-01 09:42:10 +02:00

Author

Member

This survives my basic tests, but extended testing is appreciated

This survives my basic tests, but extended testing is appreciated

Philipp Oeser commented

2023-09-01 09:55:14 +02:00

Author

Member

Noticed though that the UIList for the collections [or at least that single entry] is not really color-coded as overridden then (that should probably be in place before enabling overrides here?)

Noticed though that the UIList for the collections [or at least that single entry] is not really color-coded as overridden then (that should probably be in place before enabling overrides here?)

Bastien Montagne approved these changes 2023-09-01 12:09:37 +02:00

Bastien Montagne left a comment

Owner

LGTM

LGTM

Nathan Vegdahl commented

2023-09-01 12:15:01 +02:00

Member

It looks good to me, and works as expected in my testing. I'm not familiar enough with overrides yet to feel confident signing off on this, so I'll leave that to @mont29 and/or @dr.sybren

Moreso, layers could also be tweaked even in linked state in 3.6

What do you mean by "tweaked"?

It looks good to me, and works as expected in my testing. I'm not familiar enough with overrides yet to feel confident signing off on this, so I'll leave that to @mont29 and/or @dr.sybren > Moreso, layers could also be tweaked even in linked state in 3.6 What do you mean by "tweaked"?

Philipp Oeser commented

2023-09-01 12:36:43 +02:00

Author

Member

What do you mean by "tweaked"?

Visibility ON/OFF
That is what PROP_LIB_EXCEPTION is for in this patch.

  /**
   * This property is editable even if it is lib linked,
   * meaning it will get lost on reload, but it's useful
   * for editing.
   */

> What do you mean by "tweaked"? Visibility ON/OFF That is what `PROP_LIB_EXCEPTION` is for in this patch. ``` /** * This property is editable even if it is lib linked, * meaning it will get lost on reload, but it's useful * for editing. */ ```

Nathan Vegdahl commented

2023-09-01 13:54:17 +02:00

Member

Visibility ON/OFF

Oooooh, got it. I misunderstood the other part of the description. I thought "Since the switch from bone layers to bone collections in 998136f7a7, visibility could not be overridden anymore" was already referring to that. So I thought you were referring to tweaking something beyond visibility.

(Also, somehow I accidentally edited your comment rather than responding. Reverted. I need more coffee, apparently.)

> Visibility ON/OFF Oooooh, got it. I misunderstood the other part of the description. I thought "Since the switch from bone layers to bone collections in 998136f7a7, visibility could not be overridden anymore" was already referring to that. So I thought you were referring to tweaking something beyond visibility. (Also, somehow I accidentally edited your comment rather than responding. Reverted. I need more coffee, apparently.)

Christoph Lendenfeld referenced this pull request

2023-09-01 16:45:06 +02:00

Fix #111776: Bone Collections with linked file from 3.6 #111793

Philipp Oeser merged commit b0d5f3dc22 into main

2023-09-02 10:38:30 +02:00

Philipp Oeser deleted branch 111711

2023-09-02 10:38:32 +02:00

Philipp Oeser referenced this issue from a commit

2023-09-02 10:38:35 +02:00

Fix #111711: bone collection visibility cannot be overridden

Stefan Werner referenced this issue from a commit

2023-09-07 15:02:38 +02:00

Fix #111711: bone collection visibility cannot be overridden

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111775

No description provided.