Regression: Themes: Highlight color in the text menus #112122

New Issue

Arunderan · 2023-09-08T08:44:08+02:00

Arunderan commented

2023-09-08 08:44:08 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-03 15:22, hash: 30de3d7c1a79
Worked: 3.6.2

Short description of error
The highlight color is not longer adjustable by the Selected color in the User Interface / Menu Item panel. But changes with the Inner color. This breaks theming.

Exact steps for others to reproduce the error

Enter Preferences.
Navigage to Themes tab, User Interface, Menu Item panel.
Play around with the Selected and Inner color

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-03 15:22, hash: `30de3d7c1a79` Worked: 3.6.2 **Short description of error** The highlight color is not longer adjustable by the Selected color in the User Interface / Menu Item panel. But changes with the Inner color. This breaks theming. **Exact steps for others to reproduce the error** - Enter Preferences. - Navigage to Themes tab, User Interface, Menu Item panel. - Play around with the Selected and Inner color

2023-09-08 08-32-10.mp4

9.7 MiB

theming.jpg

358 KiB

Arunderan added the

labels 2023-09-08 08:44:09 +02:00

Pratik Borhade commented

2023-09-08 11:18:27 +02:00

Thanks for the report. I can confirm. We'd need to tweak the preference labels and properties here.
I'll check.

Thanks for the report. I can confirm. We'd need to tweak the preference labels and properties here. I'll check.

Pratik Borhade added

and removed

labels 2023-09-08 11:18:38 +02:00

Pratik Borhade commented

2023-09-08 12:47:32 +02:00

AFAICT this is working as expected. inner property is used to fill the hovered/selected button
We could make this consistent with other widget types. For example: UILIST
So highlight color will be decided by the text color.

diff --git a/source/blender/editors/interface/interface_widgets.cc b/source/blender/editors/interface/interface_widgets.cc
index f412c113302..f92167e2a25 100644
--- a/source/blender/editors/interface/interface_widgets.cc
+++ b/source/blender/editors/interface/interface_widgets.cc
@@ -2744,9 +2744,9 @@ static void widget_state_menu_item(uiWidgetType *wt,
   }
   else if (state->but_flag & UI_ACTIVE) {
     /* Regular hover. */
-    color_blend_v3_v3(wt->wcol.inner, wt->wcol.text, 0.2f);
+    copy_v3_v3_uchar(wt->wcol.inner, wt->wcol.text);
     copy_v3_v3_uchar(wt->wcol.text, wt->wcol.text_sel);
-    wt->wcol.inner[3] = 255;
+    wt->wcol.inner[3] = 20;
     wt->wcol.text[3] = 255;
   }
 }

I doubt whether this will be classified as a bug. One proper fix will to add a member in uiWidgetColors struct, which can be used to decide hover color.
@Harley ^

AFAICT this is working as expected. `inner` property is used to fill the hovered/selected button We could make this consistent with other widget types. For example: UILIST So highlight color will be decided by the text color. ```Diff diff --git a/source/blender/editors/interface/interface_widgets.cc b/source/blender/editors/interface/interface_widgets.cc index f412c113302..f92167e2a25 100644 --- a/source/blender/editors/interface/interface_widgets.cc +++ b/source/blender/editors/interface/interface_widgets.cc @@ -2744,9 +2744,9 @@ static void widget_state_menu_item(uiWidgetType *wt, } else if (state->but_flag & UI_ACTIVE) { /* Regular hover. */ - color_blend_v3_v3(wt->wcol.inner, wt->wcol.text, 0.2f); + copy_v3_v3_uchar(wt->wcol.inner, wt->wcol.text); copy_v3_v3_uchar(wt->wcol.text, wt->wcol.text_sel); - wt->wcol.inner[3] = 255; + wt->wcol.inner[3] = 20; wt->wcol.text[3] = 255; } } ``` - - - I doubt whether this will be classified as a bug. One proper fix will to add a member in `uiWidgetColors` struct, which can be used to decide hover color. @Harley ^

Pratik Borhade added

Status

Needs Info from Developers

and removed

Status

Confirmed

labels 2023-09-08 12:48:39 +02:00

Iliya Katushenock changed title from ~~Themes - Highlight color in the text menus regression~~ to Regression: Themes: Highlight color in the text menus

2023-09-08 13:37:13 +02:00

Arunderan commented

2023-09-08 15:03:56 +02:00

Well, it does influence the inactive color now, which it imo shouldn't. Inactive should be greyed out, not colored with the highlight color. And it works different from Blender 3.6.2, it breaks the old themes.

What is the Selected color now doing?

Well, it does influence the inactive color now, which it imo shouldn't. Inactive should be greyed out, not colored with the highlight color. And it works different from Blender 3.6.2, it breaks the old themes. What is the Selected color now doing?

Pratik Borhade referenced this issue

2023-09-10 04:23:56 +02:00

Regression: The color theme of menu broken of 4.0 #112178

Andres Stephens commented

2023-09-11 19:56:03 +02:00

Can confirm from another user in Erindales discord server, using the highlight color for disabled menu entries does indeed cause a conflicting UX. Should be a different prop that isn't the highlight colour.

![image](/attachments/5a5adf6e-931d-4a8e-8537-88806ec8cfe3) Can confirm from another user in Erindales discord server, using the highlight color for disabled menu entries does indeed cause a conflicting UX. Should be a different prop that isn't the highlight colour.

image.png

66 KiB

Pratik Borhade referenced a pull request that will close this issue

2023-09-14 14:07:26 +02:00

Fix #112122: Hover color matches with disabled buttons #112380

Pratik Borhade referenced this issue

2023-09-30 10:47:36 +02:00

Regression: Blender 4.0 frozen menu items use Inner Menu item color #113022

Ludvik Koutny referenced this issue

2023-09-30 10:56:52 +02:00

Regression: Blender 4.0 frozen menu items use Inner Menu item color #113022

Pratik Borhade referenced this issue

2023-09-30 10:57:24 +02:00

Regression: Blender 4.0 Menu Item inner color does not match the color selected in the theme editor: #113009

Pratik Borhade referenced this issue

2023-09-30 11:09:42 +02:00

Regression: Blender 4.0 frozen menu items use Inner Menu item color #113022

Ludvik Koutny referenced this issue

2023-09-30 11:19:36 +02:00

Regression: Blender 4.0 frozen menu items use Inner Menu item color #113022

Ludvik Koutny referenced this issue

2023-09-30 11:25:33 +02:00

Regression: Blender 4.0 Menu Item inner color does not match the color selected in the theme editor: #113009

Jesse Yurkovich referenced this issue

2023-10-03 23:46:19 +02:00

Regression in Menu Items theming in Blender 4.0.0 Beta #113221

Pratik Borhade referenced this issue

2023-10-04 06:22:45 +02:00

Regression in Menu Items theming in Blender 4.0.0 Beta #113221

Pratik Borhade referenced this issue

2023-10-20 06:56:35 +02:00

Regression: Menu item highlight color hardcoded in 4.0 #113943

Ludvik Koutny referenced this issue

2023-10-20 10:07:34 +02:00

Regression: Menu item highlight color hardcoded in 4.0 #113943

Pratik Borhade referenced this issue

2023-11-16 06:22:47 +01:00

UI problem of Menu Items #114959

funkyou commented

2023-12-22 13:40:47 +01:00

I was about to report it too. This just doesn't make sense.

Blender 4.0.1

Blender 3.5

I was about to report it too. This just doesn't make sense. **Blender 4.0.1** ![image](/attachments/4f31973a-f58f-44fb-bc3a-396ef6b2faf0)![image](/attachments/c71f131d-3de6-4d7f-98f7-3bad0b103470) **Blender 3.5** ![image](/attachments/9b26d699-6e80-4c47-bf8a-072d4cd95535)![image](/attachments/af6965e2-4ecd-404e-8654-ab03fde604b7)

image.png

83 KiB

image.png

35 KiB

image.png

56 KiB

image.png

62 KiB

Pratik Borhade referenced this issue

2024-03-29 11:06:26 +01:00

Fix #112122: Hover color matches with disabled buttons #112380

Pratik Borhade added

Status

Confirmed

and removed

Status

Needs Info from Developers

labels 2024-03-29 11:06:37 +01:00

Pablo Vazquez commented

2024-04-02 16:17:05 +02:00

I don't think this is applicable to the latest Blender 4.2 alpha? Not sure what's broken, tried to replicate the image in the report description and it looks as expected.

Menu Item Inner -- Background color of the menu entry background
Menu Item Inner Selected -- Used when the menu entry is selected (for example the active editor in the editors dropdown)

I don't think this is applicable to the latest Blender 4.2 alpha? Not sure what's broken, tried to replicate the image in the report description and it looks as expected. ![inner color for menu item](/attachments/d3efc5b3-9928-4554-a9dd-2a3cd2c4713a) - Menu Item Inner -- Background color of the menu entry background - Menu Item Inner Selected -- Used when the menu entry is selected (for example the active editor in the editors dropdown)

image.png

222 KiB

Arunderan commented

2024-04-02 17:44:57 +02:00

Yes, works as expected now. I guess there was a fix from another task then.

Harley Acheson referenced this issue

2024-04-03 21:05:33 +02:00

Fix #112122: Hover color matches with disabled buttons #112380

Pratik Borhade referenced this issue

2024-04-04 13:39:38 +02:00

Fix #112122: Hover color matches with disabled buttons #112380

Pratik Borhade commented