Regression: Blender 4.0 frozen menu items use Inner Menu item color #113022

New Issue

Ludvik Koutny · 2023-09-28T16:50:39+02:00

Ludvik Koutny commented

2023-09-28 16:50:39 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.13

Blender Version
Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-09-28 00:03, hash: 751c9ef620a0
Worked: (newest version of Blender that worked as expected)

Short description of error
In Blender 4.0, frozen menu items use "Inner" Menu Item color, this is a serious problem because user needs to make an impossible choice between:

Having hovered menu items displayed in an accented color
Having frozen menu items appear in a grayed out color, which visually implies they are frozen, instead of accent color, which implies they are not frozen but have special purpose/are of special type:

Exact steps for others to reproduce the error

In Blender 4.0, set Menu Item "Inner" color to some colorful accent color
Open any menu which has some frozen entries
Result: It is not possible to separate color of hovered menu items from the color of frozen menu items.
Expected: It is possible to separate color of hovered menu items from the color of frozen menu items, as was in 3.6.

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.13 **Blender Version** Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-09-28 00:03, hash: `751c9ef620a0` Worked: (newest version of Blender that worked as expected) **Short description of error** In Blender 4.0, frozen menu items use "Inner" Menu Item color, this is a serious problem because user needs to make an impossible choice between: - Having hovered menu items displayed in an accented color - Having frozen menu items appear in a grayed out color, which visually implies they are frozen, instead of accent color, which implies they are not frozen but have special purpose/are of special type: ![image](/attachments/5c6da54b-58d5-4fb9-932f-8dbfb00b1af1) **Exact steps for others to reproduce the error** 1. In Blender 4.0, set Menu Item "Inner" color to some colorful accent color 2. Open any menu which has some frozen entries Result: It is not possible to separate color of hovered menu items from the color of frozen menu items. Expected: It is possible to separate color of hovered menu items from the color of frozen menu items, as was in 3.6.

image.png

105 KiB

Ludvik Koutny added the

labels 2023-09-28 16:50:39 +02:00

Germano Cavalcante commented

2023-09-29 19:13:57 +02:00

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors.

For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors. For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Germano Cavalcante closed this issue

2023-09-29 19:13:59 +02:00

Blender Bot added

and removed

labels 2023-09-29 19:14:01 +02:00

Ludvik Koutny commented

2023-09-29 22:11:11 +02:00

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors.

For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

What you mean? This is clearly a regression. Having to make a choice between being able to set hovered menu item highlight to non hardcoded accent color or having correctly displayed frozen menu item is absolutely insane!

This IS a regression. It works in 3.6:

Notice that the hovered menu item is displayed in Cyan accent color while the frozen menu items are dark gray. In 4.0 this is not possible.

First, make sure you are actually able to do the same theme customization in 4.0 before you close this, because it's currently not possible:

> Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors. > > For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests > > For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug What you mean? This is clearly a regression. Having to make a choice between being able to set hovered menu item highlight to non hardcoded accent color or having correctly displayed frozen menu item is absolutely insane! This IS a regression. It works in 3.6: ![image](/attachments/546077a3-d6aa-4ab6-8040-7af47c6c4d5d) Notice that the hovered menu item is displayed in Cyan accent color while the frozen menu items are dark gray. In 4.0 this is not possible. First, make sure you are actually able to do the same theme customization in 4.0 before you close this, because it's currently not possible: ![image](/attachments/4b051b7f-9242-43c2-b59e-e7619d0f52dc)

image.png

177 KiB

image.png

204 KiB

image.png

246 KiB

Germano Cavalcante commented

2023-09-29 23:33:56 +02:00

This is clearly a regression.
(...) It works in 3.6...

Oh, that changes things! Confirming then.

Sorry for the misunderstand.

(It is useful to fill in all the fields in the template, including the Worked: field which informs whether it is a regression and when it worked).

> This is clearly a regression. > (...) It works in 3.6... Oh, that changes things! Confirming then. Sorry for the misunderstand. (It is useful to fill in all the fields in the template, including the `Worked:` field which informs whether it is a regression and when it worked).

Germano Cavalcante added

and removed

labels 2023-09-29 23:34:24 +02:00

Germano Cavalcante reopened this issue

2023-09-29 23:34:34 +02:00

Ludvik Koutny commented

2023-09-30 08:24:28 +02:00

This is clearly a regression.
(...) It works in 3.6...

Oh, that changes things! Confirming then.

Sorry for the misunderstand.

(It is useful to fill in all the fields in the template, including the Worked: field which informs whether it is a regression and when it worked).

Yeah, sorry for me yelling. I was angry because this would mean all my custom themes would stop working. And there's no better way to make people angry than using that copy pasted message:

For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

> > This is clearly a regression. > > (...) It works in 3.6... > > Oh, that changes things! Confirming then. > > Sorry for the misunderstand. > > (It is useful to fill in all the fields in the template, including the `Worked:` field which informs whether it is a regression and when it worked). Yeah, sorry for me yelling. I was angry because this would mean all my custom themes would stop working. And there's no better way to make people angry than using that copy pasted message: > For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests > > For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Ludvik Koutny referenced this issue

2023-09-30 09:21:17 +02:00

Regression: Blender 4.0 Menu Item inner color does not match the color selected in the theme editor: #113009

Pratik Borhade commented

2023-09-30 10:47:36 +02:00

Re: hovered item using inner widget color.
I've submitted a PR for it: #112380 . Feel free to add your suggestions there.
We can close your as duplicate of #112122

Re: disabled items using inner widget color.
Behavior is same in 3.6 too

Re: hovered item using `inner` widget color. I've submitted a PR for it: https://projects.blender.org/blender/blender/pulls/112380 . Feel free to add your suggestions there. We can close your as duplicate of #112122 - - - Re: disabled items using `inner` widget color. Behavior is same in 3.6 too

Ludvik Koutny commented

2023-09-30 10:56:52 +02:00

Re: hovered item using inner widget color.
I've submitted a PR for it: #112380 . Feel free to add your suggestions there.
We can close your as duplicate of #112122

Re: disabled items using inner widget color.
Behavior is same in 3.6 too

I am confused. That PR has actually Pablo's comment suggesting blending the color. So does your PR blend the color or not?

> Re: hovered item using `inner` widget color. > I've submitted a PR for it: https://projects.blender.org/blender/blender/pulls/112380 . Feel free to add your suggestions there. > We can close your as duplicate of #112122 > > - - - > Re: disabled items using `inner` widget color. > Behavior is same in 3.6 too I am confused. That PR has actually Pablo's comment suggesting blending the color. So does your PR blend the color or not?

Pratik Borhade referenced this issue

2023-09-30 10:57:24 +02:00

Regression: Blender 4.0 Menu Item inner color does not match the color selected in the theme editor: #113009

Pratik Borhade commented

2023-09-30 11:04:50 +02:00

With the PR applied ,Hovered item will not have inner color. Instead, color of it will be mix of the text color and background color of menu.
BTW do you build blender yourself? Otherwise I'll start package build of PR#112380 for you to test the PR locally.

My earlier solution was to use text color to highlight hovered item with small alpha value. Same thing is done to highlight UIList item: 900441f17d / #112122 (comment)
And we never had complaints about this usage.

But Pablo suggested to mix between text and background color. So I did: 41c8fb2c28

With the PR applied ,Hovered item will not have `inner` color. Instead, color of it will be mix of the text color and background color of menu. BTW do you build blender yourself? Otherwise I'll start package build of `PR#112380` for you to test the PR locally. - - - My earlier solution was to use `text` color to highlight hovered item with small alpha value. Same thing is done to highlight UIList item: https://projects.blender.org/blender/blender/commit/900441f17da69adbcd9a4191cdffdf68f60ff750 / https://projects.blender.org/blender/blender/issues/112122#issuecomment-1016790 And we never had complaints about this usage. But Pablo suggested to mix between text and background color. So I did: https://projects.blender.org/blender/blender/commit/41c8fb2c28692389178ba2efeab96ce2e8b4196f

Ludvik Koutny commented

2023-09-30 11:19:36 +02:00

With the PR applied ,Hovered item will not have inner color. Instead, color of it will be mix of the text color and background color of menu.
BTW do you build blender yourself? Otherwise I'll start package build of PR#112380 for you to test the PR locally.

My earlier solution was to use text color to highlight hovered item with small alpha value. Same thing is done to highlight UIList item: 900441f17d / #112122 (comment)
And we never had complaints about this usage.

But Pablo suggested to mix between text and background color. So I did: 41c8fb2c28

I am getting a bit lost in this mess, here's how it should be:

The highlight of the hovered item should use the unmodified "Inner" widget color, not a mix.
The text of the frozen items should use the "Text" color, with reduced alpha, let's say 0.5. In all common sense software, frozen text is always displayed as a less opaque version of the unfrozen text. Reducing alpha will also help you to avoid a hack where if you used darker version of the text color, you would need to test the value of the text color, and if the value is dark, you'd have to make it brighter instead). Modifying alpha/opacity of the text makes reliable freeze effect which works for both dark and bright text color.

The bug here is that the frozen text is still a text, yet it doesn't use widget's text color, but widget's inner color, which is not meant for text.

> With the PR applied ,Hovered item will not have `inner` color. Instead, color of it will be mix of the text color and background color of menu. > BTW do you build blender yourself? Otherwise I'll start package build of `PR#112380` for you to test the PR locally. > > - - - > My earlier solution was to use `text` color to highlight hovered item with small alpha value. Same thing is done to highlight UIList item: https://projects.blender.org/blender/blender/commit/900441f17da69adbcd9a4191cdffdf68f60ff750 / https://projects.blender.org/blender/blender/issues/112122#issuecomment-1016790 > And we never had complaints about this usage. > > But Pablo suggested to mix between text and background color. So I did: https://projects.blender.org/blender/blender/commit/41c8fb2c28692389178ba2efeab96ce2e8b4196f I am getting a bit lost in this mess, here's how it should be: - The highlight of the hovered item should use the unmodified "Inner" widget color, not a mix. - The text of the frozen items should use the "Text" color, with reduced alpha, let's say 0.5. In all common sense software, frozen text is always displayed as a less opaque version of the unfrozen text. Reducing alpha will also help you to avoid a hack where if you used darker version of the text color, you would need to test the value of the text color, and if the value is dark, you'd have to make it brighter instead). Modifying alpha/opacity of the text makes reliable freeze effect which works for both dark and bright text color. The bug here is that the frozen text is still a text, yet it doesn't use widget's text color, but widget's inner color, which is not meant for text.

Ludvik Koutny referenced this issue

2023-09-30 11:25:33 +02:00

Regression: Blender 4.0 Menu Item inner color does not match the color selected in the theme editor: #113009

Pratik Borhade commented

2023-09-30 11:34:37 +02:00

The text of the frozen items should use the "Text" color, with reduced alpha, let's say 0.5

Make sense actually. I'll make a quick PR.
(But this is not a regression really 🙂 )

> The text of the frozen items should use the "Text" color, with reduced alpha, let's say 0.5 Make sense actually. I'll make a quick PR. (But this is not a regression really 🙂 )

Ludvik Koutny commented

2023-09-30 11:44:40 +02:00

The text of the frozen items should use the "Text" color, with reduced alpha, let's say 0.5

Make sense actually. I'll make a quick PR.
(But this is not a regression really 🙂 )

Regression is that in 3.6 you can have both colored hover highlight and uncolored frozen text. In 4.0 you can either have colored hover highlight, OR uncolored frozen text.

If you choose to have colored highlight, you end up with a frozen text that doesn't appear frozen, but instead special (some software use colored text to imply it's a feature added in a new version).
If you choose to have text that correctly appears frozen, you can not have colored highlight.

If you still do not consider this a regression, then please just provide me with a set of steps to have blue hovered menu item highlight but gray frozen text color in 4.0, like on the 3.6 picture above.

> > The text of the frozen items should use the "Text" color, with reduced alpha, let's say 0.5 > > Make sense actually. I'll make a quick PR. > (But this is not a regression really 🙂 ) Regression is that in 3.6 you can have both colored hover highlight **and** uncolored frozen text. In 4.0 you can either have colored hover highlight, **OR** uncolored frozen text. - If you choose to have colored highlight, you end up with a frozen text that doesn't appear frozen, but instead special (some software use colored text to imply it's a feature added in a new version). - If you choose to have text that correctly appears frozen, you can not have colored highlight. ![3.6.png](/attachments/38f808c0-1d2c-4ace-b858-1a1e4e095229) ![4.0.png](/attachments/fa0fb4de-f95d-4f67-8e7c-daf3c464c01a) If you still do not consider this a regression, then please just provide me with a set of steps to have blue hovered menu item highlight but gray frozen text color in 4.0, like on the 3.6 picture above.

4.0.png

78 KiB

3.6.png

74 KiB

Pratik Borhade referenced a pull request that will close this issue

2023-09-30 11:56:51 +02:00

Fix #113022: Disabled menu item's text uses inner color #113082

Pratik Borhade self-assigned this 2023-09-30 13:00:04 +02:00

Jesse Yurkovich referenced this issue

2023-10-03 23:46:19 +02:00

Regression in Menu Items theming in Blender 4.0.0 Beta #113221

Pratik Borhade referenced this issue