UI: Hide asset shelf toggles if not available #113063

Julian Eisel · 2023-09-29T15:58:48+02:00

Julian Eisel commented

2023-09-29 15:58:48 +02:00

The "Asset Shelf" checkbox can be confusing for people, they enable it
but it still can't get the shelf to show up. This is because the shelf is only
available in certain context (pose mode only for the start). For now
hide the option entirely unless the asset shelf becomes available.

This change adds a new bpy.types.Region.poll_failed property to query
the availability of a region.

The "Asset Shelf" checkbox can be confusing for people, they enable it but it still can't get the shelf to show up. This is because the shelf is only available in certain context (pose mode only for the start). For now hide the option entirely unless the asset shelf becomes available. This change adds a new `bpy.types.Region.poll_failed` property to query the availability of a region.

Julian Eisel added 1 commit 2023-09-29 15:59:00 +02:00

df1d882acd UI: Hide asset shelf toggles if not available

The "Asset Shelf" checkbox can be confusing for people, they enable it
but it still can't get the shelf to show up. This is because it is only
available in certain context (pose mode only for the start). For now
hide the option entirely unless the asset shelf becomes available.

This change adds a new `bpy.types.Region.poll_failed` property to query
the availability of a region.

Julian Eisel requested review from Campbell Barton 2023-09-29 15:59:30 +02:00

Julian Eisel referenced this pull request

2023-09-29 16:01:03 +02:00

Gray out "Asset Shelf" region toggle in menu if none is available #110756

Dalai Felinto approved these changes 2023-10-05 14:27:42 +02:00

Dismissed

Dalai Felinto left a comment

~~Go for it then~~ Sorry, I typed on the wrong patch.

~~Go for it then~~ Sorry, I typed on the wrong patch.

Julien Kaspar commented

2023-10-05 16:02:11 +02:00

I'd rather say grey it out.
The same is the case for the extended shading pie menu and Xray. While using Eevee or Cycles in the viewport the Xray toggle is still in the pie menu but greyed out and toggling it won't have a visible effect.

I'd rather say grey it out. The same is the case for the extended shading pie menu and Xray. While using Eevee or Cycles in the viewport the Xray toggle is still in the pie menu but greyed out and toggling it won't have a visible effect.

Julian Eisel commented

2023-10-05 16:25:28 +02:00

I'd rather say grey it out.
The same is the case for the extended shading pie menu and Xray. While using Eevee or Cycles in the viewport the Xray toggle is still in the pie menu but greyed out and toggling it won't have a visible effect.

Generally I'd also prefer graying it out. However, the asset shelf is only used by default in pose mode right now and it's tricky to find that out. People would just see this grayed out option almost always, and be confused about it. At least when I tried it it felt that way. Add-ons may register own asset shelves, so if there is a disabled hint in the tooltip, it would be vague like "Not available in the current context". So it doesn't really solve the confusion.

Once the asset shelf is used more commonly, I'd say gray it out indeed. But for now, that would cause more harm than it's useful. For a (a bit weak) consistency argument: Other editors that change the available regions based on their mode also don't show these region toggles, e.g. the Sequencer Preview view type doesn't list the Channels and Adjust Last Operation toggles.

> I'd rather say grey it out. > The same is the case for the extended shading pie menu and Xray. While using Eevee or Cycles in the viewport the Xray toggle is still in the pie menu but greyed out and toggling it won't have a visible effect. Generally I'd also prefer graying it out. However, the asset shelf is only used by default in pose mode right now and it's tricky to find that out. People would just see this grayed out option almost always, and be confused about it. At least when I tried it it felt that way. Add-ons may register own asset shelves, so if there is a disabled hint in the tooltip, it would be vague like "Not available in the current context". So it doesn't really solve the confusion. Once the asset shelf is used more commonly, I'd say gray it out indeed. But for now, that would cause more harm than it's useful. For a (a bit weak) consistency argument: Other editors that change the available regions based on their mode also don't show these region toggles, e.g. the Sequencer _Preview_ view type doesn't list the _Channels_ and _Adjust Last Operation_ toggles.

Dalai Felinto requested review from Dalai Felinto 2023-10-05 16:34:09 +02:00

Dalai Felinto refused to review 2023-10-05 16:34:18 +02:00

Dalai Felinto dismissed dfelinto’s review 2023-10-05 16:35:22 +02:00

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u temp-asset-shelf-toggle-hide:JulianEisel-temp-asset-shelf-toggle-hide

git checkout JulianEisel-temp-asset-shelf-toggle-hide

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Hide asset shelf toggles if not available #113063

Checkout