Gray out "Asset Shelf" region toggle in menu if none is available #110756

Open

Julian Eisel wants to merge 2 commits from JulianEisel/blender:temp-asset-shelf-region-toggle-disable into asset-shelf

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Julian Eisel commented

2023-08-03 14:47:45 +02:00

Member

The 3D View > View > Asset Shelf toggle can be confusing when no asset shelf
is available. Better to gray it out then. Ideally we would display a disabled
hint in the tooltip, but the current code doesn't allow doing that while
keeping the property editable.

Multiple ways to go about this, e.g. we could have some dedicated query
in the API. But I think querying this through region context makes
sense, since we can get all the necessary information that way already.

The _3D View > View > Asset Shelf_ toggle can be confusing when no asset shelf is available. Better to gray it out then. Ideally we would display a disabled hint in the tooltip, but the current code doesn't allow doing that while keeping the property editable. Multiple ways to go about this, e.g. we could have some dedicated query in the API. But I think querying this through region context makes sense, since we can get all the necessary information that way already.

Julian Eisel added the

labels 2023-08-03 14:47:45 +02:00

Julian Eisel added 1 commit 2023-08-03 14:47:57 +02:00

73f1f628ba Gray out "Asset Shelf" region toggle in menu if none is available

Multiple ways to go about this, e.g. we could have some dedicated query
in the API. But I think querying this through region context makes
sense.

Julian Eisel added 1 commit 2023-08-03 15:07:48 +02:00

b11b644da0 Merge branch 'asset-shelf' into temp-asset-shelf-region-toggle-disable

Julian Eisel referenced this pull request

2023-08-03 15:08:29 +02:00

UI: Asset Shelf (Experimental Feature) #104831

Julian Eisel requested review from Campbell Barton 2023-08-03 15:18:50 +02:00

Julian Eisel added a new dependency 2023-08-03 15:19:08 +02:00

#104831 UI: Asset Shelf (Experimental Feature)

Campbell Barton reviewed 2023-08-03 15:30:14 +02:00

scripts/startup/bl_ui/asset_shelf.py

						
				@ -27,6 +27,19 @@ class ASSETSHELF_PT_display(Panel):

				        return context.asset_shelf is not None

				class Utils:

Campbell Barton commented

2023-08-03 15:30:14 +02:00

Owner

This is included in a way which makes it seem like it's intended to be a public function. If other UI code is expected to access this (outside of Blender's own scripts).

Would it be a more general solution to to able to access region.poll() or expose RGN_FLAG_POLL_FAILED to RNA?
This way it's possible to check if regions would be shown without having custom per-region API's.

This is included in a way which makes it seem like it's intended to be a public function. If other UI code is expected to access this (outside of Blender's own scripts). Would it be a more general solution to to able to access `region.poll()` or expose `RGN_FLAG_POLL_FAILED` to RNA? This way it's possible to check if regions would be shown without having custom per-region API's.

Julian Eisel referenced this pull request

2023-08-03 17:54:21 +02:00

Nodes: Add asset shelf support to node editor #110589

Julian Eisel commented

2023-09-29 16:01:03 +02:00

Author

Member

Submitted an alternative solution: #113063. It exposes the region poll result and hides the menu items entirely as opposed to graying them out, to avoid further confusion.

Submitted an alternative solution: #113063. It exposes the region poll result and hides the menu items entirely as opposed to graying them out, to avoid further confusion.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u temp-asset-shelf-region-toggle-disable:JulianEisel-temp-asset-shelf-region-toggle-disable

git checkout JulianEisel-temp-asset-shelf-region-toggle-disable

Merge

Merge the changes and update on Gitea.

git checkout asset-shelf

git merge --no-ff JulianEisel-temp-asset-shelf-region-toggle-disable

git checkout asset-shelf

git merge --ff-only JulianEisel-temp-asset-shelf-region-toggle-disable

git checkout JulianEisel-temp-asset-shelf-region-toggle-disable

git rebase asset-shelf

git checkout asset-shelf

git merge --no-ff JulianEisel-temp-asset-shelf-region-toggle-disable

git checkout asset-shelf

git merge --squash JulianEisel-temp-asset-shelf-region-toggle-disable

git checkout asset-shelf

git merge JulianEisel-temp-asset-shelf-region-toggle-disable

git push origin asset-shelf

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on

#104831 UI: Asset Shelf (Experimental Feature)

blender/blender

Reference: blender/blender#110756

No description provided.