EEVEE-Next: Per probe viewport display #114176

Miguel Pozo · 2023-10-26T18:04:26+02:00

Miguel Pozo commented

2023-10-26 18:04:26 +02:00

Add viewport display support for Sphere and Plane probes.
Make all probe display options per object instead of per scene.
(Uses the already existing LIGHTPROBE_FLAG_SHOW_DATA and adds a new show_data_size property to the LightProbe dna)

* Add viewport display support for Sphere and Plane probes. * Make all probe display options per object instead of per scene. (Uses the already existing `LIGHTPROBE_FLAG_SHOW_DATA` and adds a new `show_data_size` property to the `LightProbe` dna)

Miguel Pozo added the

labels 2023-10-26 18:04:26 +02:00

Miguel Pozo added 3 commits 2023-10-26 18:04:39 +02:00

7a77540ccf Per-probe display settings

3545f1fdcc Ignore SCE_EEVEE_SHOW_IRRADIANCE

dde809cb09 Add show_data_size default

Miguel Pozo added 1 commit 2023-10-27 20:02:53 +02:00

200e5bfaa3 Add reflection probes viewport display

Miguel Pozo changed title from ~~EEVEE-Next: Per Volume Probe viewport display options~~ to EEVEE-Next: Per probe viewport display

2023-10-27 20:03:35 +02:00

Miguel Pozo requested review from Clément Foucault 2023-10-27 20:09:18 +02:00

Clément Foucault requested changes 2023-10-31 17:14:52 +01:00

Clément Foucault left a comment

I think it's missing the plane light probe display.

Otherwise the implementation looks good.

I think it's missing the plane light probe display. Otherwise the implementation looks good.

source/blender/makesrna/intern/rna_lightprobe.cc Outdated

						
				@ -322,0 +322,4 @@

				  RNA_def_property_override_flag(prop, PROPOVERRIDE_OVERRIDABLE_LIBRARY);

				  RNA_def_property_update(prop, NC_MATERIAL | ND_SHADING, nullptr);

				  prop = RNA_def_property(srna, "show_data_size", PROP_FLOAT, PROP_DISTANCE);

Clément Foucault commented

2023-10-31 17:09:30 +01:00

The naming is confusing. Could be interpreted that it shows the size.

I'm tempted to rename the show_data to use_data_display. Then this property would become data_display_size which would avoid this confusion.

The naming is confusing. Could be interpreted that it shows the size. I'm tempted to rename the `show_data` to `use_data_display`. Then this property would become `data_display_size` which would avoid this confusion.

Miguel Pozo commented

2023-10-31 17:50:37 +01:00

I would go with show_data_display_size, to avoid breaking the Python API.

I would go with `show_data_display_size`, to avoid breaking the Python API.

Clément Foucault commented

2023-11-01 01:11:49 +01:00

Like I said in another task, we can keep the old name in the RNA for compatibility reason and add a deprecation warning in the property description. The new property would just be an alias.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

EEVEE-Next: Per probe viewport display #114176