Custom pose bone colors invisible in Stick Mode #115434

New Issue

i.am.ozark · 2023-11-26T05:39:45+01:00

i.am.ozark commented

2023-11-26 05:39:45 +01:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.79

Blender Version
Broken: version: 4.0.1, branch: blender-v4.0-release, commit date: 2023-11-16 16:40, hash: d0dd92834a08
Worked: 3.6.0, branch: blender-v3.6-release, commit date: 2023-06-27 08:08, hash: c7fc78b81ecb

As the title says, when a custom pose bone bone color is used, it becomes invisible in Stick bone view. Octahedral and the rest are still fine. I've attached two images showing the difference, as well as the relevant .blend file.

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.79 **Blender Version** Broken: version: 4.0.1, branch: blender-v4.0-release, commit date: 2023-11-16 16:40, hash: `d0dd92834a08` Worked: 3.6.0, branch: blender-v3.6-release, commit date: 2023-06-27 08:08, hash: `c7fc78b81ecb` As the title says, when a custom pose bone bone color is used, it becomes invisible in Stick bone view. Octahedral and the rest are still fine. I've attached two images showing the difference, as well as the relevant .blend file.

stick-mode.png

1.0 MiB

oct-mode.png

878 KiB

rose-error.blend

3.9 MiB

i.am.ozark added the

labels 2023-11-26 05:39:45 +01:00

Pratik Borhade commented

2023-11-27 07:04:05 +01:00

Thanks for the report. I can confirm, bisecting.

Pratik Borhade added

and removed

labels 2023-11-27 07:04:19 +01:00

Pratik Borhade commented

2023-11-27 08:44:09 +01:00

Caused by d4262071b1
This is because alpha channel is 0 instead of 255 (and we're now copying all 4 channels copy_v4_v4_uchar, hence the error)
cc @Jeroen-Bakker

Caused by d4262071b18ba56f697d80655f33d0ef196d7b03 This is because alpha channel is 0 instead of 255 (and we're now copying all 4 channels `copy_v4_v4_uchar`, hence the error) cc @Jeroen-Bakker

Jeroen Bakker commented

2023-11-27 09:29:45 +01:00

Error seems to be in the UI/data management side of custom bone colors, my fix only makes the issue visible.

The custom bone colors are stored in ThemeWireColor as RGBA, but in the user interface only RGB can be edited.
What IMO needs to be done is that when initializing this struct the A value should be filled fully opaque (255).

This isn't done for #109976 there only RGB are filled, A is ignored.
I can fix this in the drawing code, but that seems to be odd as the attribute uses A values.

Changing this will requires:

versioning code to set 1.0 to all bone color custom color structs
initialize the bone color struct to set the alpha value.

Would rather have the animation module to take on this issue as it is more data/functional related and I don't
want to assume stuff.

Error seems to be in the UI/data management side of custom bone colors, my fix only makes the issue visible. The custom bone colors are stored in `ThemeWireColor` as RGBA, but in the user interface only RGB can be edited. What IMO needs to be done is that when initializing this struct the A value should be filled fully opaque (255). This isn't done for https://projects.blender.org/blender/blender/pulls/109976 there only RGB are filled, A is ignored. I can fix this in the drawing code, but that seems to be odd as the attribute uses A values. Changing this will requires: * versioning code to set 1.0 to all bone color custom color structs * initialize the bone color struct to set the alpha value. Would rather have the animation module to take on this issue as it is more data/functional related and I don't want to assume stuff.

Pratik Borhade commented

2023-11-27 09:59:04 +01:00

I can fix this in the drawing code, but that seems to be odd as the attribute uses A values.

Right, btw I edited the actual commit that caused it (I accidently pasted non-existing hash value 😅 )

> I can fix this in the drawing code, but that seems to be odd as the attribute uses A values. Right, btw I edited the actual commit that caused it (I accidently pasted non-existing hash value 😅 )

Pratik Borhade commented

2023-11-27 10:03:16 +01:00

cc @dr.sybren

Nathan Vegdahl self-assigned this 2023-11-27 10:49:48 +01:00

Nathan Vegdahl referenced a pull request that will close this issue

2023-11-27 14:42:36 +01:00

Fix #115434: custom bone colors invisible in stick mode #115477

Nathan Vegdahl referenced this issue from a commit

2023-11-28 18:04:21 +01:00

Fix #115434: custom bone colors invisible in stick mode

Nathan Vegdahl closed this issue

2023-11-28 18:04:22 +01:00