Hair Dynamics: entering particle edit mode with baked cache crashes blender #59583
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#59583
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows 10 64-Bit
Graphics card: Nvidia GeForce GTX 1080Ti
Blender Version
Broken:
cef41d0144
Short description of error
Switching to particle edit mode on an object with baked hair dynamics crashes blender. I'm not sure when or why you'd actually want to do that, but it shouldn't cause a crash.
Exact steps for others to reproduce the error
Open the provided .blend file and switch to particle edit mode. Otherwise you can recreate the MWE:
mwe.blend
Added subscriber: @rjg
#62948 was marked as duplicate of this issue
Added subscribers: @dfelinto, @ZedDB
Backtrace:
@dfelinto I think you worked with the caching system before? If not, feel free to reassign.
Added subscriber: @Sergey
Not really, and @Sergey is the one who worked the most on particles in 2.80. Anyways, later this week I can dig further and try to pinpoint the issue or even fix it.
Added subscribers: @gabe2252, @grosgood, @nacioss
Particle edit mode on object with baked hair dynamics crashes blenderto Hair Dynamics: entering particle edit mode with baked cache crashes blenderAdded subscribers: @lichtwerk, @brecht
@lichtwerk
TL;DR:
A minor oversight, methinks, but please consider updating
e02ecd599b
to cover the possibility of ##edit->psys## being NULL, which can be the case. Perhaps use the standard sanity check common in the immediate vicinity of this code path:T59583_fix.txt
Too Long To Read Stuff:
@brecht addressed the underlying cause of the stack dump reported by @ZedDB on 12-December-2018 with
5ac7675f4c
on 16-April-2019 to address #62849, fixing this bug as well - an unnoticed duplicate, I gather - so missing the occasion to close this bug along with that.Alas, in addressing #70259, trust was placed in the 24x7 existence of a ##ParticleSystem *## pointer, giving rise to this new, improved backtrace:
T59583_backtrace.txt
You see, no doubt, that this suggestion is more expedient than inventive, just to prevent the OS from sending a SIGSEGV lightning bolt our way - which hurts and upsets people. With this suggestion in play, the user can enter a particle editing session and do ... what? I don't know. Every guide hair is baked, frozen, invisible. There is nothing sensible to do in ParticleEdit for baked hair particles here in the 2.8x series AFAIK. Have to delete the bake first.
In any case, if this suggestion plays out, perhaps this bug can be closed now for real.
Even More Too Long To Read Stuff Because It's Ancient History
You may recall that in the 2.79 era, entering a particle edit session with a baked hair did not lead to a dead end. In that era, entering a particle edit session with baked hair allowed one to edit the hair key time histories instead.
Shades of Marcel Duchamp's Nude Descending a Staircase . The path that a hair key travels through time can itself be treated as a "hair", using the same editing tools. Why would anyone want to rewrite the history of a hair key? Well - why not?!? One could make a hair thrash around in really cool, geeky ways. Alas, the 2.8xx absence of editing the baked time series of hair keys was noted in #53780. I bring this up because the Fade Time checkbox allowed one to "fade away" the time series after so many frames from the initial animation - necessary, because it doesn't take too many keys before an absolute sphagetti mess of key histories shows up. This, I think, is the context that makes Fade Time sensible in the case of hair editing.
Very much appreciate your efforts in cleaning up this ancient hair particle code and keeping it stumbling along, more or less, until the Brand New Particle System Arrives!!! Take care.
Addenda
All of this with respect to Blender 2.82 (sub 1) (hash
19c44ae087
built 2019-11-11 11:37:09)solohair_T59583.blend
Triggers #59583 in its current form.
Can confirm the new advent of the issue caused by unthoughtfully letting
e02ecd599b
act on non-existing psys.[ and even dropping a comment there that is debatable :) ]
Appreciate your efforts in tracking down the stumbling blocks here!
note we are still entering the assert realm, even if we fix the above (but this is an old friend, we've seen it in #62893, #64843 -- so this is on another page...)
Removed subscriber: @nacioss
Added subscriber: @zeauro
Yes. Confirm that ##assert()## with a debug build. The assert has it's heart in the right place. There is nothing actually in the line of baked hair particles to edit in 2.8x. Ideally, in the presence of baked hair dynamics, I shouldn't even have the ParticleEdit mode available to me. It should stay off the menu until such time as the bake has been dropped. (but that is more than a few lines fix). I think in #53780 @zeauro raised a good point: neat, geeky trick aside, how useful is it to edit particle key histories? Eh - not sure on that one.
This issue was referenced by
75f82d28e3
Changed status from 'Confirmed' to: 'Resolved'
The idea was to have an extra tweaking step to polish things.
It was really complicated to understand what will be the result for hair. But for emitter particles that could be rendered as growing paths : it was relevant.
It looks like entering Particle Edit mode is no more crashing. But if somebody goes into Options panel, Viewport Display subpanel and click on Particles option, there is still a crash.
It would probably be more frank to remove ability to enter into Particle Edit mode of a baked system.
Anyways, there is currently nothing visible, nothing to work on. There is no reason to let access to the mode, if feature is not supported.