Outliner: Remap Users spawns multiple dialogs on top of each other #93814

Open
opened 2021-12-07 14:12:15 +01:00 by Philipp Oeser · 10 comments
Member

System Information
Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.34.9000 64 Bits
Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 495.44

Blender Version
Broken: version: 3.1.0 Alpha, 3.5
Worked: never

Short description of error
Outliner: Remap Users spawns multiple dialogs on top of each other

Exact steps for others to reproduce the error
from the default startup file:

  • Right-click on the mesh label
  • Select Remap User
  • Two dialogs will open at once [on top of each other, you can drag one away from the other on the header]:
    remap-users-crash-2.png
    (this is because Sync selection option is enabled by default -- this will automatically select the Cube object as well)
  • for even more dialogs, box select the camera and light as well in the outliner and repeate above steps

Same is true for e.g. Rename, if multiple iDs are selected it will rename one after the other.

Question is: how should this behave (interactive operations on multiple selected IDs)?
For the Rename example, this might even make some sense, the spawning of multiple dialogs on top of each seems really wrong though.
(possibly these operations should only happen for the item under the cursor?)

(This was originally reported in #93799 (Outliner: Remap Users crash (for ID Type Object)), but split out as its own report)

**System Information** Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.34.9000 64 Bits Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 495.44 **Blender Version** Broken: version: 3.1.0 Alpha, 3.5 Worked: never **Short description of error** Outliner: Remap Users spawns multiple dialogs on top of each other **Exact steps for others to reproduce the error** from the default startup file: - Right-click on the **mesh label** - Select `Remap User` - Two dialogs will open at once [on top of each other, you can drag one away from the other on the header]: ![remap-users-crash-2.png](https://archive.blender.org/developer/F12703713/remap-users-crash-2.png) (this is because Sync selection option is enabled by default -- this will automatically select the Cube **object** as well) - for even more dialogs, box select the camera and light as well in the outliner and repeate above steps Same is true for e.g. `Rename`, if multiple iDs are selected it will rename one after the other. Question is: how should this behave (interactive operations on multiple selected IDs)? For the `Rename` example, this might even make some sense, the spawning of multiple dialogs on top of each seems really wrong though. (possibly these operations should only happen for the item under the cursor?) (This was originally reported in #93799 (Outliner: Remap Users crash (for `ID Type` `Object`)), but split out as its own report)
Author
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

This issue was referenced by 7c9e409985

This issue was referenced by 7c9e4099854a4fc8eab4db97173c1aacd25f9e08
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

This works to some extent in 2.83 because sync selection is not selecting the parent object

This works to some extent in 2.83 because `sync selection` is not selecting the parent object
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:22:39 +01:00
Member

Maybe we should only operate this operator for active tree element?
Another thing we could do is to not select parent/base element when context menu is invoked.

Maybe we should only operate this operator for active tree element? Another thing we could do is to not select parent/base element when context menu is invoked.
Pratik Borhade self-assigned this 2023-09-26 14:21:30 +02:00
Member

Another thing we could do is to not select parent/base element when context menu is invoked.

Think deselecting parent/base is incorrect solution. Doing this will break the selection status: when all objects are selected and context menu is invoked.

Maybe we should only operate this operator for active tree element

This may make sense but I'm not sure what UI developers think about it.
@pablovazquez ^

> Another thing we could do is to not select parent/base element when context menu is invoked. Think deselecting parent/base is incorrect solution. Doing this will break the selection status: when all objects are selected and context menu is invoked. > Maybe we should only operate this operator for active tree element This may make sense but I'm not sure what UI developers think about it. @pablovazquez ^
Member

Maybe we should only operate this operator for active tree element

This is what is usually expected, for commands to work on the active item.

> Maybe we should only operate this operator for active tree element This is what is usually expected, for commands to work on the active item.
Author
Member

Another way to solve this would be a single operator acting on the whole selection in the Outliner, but do we even have something in context that would enable us to iterate over everything selected in the Outliner?

Another way to solve this would be a **single** operator acting on the whole selection in the Outliner, but do we even have something in context that would enable us to iterate over everything selected in the Outliner?
Member

Had this thought yesterday. Will have to see how we could improve this (need to skip id_remap_fn() and just use OUTLINER_OT_id_remap)

but do we even have something in context that would enable us to iterate over everything selected in the Outliner?

We can get outliner space from CTX_wm_space_outliner(C) then have to iterate over the entire tree space_outliner->tree

Had this thought yesterday. Will have to see how we could improve this (need to skip `id_remap_fn()` and just use `OUTLINER_OT_id_remap`) > but do we even have something in context that would enable us to iterate over everything selected in the Outliner? We can get outliner space from `CTX_wm_space_outliner(C)` then have to iterate over the entire tree `space_outliner->tree`
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#93814
No description provided.