Fix #104383: Don't update declaration for clipboard copy #104432

Merged
Jacques Lucke merged 9 commits from mod_moder/blender:fix_104383 into main 2023-02-09 19:20:41 +01:00

After the 7208938707 the usual checks for the
existence of the declaration started to update
it if necessary. This should not happen when
copying a node to a tree that does not exist.

After the 7208938707 the usual checks for the existence of the declaration started to update it if necessary. This should not happen when copying a node to a tree that does not exist.
Iliya Katushenock added 1 commit 2023-02-07 20:33:13 +01:00
Iliya Katushenock requested review from Jacques Lucke 2023-02-07 20:33:28 +01:00
Hans Goudey changed title from FIx 104383: Don't update declaration for clipboard copy to Fix #104383: Don't update declaration for clipboard copy 2023-02-07 20:40:14 +01:00
Iliya Katushenock added 1 commit 2023-02-07 20:47:44 +01:00
Iliya Katushenock added 2 commits 2023-02-07 20:53:13 +01:00
Iliya Katushenock added 1 commit 2023-02-07 20:55:44 +01:00
Iliya Katushenock added 16 commits 2023-02-09 18:00:12 +01:00
Fix: Experimental Panel links modified for Gitea
All checks were successful
buildbot/vdev-code-daily-coordinator Build done.
41ddd3d732
Modifies the links to point to the new developer site.

Pull Request #104425
Release: support generating LTS release notes from Gitea
All checks were successful
buildbot/vdev-code-daily-coordinator Build done.
e817cff009
Now a single script to generate both links and release notes. It also includes
the issue ID for the LTS releases, so only the release version needs to be
specified.

Pull Request #104402
To allow further mesh data structure refactoring. See #103343

Pull Request #104436
Fix #104297: Cycling geometry nodes viewer ignores sockets
All checks were successful
buildbot/vdev-code-daily-coordinator Build done.
5c994d7846
Sockets after the geometry socket were ignored when cycling through
the node's output sockets. If there are multiple geometry sockets, the
behavior could still be refined probably, but this should at least make
basic non-geometry socket cycling work.
Cleanup: format
All checks were successful
buildbot/vdev-code-daily-coordinator Build done.
6aa1b5d031
The ear clipping method used by polyfill_2d only excluded concave ears
which meant ears exactly co-linear edges created zero area triangles
even when convex ears are available.

While polyfill_2d prioritizes performance over *pretty* results,
there is no need to pick degenerate triangles with other candidates
are available. As noted in code-comments, callers that require higher
quality tessellation should use BLI_polyfill_beautify.
Cleanup: use enum literals, order likely case first in polyfill_2d
All checks were successful
buildbot/vdev-code-daily-coordinator Build done.
d781e52ee0
Subdivision Surface: fix a serious performance hit when mixing CPU & GPU.
All checks were successful
buildbot/vdev-code-daily-coordinator Build done.
4d3bfb3f41
Subdivision surface efficiency relies on caching pre-computed topology
data for evaluation between frames. However, while eed45d2a23
introduced a second GPU subdiv evaluator type, it still only kept
one slot for caching this runtime data per mesh.

The result is that if the mesh is also needed on CPU, for instance
due to a modifier on a different object (e.g. shrinkwrap), the two
evaluators are used at the same time and fight over the single slot.
This causes the topology data to be discarded and recomputed twice
per frame.

Since avoiding duplicate evaluation is a complex task, this fix
simply adds a second separate cache slot for the GPU data, so that
the cost is simply running subdivision twice, not recomputing topology
twice.

To help diagnostics, I also add a message to show when GPU evaluation
is actually used to the modifier panel. Two frame counters are used
to suppress flicker in the UI panel.

Differential Revision: https://developer.blender.org/D17117

Pull Request #104441
Fix references to the main branch in the .gitmodules
All checks were successful
buildbot/vdev-code-daily-coordinator Build done.
4ed8a360e9
Un-ignore modules in .gitmodules configuration
All checks were successful
buildbot/vdev-code-daily-coordinator Build done.
aab707ab70
The meaning of the ignore option for submodules did change since our
initial Git setup was done: back then it was affecting both diff and
stage families of Git command. Unfortunately, the actual behavior did
violate what documentation was stating (the documentation was stating
that the option only affects diff family of commands). This got fixed
in Git some time after our initial setup and it was the behavior of the
commands changed, not the documentation. This lead to a situation when
we can no longer see that submodules are modified and staged, and it is
very easy to stage the submodules.

For the clarity: diff and status are both "status" family, show and
diff are "diff" family.

Hence this change: since there is no built-in zero-configuration way
of forbidding Git from staging submodules lets make it visible and
clear what the state of submodules is.

We still need to inform people to not stage submodules, for which
we can offer some configuration tips and scripts but doing so is
outside of the scope of this change at it requires some additional
research. Current goal is simple: make it visible and clear what is
going to be committed to Git.

This is a response to an increased frequency of incidents when the
submodules are getting modified and committed without authors even
noticing this (which is also a bit annoying to recover from).

Differential Revision: https://developer.blender.org/D13001
Make update: Ignore submodules
All checks were successful
buildbot/vdev-code-daily-coordinator Build done.
43f308f216
The previous change in the .gitmodules made it so the `make update`
rejects to do its thing because it now sees changes in the submodules
and rejected to update, thinking there are unstaged changes.

Ignore the submodule changes, bringing the old behavior closer to
what it was.
Fix Cycles debug build error after host falback changes
Some checks failed
buildbot/vdev-code-daily-coordinator Build done.
a1282ab015
Introduced in dcfb6df9ce6.

Co-authored-by: Lucas Tadeu Teixeira <lucas@lucastadeu.com>

Pull Request #104454
delete unrelated changes
Some checks failed
buildbot/vexp-code-patch-coordinator Build done.
89a778846d
Jacques Lucke approved these changes 2023-02-09 19:18:09 +01:00
Jacques Lucke merged commit 2cfc4d7644 into main 2023-02-09 19:20:41 +01:00
Iliya Katushenock deleted branch fix_104383 2023-02-09 19:23:16 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104432
No description provided.