Fix #104383: Don't update declaration for clipboard copy #104432

Iliya Katushenock · 2023-02-07T20:33:12+01:00

Iliya Katushenock commented

2023-02-07 20:33:12 +01:00

After the 7208938707 the usual checks for the
existence of the declaration started to update
it if necessary. This should not happen when
copying a node to a tree that does not exist.

After the 7208938707 the usual checks for the existence of the declaration started to update it if necessary. This should not happen when copying a node to a tree that does not exist.

Iliya Katushenock added 1 commit 2023-02-07 20:33:13 +01:00

/ d68b81687c

Iliya Katushenock requested review from Jacques Lucke 2023-02-07 20:33:28 +01:00

Hans Goudey changed title from ~~FIx 104383: Don't update declaration for clipboard copy~~ to Fix #104383: Don't update declaration for clipboard copy

2023-02-07 20:40:14 +01:00

Iliya Katushenock added 1 commit 2023-02-07 20:47:44 +01:00

test 7f48fbb00c

Iliya Katushenock added 2 commits 2023-02-07 20:53:13 +01:00

/ afe64c34e8

/ 8e3bd0376a

Iliya Katushenock added 1 commit 2023-02-07 20:55:44 +01:00

/ d36df2bc14

Iliya Katushenock added 16 commits 2023-02-09 18:00:12 +01:00

Fix: Experimental Panel links modified for Gitea

buildbot/vdev-code-daily-coordinator Build done.

Details

41ddd3d732

Modifies the links to point to the new developer site.

Pull Request #104425

Release: support generating LTS release notes from Gitea

buildbot/vdev-code-daily-coordinator Build done.

Details

e817cff009

Now a single script to generate both links and release notes. It also includes
the issue ID for the LTS releases, so only the release version needs to be
specified.

Pull Request #104402

Cleanup: Move 18 sculpt files to C++ 53b057aa09

To allow further mesh data structure refactoring. See #103343

Pull Request #104436

Fix #104297 : Cycling geometry nodes viewer ignores sockets

buildbot/vdev-code-daily-coordinator Build done.

Details

5c994d7846

Sockets after the geometry socket were ignored when cycling through
the node's output sockets. If there are multiple geometry sockets, the
behavior could still be refined probably, but this should at least make
basic non-geometry socket cycling work.

Cleanup: format

buildbot/vdev-code-daily-coordinator Build done.

Details

6aa1b5d031

Fix #103913 : Triangulate sometimes creates degenerate triangles 09eb4fe19a

The ear clipping method used by polyfill_2d only excluded concave ears
which meant ears exactly co-linear edges created zero area triangles
even when convex ears are available.

While polyfill_2d prioritizes performance over *pretty* results,
there is no need to pick degenerate triangles with other candidates
are available. As noted in code-comments, callers that require higher
quality tessellation should use BLI_polyfill_beautify.

Cleanup: use enum literals, order likely case first in polyfill_2d

buildbot/vdev-code-daily-coordinator Build done.

Details

d781e52ee0

Subdivision Surface: fix a serious performance hit when mixing CPU & GPU.

buildbot/vdev-code-daily-coordinator Build done.

Details

4d3bfb3f41

Subdivision surface efficiency relies on caching pre-computed topology
data for evaluation between frames. However, while eed45d2a23
introduced a second GPU subdiv evaluator type, it still only kept
one slot for caching this runtime data per mesh.

The result is that if the mesh is also needed on CPU, for instance
due to a modifier on a different object (e.g. shrinkwrap), the two
evaluators are used at the same time and fight over the single slot.
This causes the topology data to be discarded and recomputed twice
per frame.

Since avoiding duplicate evaluation is a complex task, this fix
simply adds a second separate cache slot for the GPU data, so that
the cost is simply running subdivision twice, not recomputing topology
twice.

To help diagnostics, I also add a message to show when GPU evaluation
is actually used to the modifier panel. Two frame counters are used
to suppress flicker in the UI panel.

Differential Revision: https://developer.blender.org/D17117

Pull Request #104441

Fix references to the main branch in the .gitmodules

buildbot/vdev-code-daily-coordinator Build done.

Details

4ed8a360e9

Un-ignore modules in .gitmodules configuration

buildbot/vdev-code-daily-coordinator Build done.

Details

aab707ab70

The meaning of the ignore option for submodules did change since our
initial Git setup was done: back then it was affecting both diff and
stage families of Git command. Unfortunately, the actual behavior did
violate what documentation was stating (the documentation was stating
that the option only affects diff family of commands). This got fixed
in Git some time after our initial setup and it was the behavior of the
commands changed, not the documentation. This lead to a situation when
we can no longer see that submodules are modified and staged, and it is
very easy to stage the submodules.

For the clarity: diff and status are both "status" family, show and
diff are "diff" family.

Hence this change: since there is no built-in zero-configuration way
of forbidding Git from staging submodules lets make it visible and
clear what the state of submodules is.

We still need to inform people to not stage submodules, for which
we can offer some configuration tips and scripts but doing so is
outside of the scope of this change at it requires some additional
research. Current goal is simple: make it visible and clear what is
going to be committed to Git.

This is a response to an increased frequency of incidents when the
submodules are getting modified and committed without authors even
noticing this (which is also a bit annoying to recover from).

Differential Revision: https://developer.blender.org/D13001

Make update: Ignore submodules

buildbot/vdev-code-daily-coordinator Build done.

Details

43f308f216

The previous change in the .gitmodules made it so the `make update`
rejects to do its thing because it now sees changes in the submodules
and rejected to update, thinking there are unstaged changes.

Ignore the submodule changes, bringing the old behavior closer to
what it was.

Fix Cycles debug build error after host falback changes

buildbot/vdev-code-daily-coordinator Build done.

Details

a1282ab015

Introduced in dcfb6df9ce6.

Co-authored-by: Lucas Tadeu Teixeira <lucas@lucastadeu.com>

Pull Request #104454

changes based on comments d198dfefc5

undo changes in wrong branch 033b4c871b

erge main bd3cb20410

delete unrelated changes

buildbot/vexp-code-patch-coordinator Build done.

Details

89a778846d

Jacques Lucke approved these changes 2023-02-09 19:18:09 +01:00

Jacques Lucke merged commit 2cfc4d7644 into main

2023-02-09 19:20:41 +01:00

Jacques Lucke referenced this issue from a commit

2023-02-09 19:20:43 +01:00

Fix #104383: don't update declaration for clipboard copy

Iliya Katushenock deleted branch fix_104383

2023-02-09 19:23:16 +01:00

Joseph Eagar referenced this issue from a commit

2023-02-11 21:53:09 +01:00

Fix #104383: don't update declaration for clipboard copy

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #104383: Don't update declaration for clipboard copy #104432