blender
/
blender
136
406
Fork 588
Code Issues 6.2k Pull Requests 754 Projects 19 Wiki Activity

UI: add camera passepartout color to theme #104486

Merged
Brecht Van Lommel merged 1 commits from pioverfour/blender:dp_theme_passepartout_color_D15461 into main 2023-02-13 09:15:44 +01:00
Conversation 3 Commits 1 Files Changed 6 +13 -2
Damien Picard commented 2023-02-08 22:33:41 +01:00
Member
Copy Link

Currently the passepartout color is hardcoded to black. While a
sensible default for cinema, it may make less sense for other media,
whether video, print, web, etc. It greatly affects viewing conditions
of the image and should be user-selectable, much like painting
programs allow.

Suggested by scopelma on Right-Click Select.
https://blender.community/c/rightclickselect/4z41/

Review started in https://archive.blender.org/developer/D15461.

Currently the passepartout color is hardcoded to black. While a sensible default for cinema, it may make less sense for other media, whether video, print, web, etc. It greatly affects viewing conditions of the image and should be user-selectable, much like painting programs allow. Suggested by scopelma on Right-Click Select. https://blender.community/c/rightclickselect/4z41/ ----- Review started in https://archive.blender.org/developer/D15461.
❤️ 3
Colin Basnett commented 2023-02-08 22:46:47 +01:00
Member
Copy Link

This is great, my only suggestion would be to change the name from Camera Passepartout to Camera Passepartout Color to be more specific (this also includes the variable names.)

This is great, my only suggestion would be to change the name from `Camera Passepartout` to `Camera Passepartout Color` to be more specific (this also includes the variable names.)
Damien Picard commented 2023-02-08 22:54:26 +01:00
Author
Member
Copy Link

This is great, my only suggestion would be to change the name from Camera Passepartout to Camera Passepartout Color to be more specific (this also includes the variable names.)

Right, but this doesn’t seem to be the convention in the variable names for themes, and there is little ambiguity in the context I think. Even less so in the UI:

image

> This is great, my only suggestion would be to change the name from `Camera Passepartout` to `Camera Passepartout Color` to be more specific (this also includes the variable names.) Right, but this doesn’t seem to be the convention in the variable names for themes, and there is little ambiguity in the context I think. Even less so in the UI: ![image](/attachments/e75ec18d-438c-4f83-bb50-cceec738b9fd)
image.png
16 KiB
👍 1
Brecht Van Lommel requested changes 2023-02-09 02:10:16 +01:00
source/blender/draw/intern/draw_common_shader_shared.h
@ -33,6 +33,7 @@ struct GlobalsUboStorage {
float4 color_speaker;
float4 color_camera;
float4 color_camera_path;
float4 color_camera_passepartout;
Brecht Van Lommel commented 2023-02-09 02:10:06 +01:00
Owner
Copy Link

Both changes in this file are unnecessary and can be left out (and if they were needed they would be missing a change in draw_common.c).

Both changes in this file are unnecessary and can be left out (and if they were needed they would be missing a change in `draw_common.c`).
pioverfour marked this conversation as resolved
Hans Goudey reviewed 2023-02-09 03:16:15 +01:00
source/blender/makesdna/DNA_userdef_types.h
@ -355,3 +355,3 @@
unsigned char path_keyframe_before[4], path_keyframe_after[4];
unsigned char camera_path[4];
unsigned char _pad1[6];
unsigned char camera_passepartout[4];
Hans Goudey commented 2023-02-09 03:16:15 +01:00
Member
Copy Link

Isn't an array size of 3 here okay, since there's no alpha and the RNA property is only 3 items?

Isn't an array size of 3 here okay, since there's no alpha and the RNA property is only 3 items?
Brecht Van Lommel commented 2023-02-09 16:07:03 +01:00
Owner
Copy Link

All the theme colors have 4. Did not check if it's strictly required but we should stay consistent regardless.

All the theme colors have 4. Did not check if it's strictly required but we should stay consistent regardless.
Brecht Van Lommel changed title from Add passepartout color to theme to UI: add camera passepartout color to theme 2023-02-09 12:42:02 +01:00
Damien Picard force-pushed dp_theme_passepartout_color_D15461 from fd519f8150 to de3dd19b14 2023-02-09 19:12:12 +01:00 Compare
Damien Picard force-pushed dp_theme_passepartout_color_D15461 from de3dd19b14 to d8751f5d40 2023-02-09 19:12:54 +01:00 Compare
Damien Picard requested review from Brecht Van Lommel 2023-02-09 19:15:42 +01:00
Brecht Van Lommel commented 2023-02-09 19:16:46 +01:00
Owner
Copy Link

@blender-bot build

@blender-bot build
Brecht Van Lommel approved these changes 2023-02-09 19:16:53 +01:00
Brecht Van Lommel merged commit 2e19aa1399 into main 2023-02-13 09:15:44 +01:00
Brecht Van Lommel deleted branch dp_theme_passepartout_color_D15461 2023-02-13 09:15:45 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Brecht Van Lommel
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104486
No description provided.
Delete Branch "pioverfour/blender:dp_theme_passepartout_color_D15461"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?