blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 767 Projects 19 Wiki Activity

WIP: GPencil - Reorganize Animation Insert and Delete menu and shortcuts. #104509

Closed
Antonio Vazquez wants to merge 5 commits from antoniov:temp-insert-menu into main
pull from: antoniov:temp-insert-menu
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 6 Commits 5 Files Changed 5 +34 -22
Antonio Vazquez commented 2023-02-09 12:59:56 +01:00
Member
Copy Link

Actually there are some inconsistencies between the shortcuts used in Meshes and Grease pencil for Insert menu and Delete menu.

The proposal is include in Insert menu (I key) only insert options.

image

The menu include the Duplicate options because they are "Insert Duplications". Maybe we could change the menu option text.

For Delete menu, replace X key for the standard Alt+I key.

image

Draw->Animation menu now shows the submenus to make more consistent the UI and display shortcuts.

image

Actually there are some inconsistencies between the shortcuts used in Meshes and Grease pencil for Insert menu and Delete menu. The proposal is include in Insert menu (I key) only insert options. ![image](/attachments/ba15115c-782e-495e-a2ae-630c47223f5c) The menu include the Duplicate options because they are "Insert Duplications". Maybe we could change the menu option text. For Delete menu, replace X key for the standard Alt+I key. ![image](/attachments/2191dbf8-1e7f-42e7-914f-baed87514822) Draw->Animation menu now shows the submenus to make more consistent the UI and display shortcuts. ![image](/attachments/0f29ed61-2961-4df7-b813-fdd659d95d6e)
image.png
101 KiB
image.png
58 KiB
image.png
36 KiB
Antonio Vazquez added 1 commit 2023-02-09 12:59:58 +01:00
Antonio Vazquez requested review from Pablo Vazquez 2023-02-09 13:00:57 +01:00
Antonio Vazquez requested review from Matias Mendiola 2023-02-09 13:01:05 +01:00
Antonio Vazquez self-assigned this 2023-02-09 13:01:19 +01:00
Antonio Vazquez added the
Module
Grease Pencil
 label 2023-02-09 13:01:33 +01:00
Antonio Vazquez added this to the Grease Pencil project 2023-02-09 15:33:04 +01:00
Matias Mendiola requested changes 2023-02-11 21:35:55 +01:00
Matias Mendiola left a comment
Member
Copy Link
  • ALT-I is not working in Edit Mode
  • Include the word Keyword in menu titles: "Insert Keyframe" - "Delete Keyframe" (see mockups below)
  • I and ALT-I shortcuts are not shown on the Animation menu, instead we still see (and still is working) the actual Shift I and Shift X shortcut. Maybe we can only show on the individual Insert and delete menus?
  • The animation menu is missing the "Clear Keyframes..." menu to remove all animation data. Would be great to include that for consistency.

image

* ***ALT-I*** is not working in Edit Mode * Include the word Keyword in menu titles: "Insert Keyframe" - "Delete Keyframe" (see mockups below) * ***I*** and ***ALT-I*** shortcuts are not shown on the Animation menu, instead we still see (and still is working) the actual ***Shift I*** and ***Shift X*** shortcut. Maybe we can only show on the individual Insert and delete menus? * The animation menu is missing the "Clear Keyframes..." menu to remove all animation data. Would be great to include that for consistency. ![image](/attachments/f0d61c1b-a3cb-4977-aac1-66296f424543)
image.png
37 KiB
Antonio Vazquez added 2 commits 2023-02-13 10:48:28 +01:00
Antonio Vazquez commented 2023-02-13 10:50:16 +01:00
Author
Member
Copy Link

About Clear Keyframes option, this operator is a generic Blender operator and actually does not support Grease Pencil. In order to make it work, the operator need to be fixed and this must be do in a separated PR.

About `Clear Keyframes` option, this operator is a generic Blender operator and actually does not support Grease Pencil. In order to make it work, the operator need to be fixed and this must be do in a separated PR.
Antonio Vazquez commented 2023-02-13 10:52:10 +01:00
Author
Member
Copy Link

About the short keys displayed in the menu, the I and Alt+I shortcuts are to display the menu, but each option of the menu can use its own shortcut, this is the reason you see different shortcuts for some options. We cannot use same shortcut for the menu and the operator itself because in this case Blender cannot decide what is the context to use it.

About the short keys displayed in the menu, the `I` and `Alt+I` shortcuts are to display the menu, but each option of the menu can use its own shortcut, this is the reason you see different shortcuts for some options. We cannot use same shortcut for the menu and the operator itself because in this case Blender cannot decide what is the context to use it.
Matias Mendiola commented 2023-02-13 13:54:53 +01:00
Member
Copy Link

I know, what I mean is that is best for discoverability and consistency to show I and ALT+I shortcuts in animation menu instead the individual ones. Is that possible?

I know, what I mean is that is best for discoverability and consistency to show `I` and `ALT+I` shortcuts in animation menu instead the individual ones. Is that possible?
Matias Mendiola commented 2023-02-15 19:25:13 +01:00
Member
Copy Link

I propose for consistency and discoverability to follow how it works in the Object animation menu:

image

I propose for consistency and discoverability to follow how it works in the Object animation menu: ![image](/attachments/f2c126b3-bdc9-4271-b759-ffbd46c2c604)
image.png
29 KiB
Antonio Vazquez added 1 commit 2023-02-16 11:11:39 +01:00
Matias Mendiola commented 2023-02-16 15:47:37 +01:00
Member
Copy Link

Thanks @antoniov for the changes.

  • 3 level of nested menu is not needed, just keep the first one (Insert Keyframe... - Delete Keyframe...)

image

  • Delete Active Keyframe (Active layer) appears greyout

image

Thanks @antoniov for the changes. * 3 level of nested menu is not needed, just keep the first one (Insert Keyframe... - Delete Keyframe...) ![image](/attachments/04d2ede4-ceee-4f41-a3c6-0ad8d47f3dfb) * Delete Active Keyframe (Active layer) appears greyout ![image](/attachments/0f62baf4-35c6-4e01-8b74-bf299ca6e792)
image.png
42 KiB
image.png
15 KiB
Antonio Vazquez added 1 commit 2023-02-16 16:30:29 +01:00
a311d918bc Change poll function to don't check strokes 
The operator can be active if no strokes
Antonio Vazquez commented 2023-03-21 15:23:20 +01:00
Author
Member
Copy Link

This will be redesign in GP 3.0

This will be redesign in GP 3.0
Antonio Vazquez closed this pull request 2023-03-21 15:23:21 +01:00
Antonio Vazquez removed this from the Grease Pencil project 2023-03-21 16:04:42 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Matias Mendiola
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Antonio Vazquez
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104509
No description provided.
Delete Branch "antoniov:temp-insert-menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?