Animation: Paste Keys in Graph Editor with value offset #104512
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#104512
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "ChrisLend/blender:copy_paste_frame_range"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Extend the
GRAPH_OT_paste
operator with an enum to define the value offset.Options are:
video demo
Nice work as always :)
Just a few minor things.
@ -1138,0 +1140,4 @@
bezt->vec[0][1] += offset[1];
bezt->vec[1][1] += offset[1];
bezt->vec[2][1] += offset[1];
I think this would be clearer as:
Same below with
sub_v2_v2()
@ -1191,0 +1231,4 @@
bAnimListElem *ale,
const eKeyPasteValueOffset value_offset_mode)
{
float offset;
Instead of having a variable
offset
, and having to track how it's changed in the code below, IMO it's better to just replace thiswith
With this change, you don't even need the top-level variable
float offset
any more. If you want to keep a variable between the calculation and thereturn
(can aid in debugging the code), use aconst float offset = ...
constant scoped to thecase
statement instead. Or justreturn sipo->cursorVal - aci->bezt[0].vec[1][1];
if you don't need the extra variable.@ -1191,0 +1257,4 @@
}
case KEYFRAME_PASTE_VALUE_OFFSET_NONE:
default:
You can remove the
default:
, that way the compiler can complain when a new value was added to the enum, but not handled here.Just two tiny things
Oh and some submodule changes snuck back in, be sure to revert them.
👍