Animation: Move Graph Editor settings to User Preferences #104532

Move two settings that were previously in the "View" menu of the Graph Editor into User Preferences.

It has been mentioned in the meeting by Luciano Muñoz Sessarego that it would be good to move that to the preferences so you can set it once and then forget about it.

The Settings moved are:

Only Selected Curve Keyframes
Use High Quality Display

before

after

archived phabricator patch

https://archive.blender.org/developer/D17126

Move two settings that were previously in the "View" menu of the Graph Editor into User Preferences. It has been mentioned in the meeting by Luciano Muñoz Sessarego that it would be good to move that to the preferences so you can set it once and then forget about it. The Settings moved are: Only Selected Curve Keyframes Use High Quality Display before ![before](https://projects.blender.org/attachments/7e6837b9-c1fd-4529-aa1a-014c852402de) after ![image](/attachments/ce1f6a1f-496a-44a8-9d07-59b7a3e8040a) ----- archived phabricator patch https://archive.blender.org/developer/D17126

asd.png

74 KiB

image.png

67 KiB

The code LGTM. I'll defer the final verdict to @LucianoMunoz (or some other animator if they want to step in).

Hey thanks for trying to address this issue,

The thing is you only need to move the "only selected curve keyframes" to the preferences and keep "only selected keyframe handles" in the original menu.
Here is why the first one is a permanent option that users either like or not on a forever basis, as in way of working, while the latter is more of a sporadic option that users will want to turn on and off depending on what their doing in the moment just like turning on and off a particular curve.

On the other hand "use high quality display" is an other good candidate to move to preferences as per the same reasons.

Hope that makes sense.

Hey thanks for trying to address this issue, The thing is you only need to move the "only selected curve keyframes" to the preferences and keep "only selected keyframe handles" in the original menu. Here is why the first one is a permanent option that users either like or not on a forever basis, as in way of working, while the latter is more of a sporadic option that users will want to turn on and off depending on what their doing in the moment just like turning on and off a particular curve. On the other hand "use high quality display" is an other good candidate to move to preferences as per the same reasons. Hope that makes sense.

The Settings moved are:

Only Selected Curve Keyframes

There's a bit of leftover plural in the title & description. Those can be left as-is, when we follow @Looch 's suggestion to also move "use high quality display" to the preferences.

> The Settings moved are: > > Only Selected Curve Keyframes There's a bit of leftover plural in the title & description. Those can be left as-is, when we follow @Looch 's suggestion to also move "use high quality display" to the preferences.

@dr.sybren I also moved high quality drawing into user prefs in this PR

It should be enabled by default, but I am unsure if that is working. I can reset it to default which enables it. But starting my Blender it is always disabled.
I am not sure if that is just because i've been developing and it is now saved as off, or if new user properties are always off

@dr.sybren I also moved high quality drawing into user prefs in this PR It should be enabled by default, but I am unsure if that is working. I can reset it to default which enables it. But starting my Blender it is always disabled. I am not sure if that is just because i've been developing and it is now saved as off, or if new user properties are always off

You're almost there. The last step is to add versioning code for the user preferences. The thing is that new properties apparently don't get set to the default value automatically. This needs a bit of code in blo_do_versions_userdef(), in versioning_userdef.c.

The defaults are used when you start Blender with --factory-startup, though, so they need to be set anyway.

You're almost there. The last step is to add versioning code for the user preferences. The thing is that new properties apparently don't get set to the default value automatically. This needs a bit of code in `blo_do_versions_userdef()`, in `versioning_userdef.c`. The defaults are used when you start Blender with `--factory-startup`, though, so they need to be set anyway.

I've added the versioning code, assuming it goes into the curly braces at the bottom

I've added the versioning code, assuming it goes into the curly braces at the bottom

Yup, that's where it goes until there is a sub-version bump. In this case we have to do that bump, since there is no other way. Sometimes you can use DNA_struct_elem_find() to see if the struct already a specific field when it was saved or not. Since this doesn't add any new fields, that's not something we can do, so the only way is to bump. Before you land the PR:

increase BLENDER_FILE_SUBVERSION by one, and
wrap userdef->animation_flag |= USER_ANIM_HIGH_QUALITY_DRAWING; with an if (!USER_VERSION_ATLEAST(306, 2)) { and move it above that "new stuff goes here" block.

> I've added the versioning code, assuming it goes into the curly braces at the bottom Yup, that's where it goes until there is a sub-version bump. In this case we have to do that bump, since there is no other way. Sometimes you can use `DNA_struct_elem_find()` to see if the struct already a specific field when it was saved or not. Since this doesn't add any new fields, that's not something we can do, so the only way is to bump. Before you land the PR: - increase `BLENDER_FILE_SUBVERSION` by one, and - wrap `userdef->animation_flag |= USER_ANIM_HIGH_QUALITY_DRAWING;` with an `if (!USER_VERSION_ATLEAST(306, 2)) {` and move it above that "new stuff goes here" block.

@dr.sybren can you have a quick look over the versioning code to check if I did the changes correctly

Yeah that looks good!

 @ -5173,0 +5183,4 @@
   prop = RNA_def_property(srna, "fcurve_high_quality_drawing", PROP_BOOLEAN, PROP_NONE);
   RNA_def_property_boolean_sdna(prop, NULL, "animation_flag", USER_ANIM_HIGH_QUALITY_DRAWING);
   RNA_def_property_ui_text(prop,
                            "FCurve High Quality Display",

Labels Milestones

Animation: Move Graph Editor settings to User Preferences #104532

Reviewers

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Labels Milestones

Animation: Move Graph Editor settings to User Preferences #104532

Reviewers