Grease Pencil: Set Layers' 'Use Lights' Default to False #104550

Kevin C. Burke · 2023-02-10T01:20:09+01:00

Kevin C. Burke commented

2023-02-10 01:20:09 +01:00

The default ‘Use Lights’ setting for new Layers is unwanted by and confusing to many Grease Pencil users. Since Grease Pencil is used primarily for non-photorealistic rendering, the assumption should be for the user to get the lines and fill colors they draw on render: then to add realistic lighting to it if desired. For new users, the colors are darker than drawn because ‘Use Lights’ is enabled by default which is very confusing.

https://blender.community/c/rightclickselect/qrhbbc/
https://blender.stackexchange.com/q/230073/81083

This patch disables ‘Use Lights’ by default so that experienced Grease Pencil users may enable this setting on a per-layer basis when desired. Also capitalizes Grease Pencil in the Use Light's description.

The default ‘Use Lights’ setting for new Layers is unwanted by and confusing to many Grease Pencil users. Since Grease Pencil is used primarily for non-photorealistic rendering, the assumption should be for the user to get the lines and fill colors they draw on render: then to add realistic lighting to it if desired. For new users, the colors are darker than drawn because ‘Use Lights’ is enabled by default which is very confusing. https://blender.community/c/rightclickselect/qrhbbc/ https://blender.stackexchange.com/q/230073/81083 This patch disables ‘Use Lights’ by default so that experienced Grease Pencil users may enable this setting on a per-layer basis when desired. Also capitalizes Grease Pencil in the Use Light's description.

👍 1

Kevin C. Burke added 1 commit 2023-02-10 01:20:11 +01:00

01df017094 Grease Pencil: Set Layers' 'Use Lights' Default to False

The default ‘Use Lights’ setting for new Layers is unwanted by and confusing to many Grease Pencil users. Since Grease Pencil is used primarily for non-photorealistic rendering, the assumption should be for the user to get the lines and fill colors they draw: then to add realistic lighting to it if desired. For new users, the colors are darker than drawn because ‘Use Lights’ is enabled by default which is very confusing.

https://blender.community/c/rightclickselect/qrhbbc/
https://blender.stackexchange.com/q/230073/81083

This patch disables ‘Use Lights’ by default so that experienced Grease Pencil users may enable this setting on a per-layer basis when desired.

Kevin C. Burke changed title from ~~Grease Pencil: Set Layers' 'Use Lights' Default to False~~ to WIP: Grease Pencil: Set Layers' 'Use Lights' Default to False

2023-02-10 01:26:17 +01:00

Kevin C. Burke requested review from Antonio Vazquez 2023-02-10 01:28:09 +01:00

Kevin C. Burke changed title from ~~WIP: Grease Pencil: Set Layers' 'Use Lights' Default to False~~ to Grease Pencil: Set Layers' 'Use Lights' Default to False

2023-02-10 01:28:52 +01:00

Kevin C. Burke added 1 commit 2023-02-10 01:39:19 +01:00

b38f8a5701 Merge branch 'main' into main

Andres Stephens commented

2023-02-10 05:22:46 +01:00

Good call.

❤️ 1

Antonio Vazquez commented

2023-02-10 13:33:30 +01:00

This change needs a review by the GPTeam because it changes a main setting. @mendio @pepe-school-land What do you think? IIRC we decided to set this as true because the point is try to "integrate" GPencil object more in Blender, so by default all objects react to lights and in the future Eevee Next, will cast shadows too. Actually, all 3D objects cast shadows by default, so if you want disable it, you must set manually...I think we followed same logic here.

Antonio Vazquez requested review from Matias Mendiola 2023-02-10 13:33:41 +01:00

Antonio Vazquez requested review from Daniel Martinez Lara 2023-02-10 13:33:50 +01:00

Antonio Vazquez added the

Module

Grease Pencil

label 2023-02-10 13:35:59 +01:00

Antonio Vazquez added this to the Grease Pencil project 2023-02-10 13:36:07 +01:00

Kevin C. Burke added 8 commits 2023-02-20 19:15:30 +01:00

0c0fbc7871 Merge branch 'main' of projects.blender.org:blender/blender

cb2b72987a Merge branch 'main' of projects.blender.org:blender/blender

67b1bd41ae Merge branch 'main' of projects.blender.org:blender/blender

f09a3f78ae Merge branch 'main' of projects.blender.org:blender/blender

2dd2a31834 Merge branch 'main' of projects.blender.org:blender/blender

e65597a9d1 Merge branch 'main' of projects.blender.org:blender/blender

5f98f46947 Merge branch 'main' of projects.blender.org:blender/blender

770505efa0 Merge branch 'main' of projects.blender.org:KevinCBurke/blender

Kevin C. Burke added 1 commit 2023-02-20 19:17:58 +01:00

ec8191d9cf Add Grease Pencil Layer Context Menu to Dopesheet Channel Context Menu

The Grease Pencil Layer Context Menu is currently located inconveniently in the user interface. When wanting to select and act on specific layers, the context menu makes the most sense in the Dopesheet Channel Context Menu: it is closest to the layers and also the most obvious location to a user.

Antonio Vazquez commented

2023-02-20 20:09:05 +01:00

@KevinCBurke You have committed a change to main without Module approval and this must not be done. Any change in the module code needs to be reviewed and if it's a change in the UI, then @mendio or any other UI member need to review it.

@mendio can you confirm this change in the menu is correct in the Dopesheet? if you don't agree, we can revert it.

@KevinCBurke You have committed a change to `main` without Module approval and this **must not be done**. Any change in the module code needs to be reviewed and if it's a change in the UI, then @mendio or any other UI member need to review it. @mendio can you confirm this change in the menu is correct in the Dopesheet? if you don't agree, we can revert it.

Kevin C. Burke commented

2023-02-20 20:40:26 +01:00

@KevinCBurke You have committed a change to main without Module approval and this must not be done. Any change in the module code needs to be reviewed and if it's a change in the UI, then @mendio or any other UI member need to review it.

@mendio can you confirm this change in the menu is correct in the Dopesheet? if you don't agree, we can revert it.

Hi @antoniov , sorry, that was a mistake and not an effort to get past module approval. I am still learning how to use Git properly and am often confused with it. Sorry for any errors on my part!

> @KevinCBurke You have committed a change to `main` without Module approval and this **must not be done**. Any change in the module code needs to be reviewed and if it's a change in the UI, then @mendio or any other UI member need to review it. > > @mendio can you confirm this change in the menu is correct in the Dopesheet? if you don't agree, we can revert it. > Hi @antoniov , sorry, that was a mistake and not an effort to get past module approval. I am still learning how to use Git properly and am often confused with it. Sorry for any errors on my part!

Matias Mendiola commented

2023-02-20 20:48:25 +01:00

We are still discussing this with core Grease Pencil team, please revert the change in the meanwhile

Kevin C. Burke added 1 commit 2023-02-20 21:07:18 +01:00

adcf748d45 Revert "Add Grease Pencil Layer Context Menu to Dopesheet Channel Context Menu"