Curves: add Curve Parameter Falloff to comb brush #104589
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#104589
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "JacquesLucke/blender:curve-parameter-falloff"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This adds a new
Curve Falloff
popover to the comb brush tool settings. The curve control allows changing the brush weight along the curve to e.g. affect the tip more than the root. This is a relative way to get something like stiffness for short hair.This functionality could potentially be added to some other brushes, but the comb brush is the most important one, so that is added first.
I did add the buttons add the buttons to choose a curve map preset. However, I did not add the preset dropdown, because that just adds some unnecessary complexity in the code now and is redundant.
Thanks for the patch, this is going to be a great step up for now, I think!
Falloff
should now probably be renamed toBrush Falloff
to make the distinction clear.Smooth
curve as an even more extreme falloff. Trying a shape like that out with no particular use-case feels quite good and seems to help a lot to not rely on surface collision too much.Speaking of performance, it would be nice if this was behind a boolean option so it can be explicitly turned off. That should be the default too, IMO.
UI-wise, this could go in the same "Falloff" popover, using a popover for every curve template isn't very scalable IMO.
This indeed feels much better, even just a linear falloff is a big improvement! :)
I could see this being useful for
smooth
,pinch
andpuff
as well.Yes, that could be added.
You guessed right.
I don't have a strong opinion for where this setting should go exactly, what the default should be and which brushes should have it. If you three can come to a compromise, that would be great.
WIP: Curves: add Curve Parameter Falloff to comb brushto Curves: add Curve Parameter Falloff to comb brushIn my opinion this is good to go!
I know that Andy was not sure about the default setting. I'll add him as a reviewer, to me this can go either way. I personally think the way it is now is good.
I can't request Andy's review, but apparently instead requested review of the entire universe. So I'll just tag you here, @eyecandy
The code looks reasonable.
What I was referring to earlier when I mentioned presets was this here, which can avoid the curvemapping evaluation when one of the presets are selected (one of the default presets could be the default too).
Don't want to hold this up and require that, just mentioning it though, in case it seems reasonable to you too.
@ -147,2 +150,4 @@
self_->constraint_solver_.initialize(
*curves_orig_, curve_selection_, curves_id_orig_->flag & CV_SCULPT_COLLISION_ENABLED);
self_->curve_lengths_.reinitialize(curves_orig_->points_num());
points_num
->curves_num
, right?looks good! I suggest to use a linear curve as the default since it could more intuitively convey the mapping of the curve (left is root, right is tip) this way.
Without any visual cues like that it's a big hard to grasp what it does (that's also why I'm not a big fan of the presets).
While I agree with the general idea of skipping the curve mapping evaluation, I don't think the right approach is to use a preset system that lives outside of the curve map. We could investigate building these presets into curve mappings though. The curve should probably still always be visible, but in many cases it could also be much smaller and doesn't have to be quadratic. For efficient evaluation we could still detect common cases and implement special evaluation functions for those.
At some point we probably also want to display a curve map in a socket, then the UI has to be simplified more as well.
Lukas Tönne referenced this pull request2023-03-13 18:01:17 +01:00