WIP: UI: Save Temp Window Sizes & Positions #104727

Harley Acheson · 2023-02-14T05:03:03+01:00

Harley Acheson commented

2023-02-14 05:03:03 +01:00

Allow temporary windows (like File Browser, Preferences, Render,
Drivers, Info) to open at their last positions and sizes.

UserDef gets a new kind of struct to contain a temp window's position and size. A new WM_window_open_temp takes a pointer to one of these as a parameter and automatically saves and restores on close and open.

Positions are saved in unscaled values (as if the UI scale is 1.0), using the DPI scale of the parent window. Using unscaled values means that if you increase the UI scale the temp window sizes are suitably scaled as well. Using the DPI of the parent is required to position them correctly in complex situations like having multiple monitors that differ in OS scale.

Note this currently only saves and restores the size and position of the Preferences and File Browser windows. But this design could easily work for other windows after it is confirmed (or fixed) to work on Mac and Linux.

Allow temporary windows (like File Browser, Preferences, Render, Drivers, Info) to open at their last positions and sizes. --- UserDef gets a new kind of struct to contain a temp window's position and size. A new `WM_window_open_temp` takes a pointer to one of these as a parameter and automatically saves and restores on close and open. Positions are saved in unscaled values (as if the UI scale is 1.0), using the DPI scale of the parent window. Using unscaled values means that if you increase the UI scale the temp window sizes are suitably scaled as well. Using the DPI of the parent is required to position them correctly in complex situations like having multiple monitors that differ in OS scale. Note this **currently only saves and restores the size and position of the Preferences and File Browser windows**. But this design could easily work for other windows after it is confirmed (or fixed) to work on Mac and Linux.

🎉 3

Harley Acheson force-pushed WindowPosSize from 9ef8eac91d to 82675a6d04

2023-02-16 04:03:16 +01:00

Compare

Harley Acheson force-pushed WindowPosSize from 82675a6d04 to f2e4f60631

2023-12-15 03:23:56 +01:00

Compare

Harley Acheson added this to the User Interface project 2023-12-15 03:25:56 +01:00

Harley Acheson commented

2023-12-15 17:32:39 +01:00

@rajveermalviya

Is any way you can take a look at this? This should just automatically save and restore the last sizes and positions of the Preferences window. But the last I heard some of these are incorrect on Mac with Retina displays.

We do measuring a bit wrong on high-dpi though, so this will just come down to a bad or missing use of GHOST_GetNativePixelSize

@rajveermalviya Is any way you can take a look at this? This should just automatically save and restore the last sizes and positions of the Preferences window. But the last I heard some of these are incorrect on Mac with Retina displays. We do measuring a bit wrong on high-dpi though, so this will just come down to a bad or missing use of GHOST_GetNativePixelSize

Rajesh Malviya commented

2023-12-18 07:05:35 +01:00

I tried this impl on my macbook and found that window positions and window sizes are being preserved correctly on laptop display.

But (for me) absolute positioning in general is broken on extended displays. I even tested with current main but that didn't change anything. Is there a bug already for it? (couldn't find one)

I tried this impl on my macbook and found that window positions and window sizes are being preserved correctly on laptop display. But (for me) absolute positioning in general is broken on extended displays. I even tested with current `main` but that didn't change anything. Is there a bug already for it? (couldn't find one)

Harley Acheson commented

2023-12-18 22:24:14 +01:00

I tried this impl on my macbook and found that window positions and window sizes are being preserved correctly on laptop display.

Oh so it works to set and restore the size and position on the built-in monitor. Those are all Retina right, so high-dpi? That would be a good sign that the PR is probably doing everything correctly.

But (for me) absolute positioning in general is broken on extended displays. I even tested with current main but that didn't change anything.

So you are saying that positioning on multiple displays is incorrect in main? I'm not surprised as that seems to be incomplete on Mac.

On Windows I can start with defaults. Then choose Window/ New Window and move the resulting window anywhere to any of my monitors. I can do this to make and arrangement of windows all over the place. Then I can select File / Defaults / Save Startup File. I can close and launch Blender again - everything will be back to where they were to the pixel.

If this isn't working on Mac we might have to identify exactly which parts aren't working correctly. Its not that hard to figure out to be honest. Window creation is all done in wm_window.c, and by examining what happens when windows are made we might find that we are missing some ghost functions. Like wm_get_desktopsize could be getting the wrong values.

Is there a bug already for it? (couldn't find one)

I doubt it. But knowing what works on Windows, it would make sense to create a bug report for the missing/broken behavior on Mac.

> I tried this impl on my macbook and found that window positions and window sizes are being preserved correctly on laptop display. Oh so it works to set and restore the size and position on the built-in monitor. Those are all Retina right, so high-dpi? That would be a good sign that the PR is probably doing everything correctly. > But (for me) absolute positioning in general is broken on extended displays. I even tested with current `main` but that didn't change anything. So you are saying that positioning on multiple displays is incorrect in main? I'm not surprised as that seems to be incomplete on Mac. On Windows I can start with defaults. Then choose Window/ New Window and move the resulting window anywhere to any of my monitors. I can do this to make and arrangement of windows all over the place. Then I can select File / Defaults / Save Startup File. I can close and launch Blender again - everything will be back to where they were to the pixel. If this isn't working on Mac we might have to identify exactly which parts aren't working correctly. Its not that hard to figure out to be honest. Window creation is all done in wm_window.c, and by examining what happens when windows are made we might find that we are missing some ghost functions. Like wm_get_desktopsize could be getting the wrong values. > Is there a bug already for it? (couldn't find one) I doubt it. But knowing what works on Windows, it would make sense to create a bug report for the missing/broken behavior on Mac.

Harley Acheson added 1 commit 2023-12-30 21:03:35 +01:00

1f6a9b3b70 Merge branch 'main' of projects.blender.org:blender/blender into WindowPosSize

This pull request has changes conflicting with the target branch.

source/blender/windowmanager/intern/wm_window.cc

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u WindowPosSize:Harley-WindowPosSize

git checkout Harley-WindowPosSize

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: UI: Save Temp Window Sizes & Positions #104727

Checkout