blender/blender
165
518
Fork 791
Code Issues 6.8k Pull Requests 942 Projects 21 Wiki Activity

WIP: Build: increase minimum CMake version to 3.20 #104774

Closed
Brecht Van Lommel wants to merge 1 commits from brecht/blender:cmake-3.20 into main
pull from: brecht/blender:cmake-3.20
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 1 Files Changed 1 +1 -1
Brecht Van Lommel commented 2023-02-15 10:36:38 +01:00
Owner
Copy Link

The old CMake version in CentOS 7 was what was holding this back, now go to the
version available on Rocky 8.

Ref #102440

The old CMake version in CentOS 7 was what was holding this back, now go to the version available on Rocky 8. Ref #102440
Brecht Van Lommel commented 2023-02-15 10:38:25 +01:00
Author
Owner
Copy Link

There's likely some cleanups that can be done. This is just a simple bump to verify it's available on all the workers.
@blender-bot build

There's likely some cleanups that can be done. This is just a simple bump to verify it's available on all the workers. @blender-bot build
Brecht Van Lommel changed title from WIP: Build: increase minimum CMake version to 3.20 to Build: increase minimum CMake version to 3.20 2023-02-22 00:54:21 +01:00
Brecht Van Lommel changed title from Build: increase minimum CMake version to 3.20 to WIP: Build: increase minimum CMake version to 3.20 2023-02-22 01:18:44 +01:00
Brecht Van Lommel changed title from WIP: Build: increase minimum CMake version to 3.20 to Build: increase minimum CMake version to 3.20 2023-02-22 01:21:09 +01:00
Brecht Van Lommel changed target branch from main to blender-v3.5-release 2023-02-22 01:23:49 +01:00
Brecht Van Lommel changed target branch from blender-v3.5-release to main 2023-02-22 01:25:00 +01:00
Brecht Van Lommel changed title from Build: increase minimum CMake version to 3.20 to WIP: Build: increase minimum CMake version to 3.20 2023-02-22 01:40:25 +01:00
Blender Bot requested review from Blender Bot 2023-06-19 12:02:59 +02:00
Blender Bot refused to review 2023-06-19 12:03:05 +02:00
Blender Bot requested review from Pratik Borhade 2023-06-19 12:03:42 +02:00
Brecht Van Lommel removed review request for Pratik Borhade 2023-06-19 12:04:07 +02:00
Brecht Van Lommel force-pushed cmake-3.20 from 296737967e to 15bb01510e 2023-08-16 16:50:20 +02:00 Compare
Brecht Van Lommel commented 2023-08-16 16:59:04 +02:00
Author
Owner
Copy Link

@blender-bot build

@blender-bot build
Brecht Van Lommel commented 2023-08-16 17:06:32 +02:00
Author
Owner
Copy Link

@ideasman42 since 206f126, building with cmake 3.10 is broken due to the use of cmake_language, which was introduced in cmake 3.18.

We might as well bump the cmake minimum, but I haven't had time yet to:

  • Check if any new cmake_policy needs to be added since bumping the version changes default behavior.
  • Check if there is any cmake code we can simplify after upgrading.

I won't have time to finish this in the next two weeks due to holidays. Feel free to pick this up, but I also don't think it's that urgent to fix this.

@ideasman42 since 206f126, building with cmake 3.10 is broken due to the use of `cmake_language`, which was introduced in cmake 3.18. We might as well bump the cmake minimum, but I haven't had time yet to: * Check if any new `cmake_policy` needs to be added since bumping the version changes default behavior. * Check if there is any cmake code we can simplify after upgrading. I won't have time to finish this in the next two weeks due to holidays. Feel free to pick this up, but I also don't think it's that urgent to fix this.
All checks were successful
buildbot/vexp-code-patch-coordinator Build done.
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Asset System

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104774
No description provided.
Delete Branch "brecht/blender:cmake-3.20"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?