Fix missing macOS version check in Cycles for the blas encoder #105014

Sergey Sharybin · 2023-02-21T11:26:12+01:00

Sergey Sharybin commented

2023-02-21 11:26:12 +01:00

The creation of blas was not covered with the version check, but
the usage was.

So should not be anything visible by artists, but this silences
the warning about non-available-checked resource creation.

The creation of blas was not covered with the version check, but the usage was. So should not be anything visible by artists, but this silences the warning about non-available-checked resource creation.

Sergey Sharybin added the

labels 2023-02-21 11:26:13 +01:00

Sergey Sharybin added 1 commit 2023-02-21 11:26:24 +01:00

79841e6f25 Fix missing macOS version check in Cycles for the blas encoder

The creation of blas was not covered with the version check, but
the usage was.

So should not be anything visible by artists, but this silences
the warning about non-available-checked resource creation.

Sergey Sharybin added this to the Render & Cycles project 2023-02-21 11:26:30 +01:00

Sergey Sharybin requested review from Brecht Van Lommel 2023-02-21 11:26:34 +01:00

Brecht Van Lommel commented

2023-02-21 11:36:42 +01:00

I have #104976 for this, I think the additional if (use_metalrt) check is also needed.

I have #104976 for this, I think the additional `if (use_metalrt)` check is also needed.

Sergey Sharybin commented

2023-02-21 11:42:41 +01:00

Please assign or inform people who reported the problem when you're actually working on the issue. I do not see how one could have guessed that there is a PR with no label/project/reviewers, and no follow-up in the chat message either.

Sergey Sharybin closed this pull request

2023-02-21 11:42:42 +01:00

Sergey Sharybin deleted branch cycles_metal_blas

2023-02-21 11:42:48 +01:00

Brecht Van Lommel commented

2023-02-21 11:51:24 +01:00

Sorry, this message in chat was meant to communicate that I would do it, but perhaps was unclear.

@Sergey not sure if it causes issues in practice but should get fixed, will do

Sorry, this message in chat was meant to communicate that I would do it, but perhaps was unclear. ``` @Sergey not sure if it causes issues in practice but should get fixed, will do ```

Sergey Sharybin commented

2023-02-21 12:03:55 +01:00

Which did not give any indication of a time frame: could have happened yesterday, could have been planned at some later bcon3 level.

There are more issues on the same exact hardware/OS configuration which needs to be looked into. Having something that potentially have affect on those issues and clearly manifests itself s first thing you do. Making things to happen is easier than to rely on a promise with an unknown timeline.

Communication is important and it does not take that much time to tag someone in the web UI.

Which did not give any indication of a time frame: could have happened yesterday, could have been planned at some later bcon3 level. There are more issues on the same exact hardware/OS configuration which needs to be looked into. Having something that potentially have affect on those issues and clearly manifests itself s first thing you do. Making things to happen is easier than to rely on a promise with an unknown timeline. Communication is important and it does not take that much time to tag someone in the web UI.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix missing macOS version check in Cycles for the blas encoder #105014

Pull request closed