UI: Add color selector to Bone Groups list #105036

Merged
Pablo Vazquez merged 1 commits from pablovazquez/blender:ui-bone-group-list-colors into main 2023-02-22 17:34:56 +01:00
Member

Expose the color selector on each item in the list, providing the following benefits:

  • See at a glance the color of each Bone Group.
  • Change color set directly from the list.
  • A more compact panel since the color pickers are only shown for custom color sets.

image

This was brought up while talking to @Hjalti at Blender Studio.

Expose the color selector on each item in the list, providing the following benefits: * See at a glance the color of each Bone Group. * Change color set directly from the list. * A more compact panel since the color pickers are only shown for custom color sets. ![image](/attachments/d5bfbf57-8125-4806-8f5d-dba175c41da6) This was brought up while talking to @Hjalti at Blender Studio.
Pablo Vazquez added the
Module
User Interface
label 2023-02-21 17:59:07 +01:00
Pablo Vazquez changed title from UI: Add color selector to Bone Groups list to WIP: UI: Add color selector to Bone Groups list 2023-02-21 18:00:32 +01:00
Pablo Vazquez changed title from WIP: UI: Add color selector to Bone Groups list to UI: Add color selector to Bone Groups list 2023-02-21 18:00:54 +01:00
Pablo Vazquez requested review from Sybren A. Stüvel 2023-02-21 18:10:45 +01:00
Pablo Vazquez requested review from Julian Eisel 2023-02-21 18:10:45 +01:00
Julian Eisel approved these changes 2023-02-22 16:17:10 +01:00
Julian Eisel left a comment
Member

No strong opinion on my end. If you think this is better, fine with me. It is an unusual pattern though I think, with the menu inside the list items.

No strong opinion on my end. If you think this is better, fine with me. It is an unusual pattern though I think, with the menu inside the list items.
@ -92,2 +92,4 @@
class DATA_UL_bone_groups(UIList):
def draw_item(self, _context, layout, _data, item, icon, _active_data, _active_propname, _index):
Member

icon here is unused I think, so should be _icon.

`icon` here is unused I think, so should be `_icon`.
pablovazquez marked this conversation as resolved
Pablo Vazquez force-pushed ui-bone-group-list-colors from 6d0459ebff to 270c03b948 2023-02-22 16:45:32 +01:00 Compare
Pablo Vazquez force-pushed ui-bone-group-list-colors from 270c03b948 to 98bbfab5e1 2023-02-22 16:52:17 +01:00 Compare
Author
Member

It is an unusual pattern though I think, with the menu inside the list items.

Thanks for the review!

It is unusual indeed, I don't think we use this elsewhere and I don't think we should start adding it all over the place unless there's great benefit like in here.

Ideally we would have a way to display the custom colors in there as well, but so far I think this is way better than having to click on each bone group to see which color_set it uses.

> It is an unusual pattern though I think, with the menu inside the list items. Thanks for the review! It is unusual indeed, I don't think we use this elsewhere and I don't think we should start adding it all over the place unless there's great benefit like in here. Ideally we would have a way to display the custom colors in there as well, but so far I think this is way better than having to click on each bone group to see which color_set it uses.
Pablo Vazquez removed review request for Sybren A. Stüvel 2023-02-22 16:56:41 +01:00
Pablo Vazquez force-pushed ui-bone-group-list-colors from 98bbfab5e1 to d2da8aebae 2023-02-22 17:06:35 +01:00 Compare
Pablo Vazquez merged commit cbb4f8a9ba into main 2023-02-22 17:34:56 +01:00
Pablo Vazquez deleted branch ui-bone-group-list-colors 2023-02-22 17:34:57 +01:00
Sybren A. Stüvel approved these changes 2023-02-24 12:32:00 +01:00
Sybren A. Stüvel left a comment
Member

Thanks!

Thanks!
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105036
No description provided.