Curves: Add edit mode operator to set attribute values #105076

Merged
Hans Goudey merged 9 commits from HooglyBoogly/blender:curves-attribute-set into main 2023-10-17 12:35:50 +02:00
Member

Similar to #104426, this adds a simple operator to set attribute values
for curves edit mode. The operator is very basic and is only meant to
be a first step for more attribute editing features.

Some of the RNA property registration, retrieval, and setting is reused
from the mesh edit mode operator. The rest of the logic is similar but
harder to de-duplicate.

Similar to #104426, this adds a simple operator to set attribute values for curves edit mode. The operator is very basic and is only meant to be a first step for more attribute editing features. Some of the RNA property registration, retrieval, and setting is reused from the mesh edit mode operator. The rest of the logic is similar but harder to de-duplicate.
Hans Goudey added the
Interest
Modeling
Interest
Geometry Nodes
Module
Nodes & Physics
labels 2023-02-22 15:06:07 +01:00
Hans Goudey added 3 commits 2023-02-22 15:06:19 +01:00
Hans Goudey requested review from Jacques Lucke 2023-02-22 15:06:37 +01:00
Hans Goudey requested review from Simon Thommes 2023-02-22 15:06:38 +01:00
Hans Goudey added this to the Nodes & Physics project 2023-02-22 15:06:42 +01:00
Jacques Lucke approved these changes 2023-02-22 16:30:45 +01:00
Jacques Lucke left a comment
Member

Code looks reasonable and the operator works as expected in my test.

Code looks reasonable and the operator works as expected in my test.
Simon Thommes requested changes 2023-02-22 19:51:18 +01:00
Simon Thommes left a comment
Member
  • Looks to me that the preset value is the total of the selection, rather than the average
    image
    setting and recalling the menu with the same selection gives this issue
- Looks to me that the preset value is the total of the selection, rather than the average ![image](/attachments/62605b06-eb5b-40e9-b7f5-b01d39bc72e0) setting and recalling the menu with the same selection gives this issue
209 KiB
Hans Goudey added 2 commits 2023-02-22 23:50:57 +01:00
Jacques Lucke requested review from Simon Thommes 2023-02-23 12:54:43 +01:00
Simon Thommes requested changes 2023-03-06 17:40:09 +01:00
Simon Thommes left a comment
Member

Another thing I noticed:

  • when just some of the points of a curve are selected and the operator is run on a spline domain attribute, it still allows you to set the attribute for the curve, even if just one point is selected (that part is fine with me), but the prefilled value defaults to 0 rather than the actual value of the curve

Other than that it seems fine to me.

Another thing I noticed: - when just some of the points of a curve are selected and the operator is run on a spline domain attribute, it still allows you to set the attribute for the curve, even if just one point is selected (that part is fine with me), but the prefilled value defaults to 0 rather than the actual value of the curve Other than that it seems fine to me.
Hans Goudey added 2 commits 2023-03-07 18:24:28 +01:00
Author
Member

From blender.chat: I'm noticing that the boolean domain interpolation in two areas of our code disagree:

  • In retrieve_selected_curves (used for finding which curves to affect for some brushes in sculpt mode, etc), the interpolation is "curve is selected if any point is selected"
  • In adapt_domain (generic domain interpolation), the interpolation is "curve is selected if all points are selected"

This will probably keep coming up in the future if we don't make them consistent, but it's a bit tricky. It would be easier (possible) to change the former to match the behavior of the latter, since the behavior isn't baked into files. That's what I'd do I think.

In other words, I can't/shouldn't really fix that without unifying the above issue.

From blender.chat: I'm noticing that the boolean domain interpolation in two areas of our code disagree: - In `retrieve_selected_curves` (used for finding which curves to affect for some brushes in sculpt mode, etc), the interpolation is "curve is selected if any point is selected" - In `adapt_domain` (generic domain interpolation), the interpolation is "curve is selected if all points are selected" This will probably keep coming up in the future if we don't make them consistent, but it's a bit tricky. It would be easier (possible) to change the former to match the behavior of the latter, since the behavior isn't baked into files. That's what I'd do I think. In other words, I can't/shouldn't really fix that without unifying the above issue.
Member

To me it's not a huge problem that retrieve_selected_curves and adapt_domain don't have the same behavior. Different use cases can have different behavior. That said, I also wouldn't mind if retrieve_selected_curves is changed to match adapt_domain if that behavior feels good to Simon as well.

To me it's not a huge problem that `retrieve_selected_curves` and `adapt_domain` don't have the same behavior. Different use cases can have different behavior. That said, I also wouldn't mind if `retrieve_selected_curves` is changed to match `adapt_domain` if that behavior feels good to Simon as well.
Member

Hmm, I agree that this is an issue.

That said, I also wouldn't mind if retrieve_selected_curves is changed to match adapt_domain if that behavior feels good to Simon as well.

I don't think I have a good enough understanding on the implications. It would be good to have a better overview of which operations actually use these functions and which one that is.
I do feel like for the user, varying behavior depending on the use-case can be fine/preferable. But I see how it would be better to unify the behavior.

Hmm, I agree that this is an issue. > That said, I also wouldn't mind if retrieve_selected_curves is changed to match adapt_domain if that behavior feels good to Simon as well. I don't think I have a good enough understanding on the implications. It would be good to have a better overview of which operations actually use these functions and which one that is. I do feel like for the user, varying behavior depending on the use-case can be fine/preferable. But I see how it would be better to unify the behavior.
Hans Goudey added 2 commits 2023-10-17 09:51:12 +02:00
Hans Goudey requested review from Simon Thommes 2023-10-17 09:51:13 +02:00
Simon Thommes approved these changes 2023-10-17 12:17:12 +02:00
Simon Thommes left a comment
Member

looks good to me

looks good to me
Hans Goudey merged commit 31ec00895f into main 2023-10-17 12:35:50 +02:00
Hans Goudey deleted branch curves-attribute-set 2023-10-17 12:35:52 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105076
No description provided.