Curves: Add edit mode operator to set attribute values #105076
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#105076
Loading…
Reference in New Issue
No description provided.
Delete Branch "HooglyBoogly/blender:curves-attribute-set"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Similar to #104426, this adds a simple operator to set attribute values
for curves edit mode. The operator is very basic and is only meant to
be a first step for more attribute editing features.
Some of the RNA property registration, retrieval, and setting is reused
from the mesh edit mode operator. The rest of the logic is similar but
harder to de-duplicate.
Code looks reasonable and the operator works as expected in my test.
setting and recalling the menu with the same selection gives this issue
Another thing I noticed:
Other than that it seems fine to me.
From blender.chat: I'm noticing that the boolean domain interpolation in two areas of our code disagree:
retrieve_selected_curves
(used for finding which curves to affect for some brushes in sculpt mode, etc), the interpolation is "curve is selected if any point is selected"adapt_domain
(generic domain interpolation), the interpolation is "curve is selected if all points are selected"This will probably keep coming up in the future if we don't make them consistent, but it's a bit tricky. It would be easier (possible) to change the former to match the behavior of the latter, since the behavior isn't baked into files. That's what I'd do I think.
In other words, I can't/shouldn't really fix that without unifying the above issue.
To me it's not a huge problem that
retrieve_selected_curves
andadapt_domain
don't have the same behavior. Different use cases can have different behavior. That said, I also wouldn't mind ifretrieve_selected_curves
is changed to matchadapt_domain
if that behavior feels good to Simon as well.Hmm, I agree that this is an issue.
I don't think I have a good enough understanding on the implications. It would be good to have a better overview of which operations actually use these functions and which one that is.
I do feel like for the user, varying behavior depending on the use-case can be fine/preferable. But I see how it would be better to unify the behavior.
looks good to me