Curves: Add edit mode operator to set attribute values #105076

Similar to #104426, this adds a simple operator to set attribute values
for curves edit mode. The operator is very basic and is only meant to
be a first step for more attribute editing features.

Some of the RNA property registration, retrieval, and setting is reused
from the mesh edit mode operator. The rest of the logic is similar but
harder to de-duplicate.

Similar to #104426, this adds a simple operator to set attribute values for curves edit mode. The operator is very basic and is only meant to be a first step for more attribute editing features. Some of the RNA property registration, retrieval, and setting is reused from the mesh edit mode operator. The rest of the logic is similar but harder to de-duplicate.

Code looks reasonable and the operator works as expected in my test.

Looks to me that the preset value is the total of the selection, rather than the average

setting and recalling the menu with the same selection gives this issue

- Looks to me that the preset value is the total of the selection, rather than the average ![image](/attachments/62605b06-eb5b-40e9-b7f5-b01d39bc72e0) setting and recalling the menu with the same selection gives this issue

image.png

209 KiB

Another thing I noticed:

when just some of the points of a curve are selected and the operator is run on a spline domain attribute, it still allows you to set the attribute for the curve, even if just one point is selected (that part is fine with me), but the prefilled value defaults to 0 rather than the actual value of the curve

Other than that it seems fine to me.

Another thing I noticed: - when just some of the points of a curve are selected and the operator is run on a spline domain attribute, it still allows you to set the attribute for the curve, even if just one point is selected (that part is fine with me), but the prefilled value defaults to 0 rather than the actual value of the curve Other than that it seems fine to me.

From blender.chat: I'm noticing that the boolean domain interpolation in two areas of our code disagree:

In retrieve_selected_curves (used for finding which curves to affect for some brushes in sculpt mode, etc), the interpolation is "curve is selected if any point is selected"
In adapt_domain (generic domain interpolation), the interpolation is "curve is selected if all points are selected"

This will probably keep coming up in the future if we don't make them consistent, but it's a bit tricky. It would be easier (possible) to change the former to match the behavior of the latter, since the behavior isn't baked into files. That's what I'd do I think.

In other words, I can't/shouldn't really fix that without unifying the above issue.

From blender.chat: I'm noticing that the boolean domain interpolation in two areas of our code disagree: - In `retrieve_selected_curves` (used for finding which curves to affect for some brushes in sculpt mode, etc), the interpolation is "curve is selected if any point is selected" - In `adapt_domain` (generic domain interpolation), the interpolation is "curve is selected if all points are selected" This will probably keep coming up in the future if we don't make them consistent, but it's a bit tricky. It would be easier (possible) to change the former to match the behavior of the latter, since the behavior isn't baked into files. That's what I'd do I think. In other words, I can't/shouldn't really fix that without unifying the above issue.

To me it's not a huge problem that retrieve_selected_curves and adapt_domain don't have the same behavior. Different use cases can have different behavior. That said, I also wouldn't mind if retrieve_selected_curves is changed to match adapt_domain if that behavior feels good to Simon as well.

To me it's not a huge problem that `retrieve_selected_curves` and `adapt_domain` don't have the same behavior. Different use cases can have different behavior. That said, I also wouldn't mind if `retrieve_selected_curves` is changed to match `adapt_domain` if that behavior feels good to Simon as well.

Hmm, I agree that this is an issue.

That said, I also wouldn't mind if retrieve_selected_curves is changed to match adapt_domain if that behavior feels good to Simon as well.

I don't think I have a good enough understanding on the implications. It would be good to have a better overview of which operations actually use these functions and which one that is.
I do feel like for the user, varying behavior depending on the use-case can be fine/preferable. But I see how it would be better to unify the behavior.

Hmm, I agree that this is an issue. > That said, I also wouldn't mind if retrieve_selected_curves is changed to match adapt_domain if that behavior feels good to Simon as well. I don't think I have a good enough understanding on the implications. It would be good to have a better overview of which operations actually use these functions and which one that is. I do feel like for the user, varying behavior depending on the use-case can be fine/preferable. But I see how it would be better to unify the behavior.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Curves: Add edit mode operator to set attribute values #105076

Reviewers