Curves: Add edit mode operator to set attribute values #105076

Merged

Hans Goudey merged 9 commits from HooglyBoogly/blender:curves-attribute-set into main

2023-10-17 12:35:50 +02:00

Hans Goudey commented

2023-02-22 15:06:07 +01:00

Member

Similar to #104426, this adds a simple operator to set attribute values
for curves edit mode. The operator is very basic and is only meant to
be a first step for more attribute editing features.

Some of the RNA property registration, retrieval, and setting is reused
from the mesh edit mode operator. The rest of the logic is similar but
harder to de-duplicate.

Similar to #104426, this adds a simple operator to set attribute values for curves edit mode. The operator is very basic and is only meant to be a first step for more attribute editing features. Some of the RNA property registration, retrieval, and setting is reused from the mesh edit mode operator. The rest of the logic is similar but harder to de-duplicate.

Hans Goudey added the

Nodes & Physics

labels 2023-02-22 15:06:07 +01:00

Hans Goudey added 3 commits 2023-02-22 15:06:19 +01:00

6da6b28084 Curves: Add edit mode operator to set attribute values

Similar to the mesh edit mode operator with the same name

TODO: Validation, cleanup

c6ee428282 Merge branch 'main' into curves-attribute-set

0812374525 Add validation, add comments, small cleanup

Hans Goudey requested review from Jacques Lucke 2023-02-22 15:06:37 +01:00

Hans Goudey requested review from Simon Thommes 2023-02-22 15:06:38 +01:00

Hans Goudey added this to the Nodes & Physics project 2023-02-22 15:06:42 +01:00

Jacques Lucke approved these changes 2023-02-22 16:30:45 +01:00

Jacques Lucke left a comment

Member

Code looks reasonable and the operator works as expected in my test.

Code looks reasonable and the operator works as expected in my test.

Simon Thommes requested changes 2023-02-22 19:51:18 +01:00

Simon Thommes left a comment

Member

Looks to me that the preset value is the total of the selection, rather than the average

setting and recalling the menu with the same selection gives this issue

- Looks to me that the preset value is the total of the selection, rather than the average ![image](/attachments/62605b06-eb5b-40e9-b7f5-b01d39bc72e0) setting and recalling the menu with the same selection gives this issue

209 KiB

Hans Goudey added 2 commits 2023-02-22 23:50:57 +01:00

3c14f2c675 Merge branch 'main' into curves-attribute-set

ca2c7e2770 Fix mixing of existing values

Jacques Lucke requested review from Simon Thommes 2023-02-23 12:54:43 +01:00

Simon Thommes requested changes 2023-03-06 17:40:09 +01:00

Simon Thommes left a comment

Member

Another thing I noticed:

when just some of the points of a curve are selected and the operator is run on a spline domain attribute, it still allows you to set the attribute for the curve, even if just one point is selected (that part is fine with me), but the prefilled value defaults to 0 rather than the actual value of the curve

Other than that it seems fine to me.

Another thing I noticed: - when just some of the points of a curve are selected and the operator is run on a spline domain attribute, it still allows you to set the attribute for the curve, even if just one point is selected (that part is fine with me), but the prefilled value defaults to 0 rather than the actual value of the curve Other than that it seems fine to me.

Hans Goudey added 2 commits 2023-03-07 18:24:28 +01:00

f892970299 Merge branch 'main' into curves-attribute-set

134da4d97e Fix missing attribute finish() call

Hans Goudey commented

2023-03-18 02:50:00 +01:00

Author

Member

From blender.chat: I'm noticing that the boolean domain interpolation in two areas of our code disagree:

In retrieve_selected_curves (used for finding which curves to affect for some brushes in sculpt mode, etc), the interpolation is "curve is selected if any point is selected"
In adapt_domain (generic domain interpolation), the interpolation is "curve is selected if all points are selected"

This will probably keep coming up in the future if we don't make them consistent, but it's a bit tricky. It would be easier (possible) to change the former to match the behavior of the latter, since the behavior isn't baked into files. That's what I'd do I think.

In other words, I can't/shouldn't really fix that without unifying the above issue.

From blender.chat: I'm noticing that the boolean domain interpolation in two areas of our code disagree: - In `retrieve_selected_curves` (used for finding which curves to affect for some brushes in sculpt mode, etc), the interpolation is "curve is selected if any point is selected" - In `adapt_domain` (generic domain interpolation), the interpolation is "curve is selected if all points are selected" This will probably keep coming up in the future if we don't make them consistent, but it's a bit tricky. It would be easier (possible) to change the former to match the behavior of the latter, since the behavior isn't baked into files. That's what I'd do I think. In other words, I can't/shouldn't really fix that without unifying the above issue.

Jacques Lucke commented

2023-03-19 07:11:26 +01:00

Member

To me it's not a huge problem that retrieve_selected_curves and adapt_domain don't have the same behavior. Different use cases can have different behavior. That said, I also wouldn't mind if retrieve_selected_curves is changed to match adapt_domain if that behavior feels good to Simon as well.

To me it's not a huge problem that `retrieve_selected_curves` and `adapt_domain` don't have the same behavior. Different use cases can have different behavior. That said, I also wouldn't mind if `retrieve_selected_curves` is changed to match `adapt_domain` if that behavior feels good to Simon as well.

Simon Thommes commented

2023-03-20 11:20:02 +01:00

Member

Hmm, I agree that this is an issue.

That said, I also wouldn't mind if retrieve_selected_curves is changed to match adapt_domain if that behavior feels good to Simon as well.

I don't think I have a good enough understanding on the implications. It would be good to have a better overview of which operations actually use these functions and which one that is.
I do feel like for the user, varying behavior depending on the use-case can be fine/preferable. But I see how it would be better to unify the behavior.

Hmm, I agree that this is an issue. > That said, I also wouldn't mind if retrieve_selected_curves is changed to match adapt_domain if that behavior feels good to Simon as well. I don't think I have a good enough understanding on the implications. It would be good to have a better overview of which operations actually use these functions and which one that is. I do feel like for the user, varying behavior depending on the use-case can be fine/preferable. But I see how it would be better to unify the behavior.

Hans Goudey added 2 commits 2023-10-17 09:51:12 +02:00

6cca2638a2 Merge branch 'main' into curves-attribute-set

b78928438b Build fixes and retrieve average value with same selection interpolation

Hans Goudey requested review from Simon Thommes 2023-10-17 09:51:13 +02:00

Simon Thommes approved these changes 2023-10-17 12:17:12 +02:00

Simon Thommes left a comment

Member

looks good to me

looks good to me

Hans Goudey referenced this issue from a commit

2023-10-17 12:35:49 +02:00

Curves: Add edit mode operator to set attribute values

Hans Goudey merged commit 31ec00895f into main

2023-10-17 12:35:50 +02:00

Hans Goudey deleted branch curves-attribute-set

2023-10-17 12:35:52 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105076

No description provided.