Fix #104726: Allow loading of 2.48 file without active window #105225

Harley Acheson · 2023-02-26T20:38:06+01:00

Harley Acheson commented

2023-02-26 20:38:06 +01:00

Add check to WM_check for lack of wmWindowManager->winactive. Sets it
if there is a window and makes that one wmWindow->active as well.

#104726 includes files made in Blender 2.48 that crash on loading if loaded directly via commandline, but load correctly
via the UI. Blend files created prior to 2.5 do not have a wmWindowManager. It therefore has to be created in some way that makes sense for the rest of the file. In these files we get to WM_check with a valid wmWindowManager that has a single window in its windows list, but that window is not set valid. The null wmWindowManager->winactive gets sent along and we crash.

This PR just adds a check for this condition and sets the first window as wmWindowManager->winactive and also sets its wmWindow->active to true.

Add check to WM_check for lack of wmWindowManager->winactive. Sets it if there is a window and makes that one wmWindow->active as well. --- #104726 includes files made in Blender 2.48 that crash on loading if loaded directly via commandline, but load correctly via the UI. Blend files created prior to 2.5 do not have a wmWindowManager. It therefore has to be created in some way that makes sense for the rest of the file. In these files we get to `WM_check` with a valid wmWindowManager that has a single window in its windows list, but that window is not set valid. The null wmWindowManager->winactive gets sent along and we crash. This PR just adds a check for this condition and sets the first window as wmWindowManager->winactive and also sets its wmWindow->active to true.

Harley Acheson added 1 commit 2023-02-26 20:38:17 +01:00

Fix #104726 : Allow loading of 2.48 file without active window 1df9d99fc6

Add check to WM_check for lack of wmWindowManager->winactive. Sets one
if there is a window and makes that one wmWindow->active as well.

Harley Acheson requested review from Campbell Barton 2023-02-26 20:41:28 +01:00

Brecht Van Lommel approved these changes 2023-02-28 13:29:13 +01:00

Harley Acheson added 1 commit 2023-02-28 16:41:40 +01:00

Merge branch 'main' into Wm248

buildbot/vexp-code-patch-coordinator Build done.

Details

709ac49e1c

Harley Acheson commented

2023-02-28 16:42:19 +01:00

@blender-bot build

Harley Acheson merged commit 480e467ac9 into main

2023-02-28 17:08:41 +01:00

Harley Acheson deleted branch Wm248

2023-02-28 17:08:42 +01:00

Harley Acheson referenced this issue from a commit

2023-02-28 17:08:43 +01:00

Fix #104726: Allow loading of 2.48 file without active window

Harley Acheson referenced this pull request

2023-03-01 21:43:40 +01:00

Revert #105225: WM Check for lack of active window #105351

Harley Acheson referenced this issue from a commit

2023-03-01 21:44:53 +01:00

Revert #105225: WM Check for lack of active window

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #104726: Allow loading of 2.48 file without active window #105225