Spreadsheet: Add Volume grid's active voxel count #105515

Closed

Erik Abrahamsson wants to merge 1 commits from erik85/blender:ss-voxel-count into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Erik Abrahamsson commented

2023-03-07 01:21:39 +01:00

Member

Adds the count of active voxels to the spreadsheet editor.
This can be useful for example when debugging volume related problems
or to keep an eye on for performance reasons.

Adds the count of active voxels to the spreadsheet editor. This can be useful for example when debugging volume related problems or to keep an eye on for performance reasons. ![bild](/attachments/3a3d546e-0c7f-4681-b505-e4884bdba204)

311 KiB

Erik Abrahamsson added 1 commit 2023-03-07 01:21:49 +01:00

dda7824a43 Add Active Voxel Count to Spreadsheet

Erik Abrahamsson requested review from Hans Goudey 2023-03-07 01:23:54 +01:00

Erik Abrahamsson added the

Nodes & Physics

label 2023-03-07 01:24:20 +01:00

Brecht Van Lommel commented

2023-03-07 10:17:54 +01:00

Owner

This could be a performance problem.

I'd expect the spreadsheet to only display information that's readily available. If it has to traverse the tree for every grid in every draw that could be slow with a bunch of highly detailed volumes.

It may also cause the tree and voxels to be loaded from disk when it wasn't before.

This could be a performance problem. I'd expect the spreadsheet to only display information that's readily available. If it has to traverse the tree for every grid in every draw that could be slow with a bunch of highly detailed volumes. It may also cause the tree and voxels to be loaded from disk when it wasn't before.

Erik Abrahamsson commented

2023-03-07 12:10:34 +01:00

Author

Member

This could be a performance problem.

I'd expect the spreadsheet to only display information that's readily available. If it has to traverse the tree for every grid in every draw that could be slow with a bunch of highly detailed volumes.

It may also cause the tree and voxels to be loaded from disk when it wasn't before.

That's true, I didn't think that far.
Do you think it would make any sense to instead show the saved metadata for each grid (if available)? That is boundingbox min/max, memory usage and active voxel count.
The problem is this would have to be rewritten every time the grid is updated. But maybe that's not that bad, I don't know.

> This could be a performance problem. > > I'd expect the spreadsheet to only display information that's readily available. If it has to traverse the tree for every grid in every draw that could be slow with a bunch of highly detailed volumes. > > It may also cause the tree and voxels to be loaded from disk when it wasn't before. That's true, I didn't think that far. Do you think it would make any sense to instead show the saved metadata for each grid (if available)? That is boundingbox min/max, memory usage and active voxel count. The problem is this would have to be rewritten every time the grid is updated. But maybe that's not that bad, I don't know.

Iliya Katushenock commented

2023-03-07 12:35:03 +01:00

Member

It looks like a task for some kind of cache. Or a single-value attribute of the of the domain size...

It looks like a task for some kind of cache. Or a single-value attribute of the of the domain size...

Erik Abrahamsson commented

2023-03-07 12:54:10 +01:00

Author

Member

It looks like a task for some kind of cache. Or a single-value attribute of the of the domain size...

Grid metadata is a builtin feature of openvdb.

edit: I meant addStatsMetadata() and getStatsMetadata() from here

> It looks like a task for some kind of cache. Or a single-value attribute of the of the domain size... Grid metadata is a builtin feature of openvdb. edit: I meant `addStatsMetadata()` and `getStatsMetadata()` from [here](https://www.openvdb.org/documentation/doxygen/classopenvdb_1_1v10__0_1_1GridBase.html)

Brecht Van Lommel commented

2023-03-07 14:30:56 +01:00

Owner

Updating metadata for every edit or frame also has a cost. I guess it's acceptable if a user chose to inspect the volumes in the spreadsheet.

Perhaps this could still work like a cache, generating the metadata on demand when missing.

Updating metadata for every edit or frame also has a cost. I guess it's acceptable if a user chose to inspect the volumes in the spreadsheet. Perhaps this could still work like a cache, generating the metadata on demand when missing.

Hans Goudey requested changes 2023-03-08 21:50:15 +01:00

Hans Goudey left a comment

Member

I agree with Brecht's point here. I think the patch should demonstrate that this doesn't have a significant performance cost, or that should figure into the design somehow it does. Working with volumes is already expensive, we should be careful of making that worse.

I agree with Brecht's point here. I think the patch should demonstrate that this doesn't have a significant performance cost, or that should figure into the design somehow it does. Working with volumes is already expensive, we should be careful of making that worse.

Hans Goudey commented

2024-01-12 17:50:38 +01:00

Member

Closing this PR, since there are remaining questions about performance, and the volume API has changed significantly recently.

Closing this PR, since there are remaining questions about performance, and the volume API has changed significantly recently.

Hans Goudey closed this pull request

2024-01-12 17:50:40 +01:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105515

No description provided.